Skip to content

chore: Bump network-controller to 23.2.0, controller-utils to 11.7.0#14408

Merged
mcmire merged 1 commit intomainfrom
bump-network-controller-to-v23
Apr 3, 2025
Merged

chore: Bump network-controller to 23.2.0, controller-utils to 11.7.0#14408
mcmire merged 1 commit intomainfrom
bump-network-controller-to-v23

Conversation

@mcmire
Copy link
Copy Markdown
Contributor

@mcmire mcmire commented Apr 3, 2025

Description

These upgrades support the RPC failover and MegaETH initiatives.

The patch for network-controller is no longer needed because the changes there have been integrated into network-controller.

Related issues

Unblocks #14139, and other initiatives.

Manual testing steps

This PR should have no functional changes, everything should work the same way.

  1. Check out this branch and go through the setup steps to load the app onto your device or emulator.
  2. Create an account if necessary.
  3. Open the wallet to go the home screen. You should see no errors in your local console.
  4. Try to switch the network. You should see no errors.
  5. Try to send a transaction. You should see no errors.
  6. Open the browser, go to docs.metamask.io, tap the hamburger menu, go to Wallet API, tap the menu again, go to JSON-RPC API, tap the menu again, go to wallet_addEthereumChain.
  7. Click on "Connect MetaMask".
  8. Scroll down and run the request (which should add Gnosis). Accept the approval.
  9. You should get a modal saying that Gnosis has been switched to. You should not see any errors in your local terminal.

Screenshots/Recordings

(No screenshots/recordings, as everything should work the same way.)

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

These upgrades support the RPC failover and MegaETH initiatives.

The patch is no longer needed because the changes there have been
integrated into `network-controller`.
@mcmire mcmire requested a review from a team as a code owner April 3, 2025 18:33
@mcmire mcmire requested a review from a team April 3, 2025 18:33
@mcmire mcmire requested a review from a team as a code owner April 3, 2025 18:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/controller-utils@11.6.011.7.0 None 0 0 B
npm/@metamask/eth-json-rpc-infura@10.0.010.1.1 None +1 236 kB mcmire
npm/@metamask/eth-json-rpc-middleware@15.2.015.3.0 None 0 196 kB gudahtt

View full report↗︎

@metamaskbot metamaskbot added the team-wallet-framework-deprecated DEPRECATED: please use "team-core-platform" instead label Apr 3, 2025
@mcmire mcmire changed the title Bump network-controller to 23.2.0, controller-utils to 11.7.0 chore: Bump network-controller to 23.2.0, controller-utils to 11.7.0 Apr 3, 2025
@mathieuartu mathieuartu added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed labels Apr 3, 2025
@mcmire
Copy link
Copy Markdown
Contributor Author

mcmire commented Apr 3, 2025

This PR is a re-creation of #14273, which I closed too early 😬 I have compared the diffs with that PR and they are the same. We already ran CI on this branch and it succeeded, here is proof: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/52a960e9-9183-4754-b26e-4d9b72fb3dcb

@mcmire mcmire enabled auto-merge April 3, 2025 18:40
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 3, 2025

@mcmire mcmire added this pull request to the merge queue Apr 3, 2025
Merged via the queue into main with commit 2103e65 Apr 3, 2025
52 of 56 checks passed
@mcmire mcmire deleted the bump-network-controller-to-v23 branch April 3, 2025 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2025
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.45.0 Issue or pull request that will be included in release 7.45.0 team-wallet-framework-deprecated DEPRECATED: please use "team-core-platform" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants