Skip to content

chore: Bump network-controller to 23.2.0, controller-utils to 11.7.0#14273

Closed
mcmire wants to merge 3 commits intomainfrom
bump-network-controller-to-v23
Closed

chore: Bump network-controller to 23.2.0, controller-utils to 11.7.0#14273
mcmire wants to merge 3 commits intomainfrom
bump-network-controller-to-v23

Conversation

@mcmire
Copy link
Copy Markdown
Contributor

@mcmire mcmire commented Mar 27, 2025 •
edited
Loading

Description

These upgrades support the RPC failover and MegaETH initiatives.

The patch is no longer needed because the changes there have been
integrated into network-controller.

Related issues

Unblocks #14139, and other initiatives.

Manual testing steps

This PR should have no functional changes, everything should work the same way.

  1. Check out this branch and go through the setup steps to load the app onto your device or emulator.
  2. Create an account if necessary.
  3. Open the wallet to go the home screen. You should see no errors in your local console.
  4. Try to switch the network. You should see no errors.
  5. Try to send a transaction. You should see no errors.
  6. Open the browser, go to docs.metamask.io, tap the hamburger menu, go to Wallet API, tap the menu again, go to JSON-RPC API, tap the menu again, go to wallet_addEthereumChain.
  7. Click on "Connect MetaMask".
  8. Scroll down and run the request (which should add Gnosis). Accept the approval.
  9. You should get a modal saying that Gnosis has been switched to. You should not see any errors in your local terminal.

Screenshots/Recordings

(No screenshots/recordings, as everything should work the same way.)

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-wallet-framework-deprecated DEPRECATED: please use "team-core-platform" instead label Mar 27, 2025
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 27, 2025 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/controller-utils@11.6.0 ➜ 11.7.0 None 0 0 B
npm/@metamask/eth-json-rpc-infura@10.0.0 ➜ 10.1.1 None +1 236 kB mcmire
npm/@metamask/eth-json-rpc-middleware@15.2.0 ➜ 15.3.0 None 0 196 kB gudahtt

View full report↗︎

@mcmire mcmire changed the title WIP - Bump network-controller to v23.1.0 chore: WIP - Bump network-controller to v23.1.0 Mar 27, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f9c2dd5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c70bc321-2d2b-45d8-851d-0240f39df68c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

This was referenced Mar 31, 2025
Merged
Merged
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Apr 1, 2025
@mcmire mcmire mentioned this pull request Apr 1, 2025
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5800eb2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b4883237-bed5-49af-8e5f-f5c8dc7a231a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@mcmire
Copy link
Copy Markdown
Contributor Author

mcmire commented Apr 1, 2025

Right now this PR is using a preview build of network-controller to verify that there are no more bugs with the package.

If we can get this PR to pass, then next steps are to make a new release of network-controller and then bump the version on this PR to a non-preview build. Then I can open up this PR for proper review. I will also update the PR description and testing steps.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8e0a6a6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3cb5c13b-80e4-4c47-a7a6-ecd9141e6bef

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@mcmire mcmire mentioned this pull request Apr 1, 2025
Merged
4 tasks
@mcmire
Bump network-controller to 23.2.0, controller-utils to 11.7.0
7e7da0e 
These upgrades support the RPC failover and MegaETH initiatives.

The patch is no longer needed because the changes there have been
integrated into `network-controller`.
@mcmire mcmire force-pushed the bump-network-controller-to-v23 branch from 8e0a6a6 to 7e7da0e Compare April 2, 2025 15:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7e7da0e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d1e6d77-48d0-4ffb-ab13-258d2ba22368

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@mcmire mcmire changed the title chore: WIP - Bump network-controller to v23.1.0 chore: Bump network-controller to 23.2.0, controller-utils to 11.7.0 Apr 2, 2025
@mcmire
Copy link
Copy Markdown
Contributor Author

mcmire commented Apr 2, 2025

More e2e failures 😭 I will take a look shortly.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 117ecd2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dddbca93-8adb-4ecf-aa86-ee588a6cfcc9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 82c1063
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/05a6f021-c0c1-4c39-96fb-32c599a657fa

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mcmire mcmire marked this pull request as ready for review April 3, 2025 18:09
@mcmire mcmire requested a review from a team as a code owner April 3, 2025 18:09
@mcmire mcmire requested a review from a team April 3, 2025 18:09
@mcmire mcmire requested a review from a team as a code owner April 3, 2025 18:09
tommasini
tommasini approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 3, 2025
@mcmire mcmire added this pull request to the merge queue Apr 3, 2025
@mathieuartu
Copy link
Copy Markdown
Contributor

mathieuartu commented Apr 3, 2025

E2E was manually re-triggered and successful

@mcmire mcmire closed this Apr 3, 2025
@mcmire mcmire deleted the bump-network-controller-to-v23 branch April 3, 2025 18:26
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a manual request Apr 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

team-wallet-framework-deprecated DEPRECATED: please use "team-core-platform" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mcmire @mathieuartu @OGPoyraz @brianacnguyen @tommasini @Prithpal-Sooriya @metamaskbot