Skip to content

cherry-pick: @metamask/transaction-controller version to exact 45.0.0#13695

Merged
digiwand merged 1 commit into
release/7.41.0from
hardware_wallet_cherry_pick
Feb 24, 2025
Merged

cherry-pick: @metamask/transaction-controller version to exact 45.0.0#13695
digiwand merged 1 commit into
release/7.41.0from
hardware_wallet_cherry_pick

Conversation

@jpuri

@jpuri jpuri commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Description

Fix swaps done using hardware wallets.

Related issues

Fixes: #13570

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…3690)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Fixes: #13570

1. Go to this page...
2.
3.

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: jpuri <jyotipuri@gmail.com>
@jpuri jpuri added the team-confirmations Push issues to confirmations team label Feb 24, 2025
@jpuri jpuri requested a review from a team February 24, 2025 17:42
@jpuri jpuri requested a review from a team as a code owner February 24, 2025 17:42
@jpuri jpuri changed the title fix: @metamask/transaction-controller version to exact 45.0.0 cherry-pick: @metamask/transaction-controller version to exact 45.0.0 Feb 24, 2025
@socket-security

Copy link
Copy Markdown

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/transaction-controller@45.0.0 🔁 npm/@metamask/transaction-controller@45.1.0 None 0 2.18 MB metamaskbot

View full report↗︎

@sonarqubecloud

Copy link
Copy Markdown

@digiwand digiwand merged commit d00623f into release/7.41.0 Feb 24, 2025
@digiwand digiwand deleted the hardware_wallet_cherry_pick branch February 24, 2025 18:37
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Invalid QR Code when attempting to send/swap using Keystone device

3 participants