Skip to content

chore(runway): cherry-pick fix: cp-7.41.0 Prevent flickering on RetryModal#13669

Merged
sethkfman merged 1 commit into
release/7.41.0from
runway-cherry-pick-7.41.0-1740159174
Feb 21, 2025
Merged

chore(runway): cherry-pick fix: cp-7.41.0 Prevent flickering on RetryModal#13669
sethkfman merged 1 commit into
release/7.41.0from
runway-cherry-pick-7.41.0-1740159174

Conversation

@runway-github

@runway-github runway-github Bot commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

Description

This PR relocates RetryModal to stop flickering in
TransactionsHistory screen.

Related issues

Fixes: #13547

Manual testing steps

See issue #13547

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. bee0c07

…yModal` (#13637)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR relocates `RetryModal` to stop flickering in
`TransactionsHistory` screen.

## **Related issues**

Fixes: #13547

## **Manual testing steps**

See issue #13547

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@runway-github runway-github Bot requested review from a team as code owners February 21, 2025 17:33
@runway-github runway-github Bot force-pushed the runway-cherry-pick-7.41.0-1740159174 branch from 9b41685 to 64e64e3 Compare February 21, 2025 17:33
@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Feb 21, 2025
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 64e64e3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e993935d-1678-49c7-8af7-339c63ae85fc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit 812eeb0 into release/7.41.0 Feb 21, 2025
@sethkfman sethkfman deleted the runway-cherry-pick-7.41.0-1740159174 branch February 21, 2025 22:40
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants