Skip to content

fix: cp-7.41.0 Prevent flickering on RetryModal#13637

Merged
OGPoyraz merged 3 commits into
mainfrom
ogp/13634
Feb 21, 2025
Merged

fix: cp-7.41.0 Prevent flickering on RetryModal#13637
OGPoyraz merged 3 commits into
mainfrom
ogp/13634

Conversation

@OGPoyraz

@OGPoyraz OGPoyraz commented Feb 20, 2025

Copy link
Copy Markdown
Member

Description

This PR relocates RetryModal to stop flickering in TransactionsHistory screen.

Related issues

Fixes: #13547

Manual testing steps

See issue #13547

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner February 20, 2025 14:02
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 20, 2025
@github-actions

github-actions Bot commented Feb 20, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2488c38c83fd8391f94b8579f58b565e954b58ca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/524c048c-1369-4cc8-90f0-675e8e640f5e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

OGPoyraz
OGPoyraz commented Feb 20, 2025
View reviewed changes
Comment thread app/components/UI/Transactions/index.js Outdated
@github-actions

github-actions Bot commented Feb 20, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4007ed4b756af91ebdcaf235bb07132ac55ba80a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aaa0afd6-c133-4da4-83dd-7918b62dce1c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sleepytanya

sleepytanya commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

@OGPoyraz

Fixed!

QA builds: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0ff72647-0564-4000-b60d-0555ee0f3a23?tab=artifacts

Android:

android.mp4

iOS:

ios.mp4

@sleepytanya sleepytanya added the QA Passed QA testing has been completed and passed label Feb 20, 2025
@sleepytanya sleepytanya mentioned this pull request Feb 20, 2025
Closed
@OGPoyraz OGPoyraz requested a review from a team as a code owner February 21, 2025 09:14
@sonarqubecloud

sonarqubecloud Bot commented Feb 21, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Feb 21, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3b9460e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/59d87628-73f6-4807-872f-764db48157d9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

OGPoyraz
OGPoyraz commented Feb 21, 2025
View reviewed changes
Comment thread app/components/Views/Asset/__snapshots__/index.test.js.snap
OGPoyraz
OGPoyraz commented Feb 21, 2025
View reviewed changes
Comment thread app/components/Views/Asset/__snapshots__/index.test.js.snap
salimtb
salimtb approved these changes Feb 21, 2025
View reviewed changes

@salimtb salimtb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assets changes LGTM

@OGPoyraz OGPoyraz added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
@OGPoyraz OGPoyraz added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit bee0c07 Feb 21, 2025
@OGPoyraz OGPoyraz deleted the ogp/13634 branch February 21, 2025 11:39
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 21, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@salimtb salimtb salimtb approved these changes

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: After an attempt to cancel a transaction, users are spammed with the "Failed Transaction Update" banner

5 participants

@OGPoyraz @sleepytanya @matthewwalsh0 @salimtb @metamaskbot