Skip to content

chore: cherry-pick #13509 (test: Fixed swap chart test and remove bug workarounds)#13586

Merged
MarioAslau merged 1 commit into
release/7.41.0from
chore/cherry-pick-13509
Feb 18, 2025
Merged

chore: cherry-pick #13509 (test: Fixed swap chart test and remove bug workarounds)#13586
MarioAslau merged 1 commit into
release/7.41.0from
chore/cherry-pick-13509

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This PR cherry-picks #13509

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR fixes the swap chart tests and removes some bug workarounds now
that the bug has been fixed

## **Related issues**

Fixes: 13504

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@cortisiko cortisiko changed the title chore: cherry-pick #13509 chore: cherry-pick #13509 (test: Fixed swap chart test and remove bug workarounds) Feb 18, 2025
@cortisiko cortisiko marked this pull request as ready for review February 18, 2025 17:25
@cortisiko cortisiko requested a review from a team as a code owner February 18, 2025 17:25
@MarioAslau MarioAslau merged commit 228e190 into release/7.41.0 Feb 18, 2025
@MarioAslau MarioAslau deleted the chore/cherry-pick-13509 branch February 18, 2025 19:23
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants