Skip to content

test: Fixed swap chart test and remove bug workarounds#13509

Merged
davibroc merged 1 commit into
mainfrom
test/fix-swap-charts-e2e
Feb 14, 2025
Merged

test: Fixed swap chart test and remove bug workarounds#13509
davibroc merged 1 commit into
mainfrom
test/fix-swap-charts-e2e

Conversation

@davibroc

@davibroc davibroc commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes the swap chart tests and removes some bug workarounds now that the bug has been fixed

Related issues

Fixes: 13504

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@davibroc davibroc requested a review from a team as a code owner February 13, 2025 23:03
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: da09431
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/965d9004-5839-4b35-be53-01297f0f9358

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@davibroc davibroc linked an issue Feb 13, 2025 that may be closed by this pull request
@sonarqubecloud

Copy link
Copy Markdown

@cortisiko cortisiko added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@davibroc davibroc added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit ed663bf Feb 14, 2025
@davibroc davibroc deleted the test/fix-swap-charts-e2e branch February 14, 2025 00:48
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Fix Swaps Charts E2E test

3 participants