Skip to content

chore: cherry-pick #13554#13561

Merged
MarioAslau merged 1 commit into
release/7.41.0from
chore/cherry-pick-13554
Feb 17, 2025
Merged

chore: cherry-pick #13554#13561
MarioAslau merged 1 commit into
release/7.41.0from
chore/cherry-pick-13554

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This PR cherry-picks #13554

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:
[#4220](MetaMask/MetaMask-planning#4220)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@MarioAslau MarioAslau marked this pull request as ready for review February 17, 2025 17:28
@MarioAslau MarioAslau requested a review from a team February 17, 2025 17:28
@MarioAslau MarioAslau requested a review from a team as a code owner February 17, 2025 17:28
@MarioAslau MarioAslau added release-7.41.0 Issue or pull request that will be included in release 7.41.0 Run Smoke E2E labels Feb 17, 2025
@github-actions

github-actions Bot commented Feb 17, 2025

Copy link
Copy Markdown
Contributor Author

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4963ffb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f762293d-38fe-4e74-8fc8-fd4a1f0c8dd2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@MarioAslau MarioAslau merged commit a78b0fe into release/7.41.0 Feb 17, 2025
@MarioAslau MarioAslau deleted the chore/cherry-pick-13554 branch February 17, 2025 17:42
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

rc-cherry-picked release-7.41.0 Issue or pull request that will be included in release 7.41.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants