Skip to content

chore: Fix dependency version#13554

Merged
tommasini merged 2 commits into
mainfrom
fix/dependency-version
Feb 17, 2025
Merged

chore: Fix dependency version#13554
tommasini merged 2 commits into
mainfrom
fix/dependency-version

Conversation

@tommasini

@tommasini tommasini commented Feb 17, 2025 •
edited by vpintorico
Loading

Copy link
Copy Markdown
Contributor

Description

Related issues

Fixes: #4220

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team February 17, 2025 13:56
@tommasini tommasini requested a review from a team as a code owner February 17, 2025 13:56
@github-actions

github-actions Bot commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Feb 17, 2025
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E labels Feb 17, 2025
@github-actions

github-actions Bot commented Feb 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d536a2b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/39138bf4-3c66-44b0-941b-3f80969d8398

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Prithpal-Sooriya
Prithpal-Sooriya reviewed Feb 17, 2025
View reviewed changes
Comment thread yarn.lock
@sonarqubecloud

sonarqubecloud Bot commented Feb 17, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

naugtur
naugtur approved these changes Feb 17, 2025
View reviewed changes

@naugtur naugtur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should suffice for ensuring we're not vulnerable.

@tommasini tommasini enabled auto-merge February 17, 2025 16:56
@github-actions

github-actions Bot commented Feb 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 171cc12
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9475e4e3-7ca2-4aa8-b292-75faa3385bc1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit ab6a3a0 Feb 17, 2025
@tommasini tommasini deleted the fix/dependency-version branch February 17, 2025 17:22
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 17, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 17, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@naugtur naugtur naugtur approved these changes

@MarioAslau MarioAslau MarioAslau approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@salimtb salimtb salimtb approved these changes

@mikesposito mikesposito mikesposito approved these changes

Assignees

@tommasini tommasini

Labels

release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tommasini @naugtur @MarioAslau @Prithpal-Sooriya @salimtb @mikesposito @metamaskbot