Skip to content

chore: cherry-pick #13503#13537

Merged
MarioAslau merged 1 commit into
release/7.41.0from
chore/cherry-pick-13503
Feb 14, 2025
Merged

chore: cherry-pick #13503#13537
MarioAslau merged 1 commit into
release/7.41.0from
chore/cherry-pick-13503

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This PR cherry-picks #13503

…3503)

## **Description**

Added stories for the
`app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx`
component. Also, fixed a centering issue when animating

## **Related issues**

Fixes:
[#13492](#13492)

## **Manual testing steps**

1. Goto swaps page
2. When getting a quote you should see the animation with the fox
3. Open Storybook to view component under "Component Animations"

## **Screenshots/Recordings**

### Stories



https://github.com/user-attachments/assets/b63e64d4-0e5a-4966-9683-c20b732e27b5


### **Before**

NOTE: The animation slowly moves off center


https://github.com/user-attachments/assets/f491b7b2-5d03-470c-b8c4-110a942b9d92


### **After**


https://github.com/user-attachments/assets/aa4763ec-aafa-42ef-83b6-ddbeffd8afa8



<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@MarioAslau MarioAslau marked this pull request as ready for review February 14, 2025 20:39
@MarioAslau MarioAslau requested review from a team as code owners February 14, 2025 20:39
@MarioAslau MarioAslau merged commit d07a6f5 into release/7.41.0 Feb 14, 2025
@MarioAslau MarioAslau deleted the chore/cherry-pick-13503 branch February 14, 2025 20:41
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants