Skip to content

fix(13492): background shapes animation stories and centering fix#13503

Merged
vinnyhoward merged 2 commits into
mainfrom
fix-13492-background-shapes-animation
Feb 14, 2025
Merged

fix(13492): background shapes animation stories and centering fix#13503
vinnyhoward merged 2 commits into
mainfrom
fix-13492-background-shapes-animation

Conversation

@vinnyhoward

@vinnyhoward vinnyhoward commented Feb 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Added stories for the app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx component. Also, fixed a centering issue when animating

Related issues

Fixes: #13492

Manual testing steps

  1. Goto swaps page
  2. When getting a quote you should see the animation with the fox
  3. Open Storybook to view component under "Component Animations"

Screenshots/Recordings

Stories

stories.mp4

Before

NOTE: The animation slowly moves off center

before.mp4

After

Simulator.Screen.Recording.-.iPhone.16.-.2025-02-13.at.12.34.10.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested review from a team as code owners February 13, 2025 19:56
@github-actions

github-actions Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Feb 13, 2025
@github-actions

github-actions Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 2dbdda5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d1f1f5cf-2c3e-494e-9c2e-345be892ecf3

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward requested a review from a team as a code owner February 13, 2025 20:10
@github-actions

github-actions Bot commented Feb 13, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ebd60d3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/28ee266b-938f-44aa-955b-d35fb1309754

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Feb 13, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgeweiler

georgeweiler commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

LGTM I tested the ramp related changes in a local ios simulator.

@vinnyhoward vinnyhoward added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit da8fc7e Feb 14, 2025
@vinnyhoward vinnyhoward deleted the fix-13492-background-shapes-animation branch February 14, 2025 01:29
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@georgeweiler georgeweiler georgeweiler approved these changes

@infiniteflower infiniteflower infiniteflower approved these changes

Assignees

No one assigned

Labels

release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-core-extension-ux Core Extension UX team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Design System]: Add Stories component for new Background Shapes Animation

5 participants

@vinnyhoward @georgeweiler @brianacnguyen @infiniteflower @metamaskbot