-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Bug]: When Nearby devices permission is not granted, and the prompt is rejected the returned error could be improved #8718
Copy link
Copy link
Closed
Labels
LedgerLedger hardware wallet related issue or developmentLedger hardware wallet related issue or developmentPriority - MediumTask with medium priorityTask with medium priorityQA PassedQA testing has been completed and passedQA testing has been completed and passedSev3-lowA possible confusion or deception that is only hypothetical & has no known instances in the wildA possible confusion or deception that is only hypothetical & has no known instances in the wildregression-RCDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadregression-RC-7.17.0release-7.17.0Issue or pull request that will be included in release 7.17.0Issue or pull request that will be included in release 7.17.0team-hardware-wallets-deprecatedDEPRECATED: please use "team-accounts-framework" insteadDEPRECATED: please use "team-accounts-framework" insteadtype-bugSomething isn't workingSomething isn't working
Milestone
Metadata
Metadata
Assignees
Labels
LedgerLedger hardware wallet related issue or developmentLedger hardware wallet related issue or developmentPriority - MediumTask with medium priorityTask with medium priorityQA PassedQA testing has been completed and passedQA testing has been completed and passedSev3-lowA possible confusion or deception that is only hypothetical & has no known instances in the wildA possible confusion or deception that is only hypothetical & has no known instances in the wildregression-RCDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadregression-RC-7.17.0release-7.17.0Issue or pull request that will be included in release 7.17.0Issue or pull request that will be included in release 7.17.0team-hardware-wallets-deprecatedDEPRECATED: please use "team-accounts-framework" insteadDEPRECATED: please use "team-accounts-framework" insteadtype-bugSomething isn't workingSomething isn't working
Type
Fields
Give feedbackNo fields configured for issues without a type.
Describe the bug
Observed in RC 7.17.0 with Pixel 5a Android 14 in build 1266. After pairing and successfully transacting with Ledger, if I access settings>app>MetaMask and disable the
Nearby Devicespermission and attempt a transaction I encounter some challenges. Initially when I attempt the transaction I am prompted to enable Nearby Devices permission. If I allow, I can succesfully complete the transaction. However, if I reject that prompt I recieve an error message that may not be helpful for users and it is formatted poorly.In this case an error message should be presented to encourage the user to enable Nearby Devices permission for the MetaMask app in Android settings.
Rather than saying
Ledger needs location access to pair with your mobile deviceI believe it would be more accurate to say thatMetaMask needs permission to Nearby devices to pair with your LedgerExpected behavior
Given that I have disabled the
Nearby devicespermission in settingsWhen I attempt a tx
Then I am prompted to enable the needed permission
When I decline that prompt
Then I get an error message that explains that the permission is needed
And maybe even a link into the area of settings where a change is needed
Screenshots/Recordings
Granting permission when asked: https://recordit.co/4W9JniaG4E
Declining permission when asked: https://recordit.co/MbyA5Tx4nB
Still of the poorly formatted error:

Steps to reproduce
Nearby DevicesConfirm with LedgerDon't allowError messages or log output
No response
Version
7.17.0 RC1 build 1266
Build type
None
Device
Pixel 5a Android 14
Operating system
Android
Additional context
No response
Severity
No response