Skip to content

[Bug]: When Nearby devices permission is not granted, and the prompt is rejected the returned error could be improved #8718

@plasmacorral

Description

@plasmacorral

Describe the bug

Observed in RC 7.17.0 with Pixel 5a Android 14 in build 1266. After pairing and successfully transacting with Ledger, if I access settings>app>MetaMask and disable the Nearby Devices permission and attempt a transaction I encounter some challenges. Initially when I attempt the transaction I am prompted to enable Nearby Devices permission. If I allow, I can succesfully complete the transaction. However, if I reject that prompt I recieve an error message that may not be helpful for users and it is formatted poorly.

In this case an error message should be presented to encourage the user to enable Nearby Devices permission for the MetaMask app in Android settings.

Rather than saying Ledger needs location access to pair with your mobile device I believe it would be more accurate to say that MetaMask needs permission to Nearby devices to pair with your Ledger

Expected behavior

Given that I have disabled the Nearby devices permission in settings
When I attempt a tx
Then I am prompted to enable the needed permission
When I decline that prompt
Then I get an error message that explains that the permission is needed
And maybe even a link into the area of settings where a change is needed

Screenshots/Recordings

Granting permission when asked: https://recordit.co/4W9JniaG4E
Declining permission when asked: https://recordit.co/MbyA5Tx4nB

Still of the poorly formatted error:
Screenshot 2024-02-24 at 12 51 28 AM

Steps to reproduce

  1. Go to Settings>Apps>MetaMask and disable Nearby Devices
  2. Open MetaMask
  3. Attempt to send testnet eth
  4. After selecting a destination and an amount tap Confirm with Ledger
  5. When prompted for permission select Don't allow
  6. Note error

Error messages or log output

No response

Version

7.17.0 RC1 build 1266

Build type

None

Device

Pixel 5a Android 14

Operating system

Android

Additional context

No response

Severity

No response

Metadata

Metadata

Assignees

Labels

LedgerLedger hardware wallet related issue or developmentPriority - MediumTask with medium priorityQA PassedQA testing has been completed and passedSev3-lowA possible confusion or deception that is only hypothetical & has no known instances in the wildregression-RCDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadregression-RC-7.17.0release-7.17.0Issue or pull request that will be included in release 7.17.0team-hardware-wallets-deprecatedDEPRECATED: please use "team-accounts-framework" insteadtype-bugSomething isn't working

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions