Describe the issue
Increase ability to catch bugs at compile time. I.e. identify and resolve faster.

This is a follow-up to

• JavaScript static type errors #5878
• Type checking library declaration files #5881

which enables TSC to emit our remaining TS/TSX type errors to fix
~570ish errors in ~90ish files, tracked in our internal google sheet

• refactor: TypeScript ~4.8.4 and ESLint deps upgrades and initial type fixes #6080

once complete at 0 errors (and 0 warnings ideally)
we can re-enable TSC in our pre-commit hooks and CI

• TS check isn't working #4605
  • already partially complete in ci: Add type check lint to CI #7100

then later upgrade to TypeScript v5 once our MM shared ESLint config is on v5

• Migrate to TypeScript v5 stable #5984

a good long-term follow-up would be

• converting remaining .js files to ts remains, a huge task worthy of it's own umbrella issue / epic
  • e.g. app/util/transactions/index.js -> app/util/transactions/index.ts (no changes) exposes
  • Found 234 errors in 48 files -> Found 394 errors in 50 files

Screenshots

In issues above ^

To Reproduce

yarn tsc

Expected behavior

0 errors
0 warnings (ideally)

Smartphone (please complete the following information):

N/A

to be added after bug submission by internal support / PM
Severity

• How critical is the impact of this bug on a user?
• Add stats if available on % of customers impacted
• Is this visible to all users?
• Is this tech debt? yes