Description

Follow-up to: Slack convo linked below
Fix our current 18 JS static type errors detected running our TypeScript compiler

Screenshots

To Reproduce

yarn tsc # locally
tsc # globally, nb: if installed, likely a diff ver so results may vary

Expected behavior

No JS type errors

Technical Details

Currently we rely on IDE's (e.g. VSCode) to flag type errors during development and bump into these in runtime

JavaScript and JSX files cannot parse types (yet, see 2 refs below)

Next: Address remaining TypeScript errors

References

• https://consensys.slack.com/archives/G1L7H42BT/p1677193361291439
• https://consensys.slack.com/archives/C02U025CVU4/p1677256019459879

• https://devblogs.microsoft.com/typescript/a-proposal-for-type-syntax-in-javascript
• https://github.com/tc39/proposal-type-annotations

• TS check isn't working #4605

Severity

• Is this tech debt? ✅

cc @Cal-L @gantunesr