Skip to content

Commit 3d1dee5

Browse files
runway-github[bot]dawnseeker8Copilot
authored
chore(runway): cherry-pick fix: 28589 resolve the ledger monad swap issue. cp-7.79.0 (#30755)
- fix: 28589 resolve the ledger monad swap issue. cp-7.79.0 (#29091) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Ledger hardware wallet users on Monad (and other chains / contracts without a matching Ledger plugin) were hitting a misleading "blind signing is not enabled" error when trying to complete gas-sponsored swaps, even though blind signing was enabled on the device. this PR will resolve the issue #28589 to use new @metamask/eth-ledger-keyring-bridge` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Fixed a misleading "blind signing is not enabled" error preventing Ledger hardware wallet users from completing gas-sponsored swaps on Monad and other chains without a matching Ledger plugin. ## **Related issues** Fixes: #28589 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes only the Ledger hardware-wallet signing dependency path used for transactions/swaps; no local code review surface beyond the version bump. > > **Overview** > Bumps **`@metamask/eth-ledger-bridge-keyring`** from `^12.0.2` to **`^12.1.0`** (and refreshes **`yarn.lock`**) so Ledger signing uses the updated bridge stack—**`@metamask/keyring-sdk` ^2.1.1**, explicit **`@ledgerhq/hw-transport`**, and newer **`@ledgerhq/*`** transport/device/error packages. > > There are **no app source changes**; behavior comes from the upgraded package. The intent is to stop a false **“blind signing is not enabled”** failure when Ledger users complete **gas-sponsored swaps on Monad** (and similar chains without a matching Ledger plugin), as in #28589. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b7d5043. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> [6fa3aa4](6fa3aa4) Co-authored-by: Xiaoming Wang <7315988+dawnseeker8@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
1 parent d1b796e commit 3d1dee5

2 files changed

Lines changed: 43 additions & 18 deletions

File tree

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@
271271
"@metamask/eth-hd-keyring": "^14.1.1",
272272
"@metamask/eth-json-rpc-filters": "^9.0.0",
273273
"@metamask/eth-json-rpc-middleware": "^23.1.2",
274-
"@metamask/eth-ledger-bridge-keyring": "^12.0.2",
274+
"@metamask/eth-ledger-bridge-keyring": "^12.1.0",
275275
"@metamask/eth-money-keyring": "^2.0.4",
276276
"@metamask/eth-qr-keyring": "^2.0.2",
277277
"@metamask/eth-query": "^4.0.0",

‎yarn.lock‎

Lines changed: 42 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7269,7 +7269,7 @@ __metadata:
72697269
languageName: node
72707270
linkType: hard
72717271

7272-
"@ledgerhq/devices@npm:8.10.0, @ledgerhq/devices@npm:^8.4.5":
7272+
"@ledgerhq/devices@npm:8.10.0":
72737273
version: 8.10.0
72747274
resolution: "@ledgerhq/devices@npm:8.10.0"
72757275
dependencies:
@@ -7281,6 +7281,18 @@ __metadata:
72817281
languageName: node
72827282
linkType: hard
72837283

7284+
"@ledgerhq/devices@npm:8.14.0, @ledgerhq/devices@npm:^8.4.5":
7285+
version: 8.14.0
7286+
resolution: "@ledgerhq/devices@npm:8.14.0"
7287+
dependencies:
7288+
"@ledgerhq/errors": "npm:^6.33.0"
7289+
"@ledgerhq/logs": "npm:^6.17.0"
7290+
rxjs: "npm:7.8.2"
7291+
semver: "npm:7.7.3"
7292+
checksum: 10/8ae8e44e44ed4b6eca1ac626bdced01a753217ffc10dd2d4afa00f26bfd6a3efd26e7f1a86fede8e63646776e34d31c8b458b247e52a0a45ea675670040bd61c
7293+
languageName: node
7294+
linkType: hard
7295+
72847296
"@ledgerhq/devices@npm:8.4.6":
72857297
version: 8.4.6
72867298
resolution: "@ledgerhq/devices@npm:8.4.6"
@@ -7308,10 +7320,10 @@ __metadata:
73087320
languageName: node
73097321
linkType: hard
73107322

7311-
"@ledgerhq/errors@npm:^6.19.1, @ledgerhq/errors@npm:^6.21.0, @ledgerhq/errors@npm:^6.29.0":
7312-
version: 6.29.0
7313-
resolution: "@ledgerhq/errors@npm:6.29.0"
7314-
checksum: 10/0c82f1d50ceb474f9ca158c6709c77a0ecc4e8ef2eaedc76f128a55ad38967afcb9613ca6a54c805fdb78615c1ddea027a30802569e67d162dc57562b1cdf11e
7323+
"@ledgerhq/errors@npm:^6.19.1, @ledgerhq/errors@npm:^6.21.0, @ledgerhq/errors@npm:^6.29.0, @ledgerhq/errors@npm:^6.33.0":
7324+
version: 6.33.0
7325+
resolution: "@ledgerhq/errors@npm:6.33.0"
7326+
checksum: 10/129b8d1d571c9c09a9ee131fdd07880ac06ebb2a3d718ba48e9653fe14839eb3c6876e6809cf2f5737efad53b4ffd691b5d6425e059b275c5db9ec0d3f677112
73157327
languageName: node
73167328
linkType: hard
73177329

@@ -7374,7 +7386,7 @@ __metadata:
73747386
languageName: node
73757387
linkType: hard
73767388

7377-
"@ledgerhq/hw-transport@npm:6.32.0, @ledgerhq/hw-transport@npm:^6.31.4, @ledgerhq/hw-transport@npm:^6.31.5, @ledgerhq/hw-transport@npm:^6.31.6":
7389+
"@ledgerhq/hw-transport@npm:6.32.0":
73787390
version: 6.32.0
73797391
resolution: "@ledgerhq/hw-transport@npm:6.32.0"
73807392
dependencies:
@@ -7386,6 +7398,18 @@ __metadata:
73867398
languageName: node
73877399
linkType: hard
73887400

7401+
"@ledgerhq/hw-transport@npm:^6.31.3, @ledgerhq/hw-transport@npm:^6.31.4, @ledgerhq/hw-transport@npm:^6.31.5, @ledgerhq/hw-transport@npm:^6.31.6":
7402+
version: 6.35.0
7403+
resolution: "@ledgerhq/hw-transport@npm:6.35.0"
7404+
dependencies:
7405+
"@ledgerhq/devices": "npm:8.14.0"
7406+
"@ledgerhq/errors": "npm:^6.33.0"
7407+
"@ledgerhq/logs": "npm:^6.17.0"
7408+
events: "npm:^3.3.0"
7409+
checksum: 10/099a7058486e33b42542f89241f823659f692038d5d3530cbca0f273d1fa81d1d0896fc2cf163371d4fd6e540b1233dcb3e030757fb0f0877eeca4e69f8f5393
7410+
languageName: node
7411+
linkType: hard
7412+
73897413
"@ledgerhq/live-env@npm:^2.4.1":
73907414
version: 2.4.1
73917415
resolution: "@ledgerhq/live-env@npm:2.4.1"
@@ -7396,10 +7420,10 @@ __metadata:
73967420
languageName: node
73977421
linkType: hard
73987422

7399-
"@ledgerhq/logs@npm:^6.12.0, @ledgerhq/logs@npm:^6.13.0, @ledgerhq/logs@npm:^6.14.0":
7400-
version: 6.14.0
7401-
resolution: "@ledgerhq/logs@npm:6.14.0"
7402-
checksum: 10/b30b6aeef9df181efe99476a84f95b89ada695c038fbc3f915410f0bae244a342df642f003582c71222b4388cdc58d281e88ae2532ba85911f580d0cbfa4bd3a
7423+
"@ledgerhq/logs@npm:^6.12.0, @ledgerhq/logs@npm:^6.13.0, @ledgerhq/logs@npm:^6.14.0, @ledgerhq/logs@npm:^6.17.0":
7424+
version: 6.17.0
7425+
resolution: "@ledgerhq/logs@npm:6.17.0"
7426+
checksum: 10/81332b4db29e1e76ee24f8d741d30152b5c0676e58feedebfde93c7ef4bd641813596d9402d734af779fe3cb6e28599b91b6e6f57ac0017d1231f7d2dad49404
74037427
languageName: node
74047428
linkType: hard
74057429

@@ -8411,20 +8435,21 @@ __metadata:
84118435
languageName: node
84128436
linkType: hard
84138437

8414-
"@metamask/eth-ledger-bridge-keyring@npm:^12.0.2":
8415-
version: 12.0.2
8416-
resolution: "@metamask/eth-ledger-bridge-keyring@npm:12.0.2"
8438+
"@metamask/eth-ledger-bridge-keyring@npm:^12.1.0":
8439+
version: 12.1.0
8440+
resolution: "@metamask/eth-ledger-bridge-keyring@npm:12.1.0"
84178441
dependencies:
84188442
"@ethereumjs/rlp": "npm:^5.0.2"
84198443
"@ethereumjs/tx": "npm:^5.4.0"
84208444
"@ethereumjs/util": "npm:^9.1.0"
84218445
"@ledgerhq/hw-app-eth": "npm:^6.42.0"
8446+
"@ledgerhq/hw-transport": "npm:^6.31.3"
84228447
"@metamask/eth-sig-util": "npm:^8.2.0"
84238448
"@metamask/hw-wallet-sdk": "npm:^0.8.0"
84248449
"@metamask/keyring-api": "npm:^23.1.0"
8425-
"@metamask/keyring-sdk": "npm:^2.0.2"
8450+
"@metamask/keyring-sdk": "npm:^2.1.1"
84268451
hdkey: "npm:^2.1.0"
8427-
checksum: 10/ae646d6c8824fcc4c9ce8832d9b239296222df97177f150ded7cc145c77c4030ed70c947456cb2037d756aa5e654e635e758e4b4c196f62a53e49dbf49f14761
8452+
checksum: 10/2d0a1c3a5c9df57d078d60b31ae46c1197ed24fe588c9651ecf7c1d2eccd6e432afe61085c31d99dc40c5540f41f2bf3e2e62f814bb76fcb96f7160554d5c368
84288453
languageName: node
84298454
linkType: hard
84308455

@@ -8845,7 +8870,7 @@ __metadata:
88458870
languageName: node
88468871
linkType: hard
88478872

8848-
"@metamask/keyring-sdk@npm:^2.0.2":
8873+
"@metamask/keyring-sdk@npm:^2.0.2, @metamask/keyring-sdk@npm:^2.1.1":
88498874
version: 2.1.1
88508875
resolution: "@metamask/keyring-sdk@npm:2.1.1"
88518876
dependencies:
@@ -35246,7 +35271,7 @@ __metadata:
3524635271
"@metamask/eth-hd-keyring": "npm:^14.1.1"
3524735272
"@metamask/eth-json-rpc-filters": "npm:^9.0.0"
3524835273
"@metamask/eth-json-rpc-middleware": "npm:^23.1.2"
35249-
"@metamask/eth-ledger-bridge-keyring": "npm:^12.0.2"
35274+
"@metamask/eth-ledger-bridge-keyring": "npm:^12.1.0"
3525035275
"@metamask/eth-money-keyring": "npm:^2.0.4"
3525135276
"@metamask/eth-qr-keyring": "npm:^2.0.2"
3525235277
"@metamask/eth-query": "npm:^4.0.0"

0 commit comments

Comments
 (0)