chore(runway): cherry-pick fix: 28589 resolve the ledger monad swap issue. cp-7.79.0#30755
Merged
Merged
Conversation
…ssue. cp-7.79.0 (#29091) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Ledger hardware wallet users on Monad (and other chains / contracts without a matching Ledger plugin) were hitting a misleading "blind signing is not enabled" error when trying to complete gas-sponsored swaps, even though blind signing was enabled on the device. this PR will resolve the issue #28589 to use new @metamask/eth-ledger-keyring-bridge` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Fixed a misleading "blind signing is not enabled" error preventing Ledger hardware wallet users from completing gas-sponsored swaps on Monad and other chains without a matching Ledger plugin. ## **Related issues** Fixes: #28589 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes only the Ledger hardware-wallet signing dependency path used for transactions/swaps; no local code review surface beyond the version bump. > > **Overview** > Bumps **`@metamask/eth-ledger-bridge-keyring`** from `^12.0.2` to **`^12.1.0`** (and refreshes **`yarn.lock`**) so Ledger signing uses the updated bridge stack—**`@metamask/keyring-sdk` ^2.1.1**, explicit **`@ledgerhq/hw-transport`**, and newer **`@ledgerhq/*`** transport/device/error packages. > > There are **no app source changes**; behavior comes from the upgraded package. The intent is to stop a false **“blind signing is not enabled”** failure when Ledger users complete **gas-sponsored swaps on Monad** (and similar chains without a matching Ledger plugin), as in #28589. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b7d5043. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
vpintorico
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ledger hardware wallet users on Monad (and other chains / contracts
without a matching Ledger plugin) were hitting a misleading "blind
signing is not enabled" error when trying to complete gas-sponsored
swaps, even though blind signing was enabled on the device.
this PR will resolve the issue #28589 to use new
@metamask/eth-ledger-keyring-bridge`
Changelog
CHANGELOG entry: Fixed a misleading "blind signing is not enabled" error
preventing Ledger hardware wallet users from completing gas-sponsored
swaps on Monad and other chains without a matching Ledger plugin.
Related issues
Fixes: #28589
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Changes only the Ledger hardware-wallet signing dependency path used
for transactions/swaps; no local code review surface beyond the version
bump.
Overview
Bumps
@metamask/eth-ledger-bridge-keyringfrom^12.0.2to^12.1.0(and refreshesyarn.lock) so Ledger signing uses theupdated bridge stack—
@metamask/keyring-sdk^2.1.1, explicit@ledgerhq/hw-transport, and newer@ledgerhq/*transport/device/error packages.
There are no app source changes; behavior comes from the upgraded
package. The intent is to stop a false “blind signing is not
enabled” failure when Ledger users complete gas-sponsored swaps on
Monad (and similar chains without a matching Ledger plugin), as in
#28589.
Reviewed by Cursor Bugbot for commit
b7d5043. Bugbot is set up for automated
code reviews on this repo. Configure
here.
Co-authored-by: copilot-swe-agent[bot] 198982749+Copilot@users.noreply.github.com 6fa3aa4