Skip to content

chore(runway): cherry-pick fix: 28589 resolve the ledger monad swap issue. cp-7.79.0#30755

Merged
vpintorico merged 1 commit into
release/7.79.0from
runway-cherry-pick-7.79.0-1779983101
May 28, 2026
Merged

chore(runway): cherry-pick fix: 28589 resolve the ledger monad swap issue. cp-7.79.0#30755
vpintorico merged 1 commit into
release/7.79.0from
runway-cherry-pick-7.79.0-1779983101

Conversation

@runway-github

@runway-github runway-github Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Description

Ledger hardware wallet users on Monad (and other chains / contracts
without a matching Ledger plugin) were hitting a misleading "blind
signing is not enabled" error when trying to complete gas-sponsored
swaps, even though blind signing was enabled on the device.
this PR will resolve the issue #28589 to use new
@metamask/eth-ledger-keyring-bridge`

Changelog

CHANGELOG entry: Fixed a misleading "blind signing is not enabled" error
preventing Ledger hardware wallet users from completing gas-sponsored
swaps on Monad and other chains without a matching Ledger plugin.

Related issues

Fixes: #28589

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Changes only the Ledger hardware-wallet signing dependency path used
for transactions/swaps; no local code review surface beyond the version
bump.

Overview
Bumps @metamask/eth-ledger-bridge-keyring from ^12.0.2 to
^12.1.0 (and refreshes yarn.lock) so Ledger signing uses the
updated bridge stack—@metamask/keyring-sdk ^2.1.1, explicit
@ledgerhq/hw-transport, and newer @ledgerhq/*
transport/device/error packages.

There are no app source changes; behavior comes from the upgraded
package. The intent is to stop a false “blind signing is not
enabled”
failure when Ledger users complete gas-sponsored swaps on
Monad
(and similar chains without a matching Ledger plugin), as in
#28589.

Reviewed by Cursor Bugbot for commit
b7d5043. Bugbot is set up for automated
code reviews on this repo. Configure
here.


Co-authored-by: copilot-swe-agent[bot] 198982749+Copilot@users.noreply.github.com 6fa3aa4

…ssue. cp-7.79.0 (#29091)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Ledger hardware wallet users on Monad (and other chains / contracts
without a matching Ledger plugin) were hitting a misleading "blind
signing is not enabled" error when trying to complete gas-sponsored
swaps, even though blind signing was enabled on the device.
this PR will resolve the issue #28589 to use new
@metamask/eth-ledger-keyring-bridge`

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Fixed a misleading "blind signing is not enabled" error
preventing Ledger hardware wallet users from completing gas-sponsored
swaps on Monad and other chains without a matching Ledger plugin.

## **Related issues**

Fixes: #28589 

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [x] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [x] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [x] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.




<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes only the Ledger hardware-wallet signing dependency path used
for transactions/swaps; no local code review surface beyond the version
bump.
> 
> **Overview**
> Bumps **`@metamask/eth-ledger-bridge-keyring`** from `^12.0.2` to
**`^12.1.0`** (and refreshes **`yarn.lock`**) so Ledger signing uses the
updated bridge stack—**`@metamask/keyring-sdk` ^2.1.1**, explicit
**`@ledgerhq/hw-transport`**, and newer **`@ledgerhq/*`**
transport/device/error packages.
> 
> There are **no app source changes**; behavior comes from the upgraded
package. The intent is to stop a false **“blind signing is not
enabled”** failure when Ledger users complete **gas-sponsored swaps on
Monad** (and similar chains without a matching Ledger plugin), as in
#28589.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
b7d5043. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label May 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable)

All E2E tests pre-selected.

View GitHub Actions results

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​eth-ledger-bridge-keyring@​12.0.2 ⏵ 12.1.099 +110089 +196 +3100

View full report

@vpintorico vpintorico merged commit 3d1dee5 into release/7.79.0 May 28, 2026
208 of 210 checks passed
@vpintorico vpintorico deleted the runway-cherry-pick-7.79.0-1779983101 branch May 28, 2026 20:51
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-XS team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants