Merged
Conversation
Collaborator
Builds ready [693c2da]
Page Load Metrics (446 ± 75 ms)
|
darkwing
reviewed
Oct 28, 2020
| } | ||
| @include Paragraph; | ||
|
|
||
| &__dropdown { |
Contributor
There was a problem hiding this comment.
Are this and many others simply not used?
Contributor
Author
There was a problem hiding this comment.
Yes, they seem to be older styles that are no longer used.
darkwing
previously approved these changes
Oct 28, 2020
Contributor
darkwing
left a comment
There was a problem hiding this comment.
One question but presume styles are being used.
Gudahtt
reviewed
Oct 29, 2020
ui/app/pages/send/send-content/send-gas-row/send-gas-row.component.js
Outdated
Show resolved
Hide resolved
693c2da to
86f8dc3
Compare
Collaborator
Builds ready [86f8dc3]
Page Load Metrics (380 ± 66 ms)
|
Collaborator
Builds ready [6028578]
Page Load Metrics (470 ± 69 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #9693
A piece of the larger #9074 that focuses only on page styles. This PR has the least broad changes to QA, in that the changes should be isolated to the modified pages. That could be a fallacy though so test to your heart's content ❤️