expose variables for typography sizes#9693
Merged
brad-decker merged 1 commit intodevelopfrom Oct 28, 2020
Merged
Conversation
This will allow usage in areas where getting the line-height, etc of the typography settings will introduce issues. The mixins have been updated to references these variables so that they can be changed in one place in the future
This was referenced Oct 23, 2020
Collaborator
Builds ready [5bca990]
Page Load Metrics (484 ± 64 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow font sizes to use variables in areas where getting the line-height, etc. of the typography mixins will introduce issues. The mixins have been updated to reference these variables to create a single update location for font sizes.
First in a series of breaking apart #9074 that will make it easier to review.