Skip to content

normalize deprecated itcss font styles#9696

Merged
brad-decker merged 1 commit intodevelopfrom
normalize-itcss-fonts
Oct 29, 2020
Merged

normalize deprecated itcss font styles#9696
brad-decker merged 1 commit intodevelopfrom
normalize-itcss-fonts

Conversation

@brad-decker
Copy link
Copy Markdown
Contributor

depends on #9693

a small part of the larger #9074, this PR touches what is left of the itcss styles. These styles in this folder will eventually be removed or moved to a new location, but this moves the font styles into the correct shape ahead of their eventual departure.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [96459dc]
Page Load Metrics (447 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28403442
domContentLoaded29964844512058
load30165044712058
domInteractive29964844512058

Base automatically changed from expose-typography-vars to develop October 28, 2020 14:03
@brad-decker brad-decker marked this pull request as ready for review October 28, 2020 14:04
@brad-decker brad-decker requested a review from a team as a code owner October 28, 2020 14:04
@brad-decker brad-decker requested review from Gudahtt and robbiekruszynski and removed request for robbiekruszynski October 28, 2020 14:04
darkwing
darkwing previously approved these changes Oct 28, 2020
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Oct 29, 2020

LGTM! Just needs a rebase.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [b03a50f]
Page Load Metrics (426 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28403432
domContentLoaded24061542414067
load24261642614067
domInteractive24061442414067

@brad-decker brad-decker merged commit 50728ed into develop Oct 29, 2020
@brad-decker brad-decker deleted the normalize-itcss-fonts branch October 29, 2020 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants