normalize app component font styles#9695
Merged
brad-decker merged 1 commit intodevelopfrom Oct 29, 2020
Merged
Conversation
Collaborator
Builds ready [1f9816a]
Page Load Metrics (440 ± 67 ms)
|
darkwing
reviewed
Oct 28, 2020
| height: 41px; | ||
| @include Paragraph; | ||
|
|
||
| min-height: 41px; |
Member
|
LGTM! Except it needs a rebase. |
1f9816a to
26c213a
Compare
Gudahtt
approved these changes
Oct 29, 2020
Collaborator
Builds ready [26c213a]
Page Load Metrics (432 ± 73 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #9693
This PR is a piece of the larger #9074 PR. The recent rebase to include the swaps feature puts it into a state of needing full review once again. To minimize the pain and to keep the conversation on the PR from being too broad I have split it into a handful of smaller PRs. This PR focuses on App components which are not as broadly used as UI components.