Skip to content

Fix node/no-path-concat issues#9669

Merged
whymarrh merged 1 commit intoMetaMask:developfrom
whymarrh:fix-node/no-path-concat
Oct 22, 2020
Merged

Fix node/no-path-concat issues#9669
whymarrh merged 1 commit intoMetaMask:developfrom
whymarrh:fix-node/no-path-concat

Conversation

@whymarrh
Copy link
Copy Markdown
Contributor

Refs #9663

See node/no-path-concat for more information.

This change enables node/no-path-concat and fixes the issues raised by the rule.

Refs MetaMask#9663

See [`node/no-path-concat`][1] for more information.

This change enables `node/no-path-concat` and fixes the issues raised by the rule.

  [1]:https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-path-concat.md
@whymarrh whymarrh force-pushed the fix-node/no-path-concat branch from 8171e18 to c52b876 Compare October 21, 2020 18:29
@whymarrh whymarrh marked this pull request as ready for review October 21, 2020 18:52
@whymarrh whymarrh requested review from a team and kumavis as code owners October 21, 2020 18:52
@whymarrh whymarrh requested a review from Gudahtt October 21, 2020 19:01
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit b704eae into MetaMask:develop Oct 22, 2020
@whymarrh whymarrh deleted the fix-node/no-path-concat branch October 22, 2020 02:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants