Update @metamask/eslint-config to v4.1.0#9663
Conversation
6c0fd79 to
e7173a2
Compare
.eslintrc.js
Outdated
There was a problem hiding this comment.
node/shebang requires that the shebang is only used for scripts identified in the bin field of package.json. I think our development scripts should be exempt from this rule.
development/verify-locale-strings.js
Outdated
There was a problem hiding this comment.
These unreachable paths became detected with one of these package updates. Not entirely sure why.
e7173a2 to
e167e22
Compare
Builds ready [e167e22]
Page Load Metrics (380 ± 46 ms)
|
test/e2e/helpers.js
Outdated
There was a problem hiding this comment.
Hmm. Maybe we should rename this to something that isn't flagged as a callback? 🤔 I don't know if "callback" is the best description anyway.
It's more like a... wrapped function? Like "run this function in a specific environment". Callback implies to me that it's a way to signal when an async task has completed, which this is not.
test/unit/actions/tx_test.js
Outdated
There was a problem hiding this comment.
This was required due to node/no-callback-literal
@metamask/eslint-config to v4@metamask/eslint-config to v4.1.0
1a15b85 to
4d20d00
Compare
package.json
Outdated
There was a problem hiding this comment.
I updated this to use a ~ range because on v7.21.x I kept seeing false positives for the react/no-unused-prop-types, in cases where we use PropTypes.arrayOf(PropTypes.shape({ ... })) specifically.
I haven't found a similar bug report for this yet, so I'm going to do a little more digging and create one if necessary. In the meantime, I think ~7.20.0 has everything we need.
`@metamask/eslint-config` has been updated to v4.0.0. This update requires that we update `eslint` to v7 as well, which in turn requires updating most `eslint`-related packages. Most notably, `babel-eslint` was replaced with `@babel/eslint-parser`, and `babel-eslint-plugin` was replaced by `@babel/eslint-plugin`. This required renaming all the `babel/*` rules to `@babel/*`. Most new or updated rules that resulted in lint errors have been temporarily disabled. They will be fixed and re-enabled in subsequent PRs.
4d20d00 to
ba69b31
Compare
Builds ready [ba69b31]
Page Load Metrics (335 ± 18 ms)
|
@metamask/eslint-confighas been updated to v4.1.0. This update requires that we updateeslintto v7 as well, which in turn requires updating mosteslint-related packages.