Add a minimumGasLimit to the original gas customization modal#9623
Add a minimumGasLimit to the original gas customization modal#9623
Conversation
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
…er and make required in sub components
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [94d0734]
Page Load Metrics (427 ± 55 ms)
|
There was a problem hiding this comment.
This PR does not account for the usage of the gasLimitTooLow locale message as the constant GAS_LIMIT_TOO_LOW_ERROR_KEY in error-keys.js, which is used to produce error messages in the ConfirmPageContainerContent component via the getErrorKey method of ConfirmTransactionBase.
Perhaps the simplest solution is to preserve the original gasLimitTooLow locale message and create a new one that accepts a substitution?
| customPriceIsSafe: PropTypes.bool, | ||
| isSpeedUp: PropTypes.bool, | ||
| customGasLimitMessage: PropTypes.string, | ||
| minimumGasLimit: PropTypes.number.isRequired, |
There was a problem hiding this comment.
I think we still need a default of 21000 at the level at this component. This is kinda in conflict with the comment I made on the other PR (sorry 😅 ) but I just noticed that this component is used in 2 other distinct places, outside of the component where you're passing this through.
|
@rekmarks I've addressed your comment in 42cd1091c |
…TooLowWithDynamicFee
42cd109 to
779638d
Compare
Builds ready [22dcebc]
Page Load Metrics (432 ± 53 ms)
|
An alternative to #9600 that directly updates the existing gas customization modal, as opposed to the new swaps customization modal added in #9599
We will still want to do #9600, but doing it this way allows us to get this fix into prod faster, which will help reduce failed swaps.