Skip to content

Add a minimumGasLimit to the gas customization modal in swaps#9600

Merged
danjm merged 2 commits intodevelopfrom
swaps-minimum-gas-limit
Nov 10, 2020
Merged

Add a minimumGasLimit to the gas customization modal in swaps#9600
danjm merged 2 commits intodevelopfrom
swaps-minimum-gas-limit

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Oct 14, 2020 •
edited
Loading

This PR extends the functionality of the gas customization modal to accept a minimumGasLimit and to prevent the user from setting the gas limit below that minimum. This is used in the swaps view-quote screen to ensure the gas limit is always set to an amount that will avoid 'Out of gas' errors.

Demo

@danjm danjm requested a review from a team as a code owner October 14, 2020 15:21
@danjm danjm requested a review from Gudahtt October 14, 2020 15:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 14, 2020

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 14, 2020

Builds ready [c8b6f9c]
Page Load Metrics (426 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint297937105
domContentLoaded31068942411957
load31169042611957
domInteractive31068842411957

Gudahtt
Gudahtt reviewed Oct 14, 2020
View reviewed changes
@danjm danjm force-pushed the swaps-minimum-gas-limit branch from 30320eb to 883b861 Compare October 15, 2020 06:18
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 15, 2020

Builds ready [94d0734]
Page Load Metrics (530 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32123532512
domContentLoaded31592552817886
load31692753017886
domInteractive31492552817886

@danjm danjm force-pushed the swaps-minimum-gas-limit branch from 94d0734 to ebd1607 Compare October 16, 2020 09:36
@danjm danjm changed the base branch from develop to etherscan-api-swaps-gasprice October 16, 2020 09:37
@danjm danjm force-pushed the etherscan-api-swaps-gasprice branch from e7d578d to 1f95d2f Compare October 16, 2020 09:57
@danjm danjm force-pushed the swaps-minimum-gas-limit branch from ebd1607 to eed9b46 Compare October 16, 2020 10:00
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 16, 2020

Builds ready [eed9b46]
Page Load Metrics (370 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29393432
domContentLoaded2896063699847
load2906073709847
domInteractive2886063689847

@danjm danjm mentioned this pull request Oct 16, 2020
Merged
@Gudahtt Gudahtt marked this pull request as draft October 21, 2020 06:11
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Oct 21, 2020

I've just moved this into draft, since it appears to depend upon #9599 and is pointed at that branch.

@danjm danjm force-pushed the etherscan-api-swaps-gasprice branch 2 times, most recently from e7edabe to 64d27e8 Compare October 22, 2020 04:48
@danjm danjm force-pushed the swaps-minimum-gas-limit branch 2 times, most recently from d8c11ec to d2af763 Compare October 22, 2020 05:41
@danjm danjm mentioned this pull request Oct 22, 2020
Merged
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 22, 2020

Builds ready [d2af763]
Page Load Metrics (441 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32108492211
domContentLoaded31666144011354
load31766344111354
domInteractive31666143911354

@danjm danjm force-pushed the etherscan-api-swaps-gasprice branch 2 times, most recently from ae648eb to b590270 Compare October 22, 2020 20:09
@danjm danjm force-pushed the swaps-minimum-gas-limit branch from d2af763 to 339aa3b Compare October 23, 2020 10:07
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 23, 2020

Builds ready [339aa3b]
Page Load Metrics (426 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint308640126
domContentLoaded25066642412359
load25266742612259
domInteractive25066642412359

@danjm danjm force-pushed the etherscan-api-swaps-gasprice branch from 0d43898 to 17decb1 Compare October 29, 2020 15:58
@danjm danjm force-pushed the swaps-minimum-gas-limit branch from 339aa3b to 26c61ef Compare October 29, 2020 16:35
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 29, 2020

Builds ready [26c61ef]
Page Load Metrics (443 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint298238115
domContentLoaded24461544213364
load24561544313364
domInteractive24461444213364

@danjm danjm added this to the v8.1.next? milestone Nov 2, 2020
@danjm danjm force-pushed the etherscan-api-swaps-gasprice branch from 17decb1 to a417a68 Compare November 3, 2020 16:31
@danjm danjm force-pushed the etherscan-api-swaps-gasprice branch from a417a68 to 2630068 Compare November 4, 2020 02:43
@danjm danjm force-pushed the swaps-minimum-gas-limit branch from 26c61ef to 6f751d1 Compare November 4, 2020 02:47
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 4, 2020

Builds ready [6f751d1]
Page Load Metrics (443 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint299737147
domContentLoaded24972244114168
load25172344314168
domInteractive24972244114168

Base automatically changed from etherscan-api-swaps-gasprice to develop November 4, 2020 16:14
@danjm danjm force-pushed the swaps-minimum-gas-limit branch from 6f751d1 to e17bbd0 Compare November 4, 2020 16:35
@danjm danjm marked this pull request as ready for review November 4, 2020 16:36
@danjm
Copy link
Copy Markdown
Contributor Author

danjm commented Nov 4, 2020

@Gudahtt This has been rebased and moved out of draft

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 4, 2020

Builds ready [e17bbd0]
Page Load Metrics (401 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint297737105
domContentLoaded29560839911254
load29760940111254
domInteractive29560739911254

@danjm danjm force-pushed the swaps-minimum-gas-limit branch from e17bbd0 to 6cede74 Compare November 10, 2020 19:33
Gudahtt
Gudahtt approved these changes Nov 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 10, 2020

Builds ready [6cede74]
Page Load Metrics (361 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint319445189
domContentLoaded2585693607737
load2605723617737
domInteractive2585693597737

@danjm danjm merged commit 2540ca7 into develop Nov 10, 2020
@danjm danjm deleted the swaps-minimum-gas-limit branch November 10, 2020 20:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

@Gudahtt Gudahtt

Labels

area-swaps

Projects

None yet

Milestone

v8.1.next?

Development

Successfully merging this pull request may close these issues.

4 participants

@danjm @metamaskbot @Gudahtt @brad-decker