fix #6958: fix destructuring of lastSelectedProvider#8197
Merged
Gudahtt merged 1 commit intoMetaMask:developfrom Mar 16, 2020
Merged
fix #6958: fix destructuring of lastSelectedProvider#8197Gudahtt merged 1 commit intoMetaMask:developfrom
Gudahtt merged 1 commit intoMetaMask:developfrom
Conversation
Gudahtt
added a commit
that referenced
this pull request
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #6958 I see that this issue still exists.
The desired functionality was intended, the bug occurred due to trying to pull the lastSelectedProvider out of the metamask store instead of the appState. Simply moving the variable destructuring resolves the issue in dev.