Skip to content

Delete stale multi_vault_planning.md#7988

Merged
whymarrh merged 1 commit intodevelopfrom
delete-trash
Feb 6, 2020
Merged

Delete stale multi_vault_planning.md#7988
whymarrh merged 1 commit intodevelopfrom
delete-trash

Conversation

@whymarrh
Copy link
Copy Markdown
Contributor

@whymarrh whymarrh commented Feb 5, 2020

This PR deletes a stale and unnecessary doc file.

@whymarrh whymarrh requested a review from Gudahtt February 5, 2020 17:45
Gudahtt
Gudahtt previously approved these changes Feb 5, 2020
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [8697c34]
Page Load Metrics (657 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint359458199
domContentLoaded36776765510852
load36976965710852
domInteractive36776765410852

@whymarrh whymarrh merged commit 8196818 into develop Feb 6, 2020
@whymarrh whymarrh deleted the delete-trash branch February 6, 2020 16:22
yqrashawn pushed a commit to yqrashawn/conflux-portal that referenced this pull request Feb 14, 2020
github-merge-queue bot pushed a commit that referenced this pull request Feb 19, 2026
…RPC endpoint Segment events (#40176)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Add `rpc_method_name`, `type` and `retry_reason` to the `RPC Service
Degraded` Segment events. This lets us identify which JSON-RPC methods
produce the most slow requests or retry exhaustions, enabling better
debugging of RPC endpoint health issues.

Consumes the new `rpcMethodName`, `type` and `retryReason` field added
to `NetworkController:rpcEndpointDegraded` events in
`@metamask/network-controller` (core PR
[#7954](MetaMask/core#7954),
[#7988](MetaMask/core#7988)).

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/40176?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/WPC-441

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.




<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Primarily telemetry/schema changes, but the
`@metamask/network-controller` major-version bump plus LavaMoat policy
updates could affect runtime behavior or bundling if any dependency
allowances are incorrect.
> 
> **Overview**
> `NetworkController:rpcEndpointDegraded` handling is updated to consume
new event fields and emit richer `RPC Service Degraded` Segment
properties: `rpc_method_name`, degradation `type` (e.g. slow success vs
retries exhausted), and optional `retry_reason`.
> 
> This bumps `@metamask/network-controller` to `^30.0.0` (with related
lockfile updates) and updates LavaMoat policies to reflect the new
dependency graph/package nesting; tests are adjusted to assert the new
telemetry properties.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
1861770. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants