Switch signature-request e2e tests to using ganache#7859
Merged
Conversation
The signature request e2e tests were previously using ropsten. This expectation was even hard-coded into the test contract dapp. Instead the contract-dapp has been updated to use the current `chainId` when calling `signTypedData` (falling back to the `networkId` if `chainId` is not set). The fixture used by `signature-request` has been updated to use ganache.
Collaborator
Builds ready [435ae85]
|
whymarrh
approved these changes
Jan 17, 2020
Contributor
whymarrh
left a comment
There was a problem hiding this comment.
LGTM, this is a good idea
tmashuang
approved these changes
Jan 17, 2020
yqrashawn
pushed a commit
to yqrashawn/conflux-portal
that referenced
this pull request
Jan 19, 2020
The signature request e2e tests were previously using ropsten. This expectation was even hard-coded into the test contract dapp. Instead the contract-dapp has been updated to use the current `chainId` when calling `signTypedData` (falling back to the `networkId` if `chainId` is not set). The fixture used by `signature-request` has been updated to use ganache.
yqrashawn
pushed a commit
to Conflux-Chain/conflux-portal
that referenced
this pull request
Jan 19, 2020
The signature request e2e tests were previously using ropsten. This expectation was even hard-coded into the test contract dapp. Instead the contract-dapp has been updated to use the current `chainId` when calling `signTypedData` (falling back to the `networkId` if `chainId` is not set). The fixture used by `signature-request` has been updated to use ganache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signature request e2e tests were previously using ropsten. This expectation was even hard-coded into the test contract dapp.
Instead the contract-dapp has been updated to use the current
chainIdwhen callingsignTypedData(falling back to thenetworkIdifchainIdis not set). The fixture used bysignature-requesthas been updated to use ganache.