Skip to content

Purge xtend from the background scripts#7796

Merged
frankiebee merged 1 commit intoMetaMask:developfrom
whymarrh:purge-xtend
Jan 13, 2020
Merged

Purge xtend from the background scripts#7796
frankiebee merged 1 commit intoMetaMask:developfrom
whymarrh:purge-xtend

Conversation

@whymarrh
Copy link
Copy Markdown
Contributor

@whymarrh whymarrh commented Jan 9, 2020

Similar to #7795

This PR removes xtend usages, replacing them with a shallow copy via the spread syntax (or Object.assign where that's a cleaner diff). This functionality doesn't require an external library anymore.

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankiebee frankiebee merged commit 25fe4ad into MetaMask:develop Jan 13, 2020
@whymarrh whymarrh deleted the purge-xtend branch January 14, 2020 16:21
yqrashawn pushed a commit to yqrashawn/conflux-portal that referenced this pull request Jan 15, 2020
yqrashawn pushed a commit to Conflux-Chain/conflux-portal that referenced this pull request Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants