Conversation
41532c1 to
2dc6fb8
Compare
Collaborator
Builds ready [2dc6fb8]
|
2dc6fb8 to
74a1e58
Compare
Collaborator
Builds ready [74a1e58]
|
Gudahtt
commented
Dec 9, 2019
74a1e58 to
11e819e
Compare
Contributor
|
Seems the fixtureServer isn't initializing before the extension is initialized. Could be the background conditional not hitting as well. Don't really know on first glance. For reference: |
An alternative persistent state store has been created for use with e2e tests. Instead of reading state from disk, it tries to load state from a local fixture server running on port `12345` and serving state from the path `/state.json`, and returns a blank state otherwise.
A fixture server has been added for serving background state, which the background will read upon startup as part of restoring persisted state. The `signature-request` e2e test has been updated to use a fixture to bypass the registration step. The fixture used (`imported-account`) was generated by pausing midway through that test run
11e819e to
50d943d
Compare
Collaborator
Builds ready [50d943d]
|
tmashuang
approved these changes
Dec 9, 2019
Gudahtt
added a commit
that referenced
this pull request
Jan 17, 2020
As of #7663, an in-memory store was used in place of local storage during e2e tests, to facilitate the use of state fixtures. However, this made it difficult to export state during a test run. The instructions for exporting state to create fixtures assumed that local storage was being used. A new global function has been added to the background context to allow exporting state. This method is available during testing and development, and it works with either local storage or the in-memory store. The fixture instructions have been updated to reference this new function.
Gudahtt
added a commit
that referenced
this pull request
Jan 17, 2020
As of #7663, an in-memory store was used in place of local storage during e2e tests, to facilitate the use of state fixtures. However, this made it difficult to export state during a test run. The instructions for exporting state to create fixtures assumed that local storage was being used. A new global function has been added to the background context to allow exporting state. This method is available during testing and development, and it works with either local storage or the in-memory store. The fixture instructions have been updated to reference this new function.
yqrashawn
pushed a commit
to yqrashawn/conflux-portal
that referenced
this pull request
Jan 19, 2020
As of MetaMask#7663, an in-memory store was used in place of local storage during e2e tests, to facilitate the use of state fixtures. However, this made it difficult to export state during a test run. The instructions for exporting state to create fixtures assumed that local storage was being used. A new global function has been added to the background context to allow exporting state. This method is available during testing and development, and it works with either local storage or the in-memory store. The fixture instructions have been updated to reference this new function.
yqrashawn
pushed a commit
to Conflux-Chain/conflux-portal
that referenced
this pull request
Jan 19, 2020
As of MetaMask#7663, an in-memory store was used in place of local storage during e2e tests, to facilitate the use of state fixtures. However, this made it difficult to export state during a test run. The instructions for exporting state to create fixtures assumed that local storage was being used. A new global function has been added to the background context to allow exporting state. This method is available during testing and development, and it works with either local storage or the in-memory store. The fixture instructions have been updated to reference this new function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the work started in #6873 to improve our end-to-end tests. I'm hoping to bring that PR in one piece at a time; ganache fixtures, the new webdriver module, and the
withFixtureshelper function will be added in subsequent PRs.Add network store for testing
An alternative persistent state store has been created for use with e2e tests. Instead of reading state from disk, it tries to load state from a local fixture server running on port
12345and serving state from the path/state.json.Add e2e test fixture server
A fixture server has been added for serving background state, which the background will read upon startup as part of restoring persisted state.
The
signature-requeste2e test has been updated to use a fixture to bypass the registration step. The fixture used (imported-account) was generated by pausing midway through that test run