Skip to content

add migration 34 and 35#7001

Merged
whymarrh merged 1 commit intodevelopfrom
add-migrations
Aug 14, 2019
Merged

add migration 34 and 35#7001
whymarrh merged 1 commit intodevelopfrom
add-migrations

Conversation

@jennypollack
Copy link
Copy Markdown
Contributor

34 and 35 were not added to the index, which is used to actually run the migrations on update

whymarrh
whymarrh previously approved these changes Aug 13, 2019
Copy link
Copy Markdown
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ this is a good catch, thanks @jennypollack!

Gudahtt
Gudahtt previously approved these changes Aug 13, 2019
@whymarrh
Copy link
Copy Markdown
Contributor

@jennypollack if you want to rebase this on develop we can bypass the issues with Coveralls

@jennypollack jennypollack dismissed stale reviews from Gudahtt and whymarrh via ea057bf August 14, 2019 08:55
@jennypollack jennypollack requested a review from danjm as a code owner August 14, 2019 08:55
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [ea057bf]: chrome, firefox, edge, opera

@jennypollack jennypollack requested a review from whymarrh August 14, 2019 10:29
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [65071ca]: chrome, firefox, edge, opera

@whymarrh whymarrh merged commit f34afee into develop Aug 14, 2019
@whymarrh whymarrh deleted the add-migrations branch August 14, 2019 12:36
rekmarks added a commit that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants