fix: refresh token list immediately after import when assetsUnifyState is enabled by salimtb · Pull Request #40919 · MetaMask/metamask-extension

salimtb · 2026-03-16T11:05:55Z

Description

refresh token list immediately after import when assetsUnifyState is enabled

Changelog

CHANGELOG entry: refresh token list immediately after import when assetsUnifyState is enabled

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

after02.mov

after03.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes selector logic that shapes EVM token balances and currency rates when assetsUnifyState is enabled, which can affect asset display across networks. Risk is moderate due to added fallback behavior and placeholder balances, but scope is limited to derived state and is covered by new tests.

Overview
When assetsUnifyState is enabled, getTokenBalancesControllerTokenBalances now merges customAssets into the derived token balances by inserting zero-balance placeholders for custom EVM tokens that have metadata but no entry in assetsBalance yet, without overriding real balances and while skipping non-EVM custom assets.

getCurrencyRateControllerCurrencyRates now falls back to any chain-native slip44:* price key for the same EVM chain when the direct assetsInfo native-asset ID lookup is missing, improving native rate derivation for chains where pricing uses a chain-specific slip44.

Tests were updated/added to cover the new placeholder-balance behavior and guardrails (no overwrite, ignore non-EVM).

^{Written by Cursor Bugbot for commit a4e8638. This will update automatically on new commits. Configure here.}

…e is enabled

github-actions · 2026-03-16T11:06:06Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-16T11:44:45Z

Builds ready [c9c6e7a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 278 268 293 10 278 293
total 278 268 293 10 278 293
Confirm Tx confirm_tx 6014 6000 6041 15 6021 6041
total 6014 6000 6041 15 6021 6041
Bridge User Actions bridge_load_page 234 200 288 32 240 288
bridge_load_asset_picker 255 225 283 20 270 283
bridge_search_token 759 743 781 15 772 781
total 1238 1226 1248 10 1246 1248

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1501 1260 1830 115 1552 1693
load 1246 1030 1568 109 1305 1437
domContentLoaded 1239 1023 1564 107 1299 1431
domInteractive 31 18 133 23 26 92
firstPaint 187 71 1511 213 218 398
backgroundConnect 218 198 278 15 221 255
firstReactRender 20 13 51 5 21 26
initialActions 1 0 6 1 2 4
loadScripts 1038 831 1357 105 1098 1227
setupStore 13 6 41 6 15 21
numNetworkReqs 40 31 82 16 40 78
Power User Home uiStartup 6157 2184 17360 2828 6545 10940
load 1337 1125 3060 257 1340 1671
domContentLoaded 1318 1122 3052 255 1327 1612
domInteractive 38 20 166 33 32 134
firstPaint 235 82 1227 170 286 396
backgroundConnect 2855 372 14588 2774 3769 8215
firstReactRender 24 17 48 5 27 31
initialActions 1 0 4 1 1 3
loadScripts 1094 919 2800 249 1089 1366
setupStore 15 7 51 6 17 26
numNetworkReqs 209 103 356 56 232 321

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 218 217 219 1 219 219
srpButtonToSrpForm 95 93 96 1 95 96
confirmSrpToPwForm 23 22 24 1 24 24
pwFormToMetricsScreen 15 15 16 0 16 16
metricsToWalletReadyScreen 17 16 18 1 17 18
doneButtonToHomeScreen 587 573 609 16 609 609
openAccountMenuToAccountListLoaded 2986 2709 3160 162 3137 3160
total 3915 3886 3964 29 3909 3964
Onboarding New Wallet createWalletToSocialScreen 219 218 221 1 220 221
srpButtonToPwForm 113 112 114 1 114 114
createPwToRecoveryScreen 9 9 9 0 9 9
skipBackupToMetricsScreen 41 39 42 1 41 42
agreeButtonToOnboardingSuccess 17 16 18 0 17 18
doneButtonToAssetList 534 495 571 27 542 571
total 949 897 994 36 965 994
Asset Details assetClickToPriceChart 79 76 83 3 83 83
total 79 76 83 3 83 83
Solana Asset Details assetClickToPriceChart 109 107 112 2 112 112
total 109 107 112 2 112 112
Import Srp Home loginToHomeScreen 2303 2232 2358 44 2339 2358
openAccountMenuAfterLogin 62 51 71 7 68 71
homeAfterImportWithNewWallet 1323 453 2433 910 2433 2433
total 3688 2882 4836 894 4723 4836
Send Transactions openSendPageFromHome 44 24 74 21 65 74
selectTokenToSendFormLoaded 47 29 76 21 68 76
reviewTransactionToConfirmationPage 1136 949 1416 221 1398 1416
total 1227 1016 1531 226 1474 1531
Swap openSwapPageFromHome 85 28 128 36 115 128
fetchAndDisplaySwapQuotes 2688 2686 2691 2 2687 2691
total 2762 2716 2807 34 2779 2807

🌐 Dapp Page Load Benchmarks

Current Commit: c9c6e7a | Date: 3/16/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 736ms (±38ms) 🟢 | historical mean value: 742ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±10ms) 🟢 | historical mean value: 85ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	40ms	1.02s	1.34s	1.10s	1.34s
domContentLoaded	736ms	38ms	712ms	1.02s	765ms	1.02s
firstPaint	80ms	10ms	64ms	160ms	88ms	160ms
firstContentfulPaint	80ms	10ms	64ms	160ms	88ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 5.27 KiB (0.06%)
common: 923 Bytes (0.01%)

…balance on import (#8202) ## Explanation **Current state / problem:** UI PR: MetaMask/metamask-extension#40919 When a user imports a custom ERC20 token via `wallet_watchAsset` (e.g. a self-deployed token on Sepolia that is not indexed by the MetaMask tokens API), `addCustomAsset` is called with `pendingMetadata` containing the correct `symbol`, `name`, `decimals`, and `image`. This metadata is immediately persisted into `assetsInfo` so the UI can render the token without waiting for a backend fetch. However, `addCustomAsset` then calls `getAssets()` with `forceUpdate: true`, which triggers `#updateState`. The tokens API has no knowledge of this custom token and returns `{ symbol: "", name: "", decimals: 18 }`. The unconditional `metadata[key] = value` assignment in `#updateState` blindly overwrites the correct `pendingMetadata` with this empty API response. This causes three cascading issues: 1. **Wrong balance** — the raw on-chain balance is divided by `10^18` instead of the token's real decimals (e.g. `10^4`), producing a value like `1e-13` instead of `10` 2. **BigInt crash** — the scientific-notation balance string crashes `BigInt` parsing downstream: `SyntaxError: Cannot convert 1e-13 to a BigInt` 3. **Missing display data** — the token renders with no symbol and no name A second issue compounds this: `RpcDataSource.fetch()` was passing an empty `[]` for token addresses to `fetchBalancesForTokens`, meaning only the native token balance (e.g. ETH) was fetched via RPC. Custom ERC20 tokens in `request.customAssets` were completely ignored, so the on-chain ERC20 balance was never actually fetched during the initial import flow. **Solution:** Two fixes: 1. **Preserve `pendingMetadata` in `#updateState`** (`AssetsController.ts`): Before overwriting an entry in `assetsInfo`, check whether the incoming API response has both empty `symbol` and empty `name`. This is a reliable signal that the data source has no real knowledge of the token. When that condition is true and richer metadata already exists in state (from `pendingMetadata`), the existing `symbol`, `name`, `decimals`, and `image` are preserved while still merging any supplementary fields the API may provide (e.g. `aggregators`, `occurrences`). When the API returns real data (non-empty symbol or name), behaviour is unchanged. 2. **Forward custom asset addresses to `RpcDataSource.fetch()`** (`RpcDataSource.ts`): During a fetch, the method now extracts ERC20 token addresses from `request.customAssets` that match the chain currently being fetched, and passes them to `fetchBalancesForTokens`. This ensures the multicall includes the custom token so its on-chain balance is retrieved immediately after import. ## References * Fixes the `wallet_watchAsset` / custom token import bug reported internally * Related to the `pendingTokens` flow in the MetaMask extension ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them  --- > [!NOTE] > **Medium Risk** > Changes how `AssetsController` merges incoming token metadata and how `RpcDataSource` computes/requests ERC20 balances, which can affect displayed balances and requires extra RPC calls (including a new `decimals()` call fallback). > > **Overview** > Fixes custom token import flow so user-provided metadata isn’t overwritten by empty token-API responses: `AssetsController.#updateState` now preserves existing `symbol`/`name` (and keeps richer `decimals`/`image`) when the incoming metadata has both fields empty. > > Updates `RpcDataSource` to immediately fetch balances for imported custom ERC20s by extracting matching-chain ERC20 addresses from `request.customAssets` and passing them into `BalanceFetcher.fetchBalancesForTokens`; balance handling now normalizes CAIP-19 IDs, allows async balance-update callbacks, and adds an RPC `decimals()` fallback when decimals are missing. Tests and changelog are updated accordingly. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9e298fe. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>

…ter-import

metamaskbotv2 · 2026-03-17T16:26:27Z

Builds ready [c56e2e5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 292 268 335 26 309 335
total 292 268 335 26 309 335
Confirm Tx confirm_tx 6017 6007 6028 8 6019 6028
total 6017 6007 6028 8 6019 6028
Bridge User Actions bridge_load_page 261 216 304 32 270 304
bridge_load_asset_picker 186 158 209 23 207 209
bridge_search_token 733 699 762 25 761 762
total 1184 1111 1274 61 1201 1274

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1442 1232 1718 94 1493 1615
load 1190 990 1431 87 1240 1339
domContentLoaded 1184 983 1423 87 1233 1331
domInteractive 30 18 130 23 26 87
firstPaint 172 70 1250 168 198 341
backgroundConnect 209 195 244 9 212 221
firstReactRender 19 12 34 5 21 29
initialActions 1 0 5 1 2 4
loadScripts 989 790 1227 87 1041 1136
setupStore 13 6 29 5 16 22
numNetworkReqs 39 31 82 15 34 76
Power User Home uiStartup 5545 2253 18207 2976 6577 9906
load 1323 1124 1860 139 1388 1633
domContentLoaded 1302 1115 1812 131 1361 1580
domInteractive 38 19 196 35 32 122
firstPaint 240 91 1170 144 310 418
backgroundConnect 2071 331 15015 2581 3024 5783
firstReactRender 25 17 43 5 27 36
initialActions 1 0 5 1 1 4
loadScripts 1078 911 1535 119 1124 1349
setupStore 16 8 45 7 19 27
numNetworkReqs 160 67 310 47 179 265

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 219 223 2 223 223
srpButtonToSrpForm 98 94 105 4 101 105
confirmSrpToPwForm 23 22 24 1 24 24
pwFormToMetricsScreen 16 15 18 1 17 18
metricsToWalletReadyScreen 17 16 19 1 18 19
doneButtonToHomeScreen 610 598 623 10 617 623
openAccountMenuToAccountListLoaded 2928 2904 2966 23 2943 2966
total 3915 3893 3939 17 3923 3939
Onboarding New Wallet createWalletToSocialScreen 222 218 225 2 224 225
srpButtonToPwForm 113 113 114 1 113 114
createPwToRecoveryScreen 9 9 9 0 9 9
skipBackupToMetricsScreen 40 38 41 1 41 41
agreeButtonToOnboardingSuccess 17 16 17 0 17 17
doneButtonToAssetList 486 480 491 4 487 491
total 900 883 928 17 910 928
Asset Details assetClickToPriceChart 48 35 62 10 51 62
total 48 35 62 10 51 62
Solana Asset Details assetClickToPriceChart 130 75 178 37 158 178
total 130 75 178 37 158 178
Import Srp Home loginToHomeScreen 2296 2248 2358 40 2297 2358
openAccountMenuAfterLogin 98 55 174 48 133 174
homeAfterImportWithNewWallet 2345 2289 2392 39 2369 2392
total 4720 4672 4761 35 4746 4761
Send Transactions openSendPageFromHome 29 18 41 8 31 41
selectTokenToSendFormLoaded 32 21 44 8 35 44
reviewTransactionToConfirmationPage 1182 734 1581 278 1296 1581
total 1250 789 1665 289 1347 1665
Swap openSwapPageFromHome 119 70 145 27 141 145
fetchAndDisplaySwapQuotes 2689 2689 2690 1 2690 2690
total 2809 2760 2835 28 2831 2835

🌐 Dapp Page Load Benchmarks

Current Commit: c56e2e5 | Date: 3/17/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 734ms (±39ms) 🟢 | historical mean value: 736ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±10ms) 🟢 | historical mean value: 87ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	41ms	1.02s	1.36s	1.07s	1.36s
domContentLoaded	734ms	39ms	710ms	1.03s	761ms	1.03s
firstPaint	80ms	10ms	64ms	168ms	84ms	168ms
firstContentfulPaint	80ms	10ms	64ms	168ms	84ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 687 Bytes (0.01%)

shared/lib/selectors/assets-migration.ts

sonarqubecloud · 2026-03-17T17:58:55Z

Quality Gate failed

Failed conditions
72.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-17T18:23:17Z

Builds ready [a4e8638]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 283 278 293 6 280 293
total 283 278 293 6 280 293
Confirm Tx confirm_tx 6060 6052 6069 7 6064 6069
total 6060 6052 6069 7 6064 6069
Bridge User Actions bridge_load_page 267 217 319 36 295 319
bridge_load_asset_picker 235 197 271 29 265 271
bridge_search_token 759 751 768 6 761 768
total 1276 1272 1279 3 1279 1279

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1524 1230 1968 120 1614 1707
load 1266 1023 1663 106 1344 1423
domContentLoaded 1259 1016 1607 104 1337 1414
domInteractive 32 18 138 24 27 95
firstPaint 176 74 1145 126 218 323
backgroundConnect 221 198 317 15 226 241
firstReactRender 22 13 175 16 21 30
initialActions 2 0 6 2 2 5
loadScripts 1054 812 1397 102 1127 1198
setupStore 13 8 40 5 16 21
numNetworkReqs 39 31 85 16 40 78
Power User Home uiStartup 5259 2128 8931 1784 6512 7972
load 1302 1135 1764 123 1323 1576
domContentLoaded 1283 1127 1722 114 1307 1539
domInteractive 35 21 189 26 32 69
firstPaint 220 87 451 89 286 348
backgroundConnect 1666 301 5826 1294 2486 4232
firstReactRender 24 17 41 5 26 35
initialActions 1 0 4 1 1 3
loadScripts 1053 919 1479 109 1073 1315
setupStore 16 7 64 9 18 30
numNetworkReqs 136 65 318 43 149 244

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 221 1 219 221
srpButtonToSrpForm 95 94 96 1 95 96
confirmSrpToPwForm 22 22 22 0 22 22
pwFormToMetricsScreen 16 15 16 0 16 16
metricsToWalletReadyScreen 16 16 17 1 17 17
doneButtonToHomeScreen 627 590 668 28 630 668
openAccountMenuToAccountListLoaded 2925 2907 2942 15 2940 2942
total 3923 3902 3976 31 3910 3976
Onboarding New Wallet createWalletToSocialScreen 219 217 221 2 219 221
srpButtonToPwForm 113 111 118 3 115 118
createPwToRecoveryScreen 9 9 9 0 9 9
skipBackupToMetricsScreen 42 41 44 1 43 44
agreeButtonToOnboardingSuccess 17 17 17 0 17 17
doneButtonToAssetList 511 496 542 18 506 542
total 915 895 953 23 915 953
Asset Details assetClickToPriceChart 89 44 160 45 125 160
total 89 44 160 45 125 160
Solana Asset Details assetClickToPriceChart 161 84 221 47 191 221
total 161 84 221 47 191 221
Import Srp Home loginToHomeScreen 2310 2297 2332 15 2332 2332
openAccountMenuAfterLogin 62 40 76 15 76 76
homeAfterImportWithNewWallet 2352 2341 2361 8 2361 2361
total 4691 4633 4734 42 4734 4734
Send Transactions openSendPageFromHome 27 26 29 1 28 29
selectTokenToSendFormLoaded 28 25 30 2 30 30
reviewTransactionToConfirmationPage 1001 850 1276 170 1124 1276
total 1063 908 1330 165 1175 1330
Swap openSwapPageFromHome 118 101 132 14 129 132
fetchAndDisplaySwapQuotes 2692 2684 2702 7 2699 2702
total 2810 2784 2825 15 2819 2825

🌐 Dapp Page Load Benchmarks

Current Commit: a4e8638 | Date: 3/17/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±43ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 759ms (±62ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 96ms (±130ms) 🟢 | historical mean value: 87ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	43ms	1.05s	1.40s	1.10s	1.40s
domContentLoaded	759ms	62ms	731ms	1.32s	784ms	1.32s
firstPaint	96ms	130ms	72ms	1.39s	92ms	1.39s
firstContentfulPaint	96ms	130ms	72ms	1.39s	92ms	1.39s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 796 Bytes (0.01%)

fix: refresh token list immediately after import when assetsUnifyStat…

c9c6e7a

…e is enabled

salimtb temporarily deployed to pr-comment March 16, 2026 11:06 — with GitHub Actions Inactive

metamaskbot added the team-assets label Mar 16, 2026

github-actions bot added the size-M label Mar 16, 2026

salimtb temporarily deployed to pr-comment March 16, 2026 11:39 — with GitHub Actions Inactive

salimtb mentioned this pull request Mar 16, 2026

fix(assets-controller): preserve custom asset metadata and fetch RPC balance on import MetaMask/core#8202

Merged

4 tasks

Merge branch 'main' into fix/assets-unify-state-token-list-refresh-af…

c56e2e5

…ter-import

salimtb marked this pull request as ready for review March 17, 2026 15:36

salimtb requested a deployment to pr-comment March 17, 2026 15:36 — with GitHub Actions In progress

salimtb temporarily deployed to pr-comment March 17, 2026 15:37 — with GitHub Actions Inactive

salimtb temporarily deployed to pr-comment March 17, 2026 16:09 — with GitHub Actions Inactive

bergarces reviewed Mar 17, 2026

View reviewed changes

shared/lib/selectors/assets-migration.ts Outdated Show resolved Hide resolved

bergarces reviewed Mar 17, 2026

View reviewed changes

shared/lib/selectors/assets-migration.ts Outdated Show resolved Hide resolved

Prithpal-Sooriya reviewed Mar 17, 2026

View reviewed changes

shared/lib/selectors/assets-migration.ts Show resolved Hide resolved

Prithpal-Sooriya previously approved these changes Mar 17, 2026

View reviewed changes

fix: fix PR comments

a4e8638

salimtb dismissed Prithpal-Sooriya’s stale review via a4e8638 March 17, 2026 17:45

salimtb temporarily deployed to pr-comment March 17, 2026 17:45 — with GitHub Actions Inactive

salimtb requested review from Prithpal-Sooriya and bergarces March 17, 2026 17:47

salimtb temporarily deployed to pr-comment March 17, 2026 18:18 — with GitHub Actions Inactive

Prithpal-Sooriya approved these changes Mar 17, 2026

View reviewed changes

bergarces approved these changes Mar 18, 2026

View reviewed changes

salimtb added this pull request to the merge queue Mar 18, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2026

salimtb added this pull request to the merge queue Mar 18, 2026

Merged via the queue into main with commit 94854da Mar 18, 2026
182 of 183 checks passed

salimtb deleted the fix/assets-unify-state-token-list-refresh-after-import branch March 18, 2026 11:28

github-actions bot locked and limited conversation to collaborators Mar 18, 2026

metamaskbot added the release-13.24.0 Issue or pull request that will be included in release 13.24.0 label Mar 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: refresh token list immediately after import when assetsUnifyState is enabled#40919

fix: refresh token list immediately after import when assetsUnifyState is enabled#40919
salimtb merged 3 commits intomainfrom
fix/assets-unify-state-token-list-refresh-after-import

salimtb commented Mar 16, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

metamaskbotv2 bot commented Mar 16, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 17, 2026

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

salimtb commented Mar 16, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

metamaskbotv2 bot commented Mar 16, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 17, 2026

Quality Gate failed

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

salimtb commented Mar 16, 2026 •

edited by cursor bot

Loading