Skip to content

bump: Snaps dependencies#40790

Merged
Mrtenz merged 14 commits intomainfrom
mrtenz/snaps-146
Mar 12, 2026
Merged

bump: Snaps dependencies#40790
Mrtenz merged 14 commits intomainfrom
mrtenz/snaps-146

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 11, 2026

Description

This bumps Snaps dependencies to the latest versions.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Add support for additional icon colors in Snaps Icon component

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Upgrades multiple Snaps packages and the iframe execution environment, and adjusts controller/messenger APIs for Snap UI interfaces; regressions could affect snap dialogs/rendering and interface lifecycle tracking.

Overview
Bumps Snaps-related dependencies (SDK/controllers/RPC methods/utils), updates the iframe execution environment URL to 11.0.1, and refreshes E2E test Snap URLs to match the new versions.

Wires a new Snap interface action SnapInterfaceController:setInterfaceDisplayed through controller init messengers and Snap permission specs, and switches metamask-controller’s getInterfaceState to call SnapInterfaceController:getInterfaceState directly.

Updates Storybook/test fixtures to stop generating Snap UI content via @metamask/snaps-sdk helpers and instead use explicit serialized UI element objects, and ensures mocked interfaces include displayed: true.

Written by Cursor Bugbot for commit 9e48bde. This will update automatically on new commits. Configure here.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 11, 2026

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (1 files, +36 -30)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 confirmation/
          • 📁 stories/
            • 📄 snap-dialog.stories.tsx +36 -30

🫰 @MetaMask/core-platform (5 files, +18 -1)
  • 📁 app/
    • 📁 scripts/
      • 📁 controller-init/
        • 📁 messengers/
          • 📁 snaps/
            • 📄 snap-controller-messenger.ts +3 -0
      • 📁 controllers/
        • 📁 permissions/
          • 📁 snaps/
            • 📄 specifications.ts +7 -0
  • 📁 test/
    • 📁 e2e/
      • 📁 snaps/
        • 📄 enums.js +1 -1
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 snaps/
          • 📁 snap-ui-renderer/
            • 📁 components/
              • 📄 icon.ts +6 -0
              • 📄 test-utils.tsx +1 -0

@Mrtenz
Copy link
Member Author

Mrtenz commented Mar 11, 2026

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/browserify/beta/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/experimental/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/flask/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/webpack/mv2/beta/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from mv2/main/policy.json policy changes
✅ lavamoat/webpack/mv3/beta/policy.json changes match mv3/main/policy.json policy changes
✅ lavamoat/webpack/mv3/experimental/policy.json changes match mv3/main/policy.json policy changes
✅ lavamoat/webpack/mv3/flask/policy.json changes match mv3/main/policy.json policy changes

@socket-security
Copy link

socket-security bot commented Mar 11, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​test-snaps@​3.4.0 ⏵ 3.4.198 +110074 +194 +1100
Updated@​metamask/​snaps-utils@​12.1.0 ⏵ 12.1.1981007697100
Updated@​metamask/​snaps-rpc-methods@​14.3.0 ⏵ 15.0.09810076 +196 +150
Updated@​metamask/​snaps-execution-environments@​11.0.0 ⏵ 11.0.199 +11007797 +180
Addedses@​1.15.08710010092100

View full report

@socket-security
Copy link

socket-security bot commented Mar 11, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • ses@1.15.0

View full report

@Mrtenz
Copy link
Member Author

Mrtenz commented Mar 11, 2026

@metamaskbot update-policies

@Mrtenz
Copy link
Member Author

Mrtenz commented Mar 11, 2026

@SocketSecurity ignore npm/ses@1.15.0

Trusted author.

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/browserify/beta/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/experimental/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/flask/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/webpack/mv2/beta/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from mv2/main/policy.json policy changes
✅ lavamoat/webpack/mv3/beta/policy.json changes match mv3/main/policy.json policy changes
✅ lavamoat/webpack/mv3/experimental/policy.json changes match mv3/main/policy.json policy changes
✅ lavamoat/webpack/mv3/flask/policy.json changes match mv3/main/policy.json policy changes

@Mrtenz Mrtenz marked this pull request as ready for review March 11, 2026 12:38
@Mrtenz Mrtenz requested review from a team as code owners March 11, 2026 12:38
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 11, 2026

Builds ready [d2669ec]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account2692592778275277
total2692592778275277
Confirm Txconfirm_tx600159976004360046004
total600159976004360046004
Bridge User Actionsbridge_load_page24720731448296314
bridge_load_asset_picker1751681836180183
bridge_search_token71770373613724736
total1164108112306412251230
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14491212193812015061668
load1202993161410812411380
domContentLoaded1194988160610512371372
domInteractive2917106192579
firstPaint184691421224210347
backgroundConnect21319927813214241
firstReactRender2113174162133
initialActions108123
loadScripts997797140310410391172
setupStore1374151722
numNetworkReqs362798192786
Power User HomeuiStartup56232278166112891628511035
load13151135208814613751560
domContentLoaded12931127189413113481525
domInteractive3520146223576
firstPaint224831906214266358
backgroundConnect227432513947289529098849
firstReactRender26204452934
initialActions104113
loadScripts1064926160212011081293
setupStore1656491832
numNetworkReqs1849033153214289
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2192182201220220
srpButtonToSrpForm9794100297100
confirmSrpToPwForm22222202222
pwFormToMetricsScreen15151601616
metricsToWalletReadyScreen17161701717
doneButtonToHomeScreen68960076865746768
openAccountMenuToAccountListLoaded2933289829512129472951
total3999392440976240354097
Onboarding New WalletcreateWalletToSocialScreen2192192190219219
srpButtonToPwForm1031021051105105
createPwToRecoveryScreen888088
skipBackupToMetricsScreen35343613636
agreeButtonToOnboardingSuccess16151611616
doneButtonToAssetList49047950610488506
total87186088710870887
Asset DetailsassetClickToPriceChart15113417816160178
total15113417816160178
Solana Asset DetailsassetClickToPriceChart80738558485
total80738558485
Import Srp HomeloginToHomeScreen2389230725047223892504
openAccountMenuAfterLogin86571252494125
homeAfterImportWithNewWallet2446238924994024782499
total4920479150449249545044
Send TransactionsopenSendPageFromHome22173052130
selectTokenToSendFormLoaded301944114244
reviewTransactionToConfirmationPage1150848170536814791705
total1207883177738115511777
SwapopenSwapPageFromHome26252712727
fetchAndDisplaySwapQuotes268926852693326892693
total271427102721427132721
🌐 Dapp Page Load Benchmarks

Current Commit: d2669ec | Date: 3/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±39ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±12ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 42ms 1.03s 1.36s 1.07s 1.36s
domContentLoaded 724ms 39ms 705ms 1.00s 736ms 1.00s
firstPaint 80ms 12ms 64ms 180ms 92ms 180ms
firstContentfulPaint 80ms 12ms 64ms 180ms 92ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.28 KiB (0.06%)
  • ui: 16.37 KiB (0.19%)
  • common: -4.78 KiB (-0.04%)

cryptodev-2s
cryptodev-2s previously approved these changes Mar 11, 2026
@Mrtenz Mrtenz enabled auto-merge March 11, 2026 12:53
Mrtenz and others added 14 commits March 12, 2026 09:36
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Add mapping for additional icon colors.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/40797?quickstart=1)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Small, isolated UI mapping change that only affects icon color
rendering and has no security or data-handling impact.
> 
> **Overview**
> Adds support for additional `SnapUIIcon` color values by mapping
`error`, `warning`, and `success` to their corresponding design-system
`IconColor` tokens (in addition to existing `muted`/`primary`), while
keeping the default color fallback unchanged.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
2814622. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@Mrtenz Mrtenz dismissed stale reviews from OGPoyraz and FrederikBolding via 9e48bde March 12, 2026 08:38
@Mrtenz Mrtenz force-pushed the mrtenz/snaps-146 branch from a38525c to 9e48bde Compare March 12, 2026 08:38
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
10.0% Duplication on New Code (required ≤ 3%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 12, 2026

Builds ready [9e48bde]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account2772702855278285
total2772702855278285
Confirm Txconfirm_tx6040602760611260456061
total6040602760611260456061
Bridge User Actionsbridge_load_page23819228235273282
bridge_load_asset_picker24020428427248284
bridge_search_token7617527706762770
total1249121312953512891295
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14831239181310715151681
load1230101214909912781405
domContentLoaded1223100714869612701398
domInteractive3117121232695
firstPaint1567341975216249
backgroundConnect22120126915225252
firstReactRender20144362134
initialActions108113
loadScripts101881212679410731192
setupStore1373151622
numNetworkReqs362784173080
Power User HomeuiStartup61852215176632816657510568
load13281152320323813591603
domContentLoaded13071139318923113401554
domInteractive3319124203084
firstPaint1998152797278338
backgroundConnect233331514396284233628043
firstReactRender27194762939
initialActions104113
loadScripts1082913298122611051309
setupStore16789111733
numNetworkReqs2038333446224298
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2212192221221222
srpButtonToSrpForm100961043104104
confirmSrpToPwForm24232722627
pwFormToMetricsScreen17161911719
metricsToWalletReadyScreen17171801818
doneButtonToHomeScreen67360277373750773
openAccountMenuToAccountListLoaded2913290329271029162927
total3897388039111239043911
Onboarding New WalletcreateWalletToSocialScreen2192152233221223
srpButtonToPwForm1061031092108109
createPwToRecoveryScreen888088
skipBackupToMetricsScreen37363913839
agreeButtonToOnboardingSuccess16161711717
doneButtonToAssetList5004925087503508
total89687591616904916
Asset DetailsassetClickToPriceChart796296128096
total796296128096
Solana Asset DetailsassetClickToPriceChart1208017734128177
total1208017734128177
Import Srp HomeloginToHomeScreen23662210253211523832532
openAccountMenuAfterLogin75491102792110
homeAfterImportWithNewWallet1873545254778122532547
total43143038480773847284807
Send TransactionsopenSendPageFromHome542574217374
selectTokenToSendFormLoaded26212932729
reviewTransactionToConfirmationPage12101061137511112051375
total1264124412922012921292
SwapopenSwapPageFromHome1156815034139150
fetchAndDisplaySwapQuotes268826832695426872695
total2813275128784828372878
🌐 Dapp Page Load Benchmarks

Current Commit: 9e48bde | Date: 3/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±73ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 751ms (±70ms) 🟢 | historical mean value: 742ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 81ms (±14ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 73ms 1.02s 1.35s 1.30s 1.35s
domContentLoaded 751ms 70ms 712ms 1.02s 976ms 1.02s
firstPaint 81ms 14ms 64ms 196ms 92ms 196ms
firstContentfulPaint 81ms 14ms 64ms 196ms 92ms 196ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 1.87 KiB (0.04%)
  • ui: 145 Bytes (0%)
  • common: -5.52 KiB (-0.05%)

@Mrtenz Mrtenz added this pull request to the merge queue Mar 12, 2026
Merged via the queue into main with commit d6de4b9 Mar 12, 2026
183 of 184 checks passed
@Mrtenz Mrtenz deleted the mrtenz/snaps-146 branch March 12, 2026 10:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2026
@metamaskbot metamaskbot added the release-13.23.0 Issue or pull request that will be included in release 13.23.0 label Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.23.0 Issue or pull request that will be included in release 13.23.0 size-M team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants