Conversation
5d862bb to
5ceddf5
Compare
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +36 -30)
🫰 @MetaMask/core-platform (5 files, +18 -1)
|
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff 👀 lavamoat/browserify/beta/policy.json changes differ from main/policy.json policy changes |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
|
@metamaskbot update-policies |
|
@SocketSecurity ignore npm/ses@1.15.0 Trusted author. |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff 👀 lavamoat/browserify/beta/policy.json changes differ from main/policy.json policy changes |
Builds ready [d2669ec]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Add mapping for additional icon colors. [](https://codespaces.new/MetaMask/metamask-extension/pull/40797?quickstart=1) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Small, isolated UI mapping change that only affects icon color rendering and has no security or data-handling impact. > > **Overview** > Adds support for additional `SnapUIIcon` color values by mapping `error`, `warning`, and `success` to their corresponding design-system `IconColor` tokens (in addition to existing `muted`/`primary`), while keeping the default color fallback unchanged. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 2814622. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
a38525c to
9e48bde
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
Builds ready [9e48bde]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|




Description
This bumps Snaps dependencies to the latest versions.
Changelog
CHANGELOG entry: Add support for additional icon colors in Snaps
IconcomponentRelated issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Upgrades multiple Snaps packages and the iframe execution environment, and adjusts controller/messenger APIs for Snap UI interfaces; regressions could affect snap dialogs/rendering and interface lifecycle tracking.
Overview
Bumps Snaps-related dependencies (SDK/controllers/RPC methods/utils), updates the iframe execution environment URL to
11.0.1, and refreshes E2E test Snap URLs to match the new versions.Wires a new Snap interface action
SnapInterfaceController:setInterfaceDisplayedthrough controller init messengers and Snap permission specs, and switchesmetamask-controller’sgetInterfaceStateto callSnapInterfaceController:getInterfaceStatedirectly.Updates Storybook/test fixtures to stop generating Snap UI content via
@metamask/snaps-sdkhelpers and instead use explicit serialized UI element objects, and ensures mocked interfaces includedisplayed: true.Written by Cursor Bugbot for commit 9e48bde. This will update automatically on new commits. Configure here.