Skip to content

feat: Add support for additional icon colors in SnapUIIcon#40797

Merged
Mrtenz merged 1 commit intomrtenz/snaps-146from
fb/snaps-icon-colors-v146
Mar 11, 2026
Merged

feat: Add support for additional icon colors in SnapUIIcon#40797
Mrtenz merged 1 commit intomrtenz/snaps-146from
fb/snaps-icon-colors-v146

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Mar 11, 2026

Description

Add mapping for additional icon colors.

Open in GitHub Codespaces


Note

Low Risk
Small, isolated UI mapping change that only affects icon color rendering and has no security or data-handling impact.

Overview
Adds support for additional SnapUIIcon color values by mapping error, warning, and success to their corresponding design-system IconColor tokens (in addition to existing muted/primary), while keeping the default color fallback unchanged.

Written by Cursor Bugbot for commit 2814622. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner March 11, 2026 10:27
@metamaskbot metamaskbot added the team-core-platform Core Platform team label Mar 11, 2026
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Mar 11, 2026

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (1 files, +6 -0)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 snaps/
          • 📁 snap-ui-renderer/
            • 📁 components/
              • 📄 icon.ts +6 -0

@Mrtenz Mrtenz merged commit f1358dc into mrtenz/snaps-146 Mar 11, 2026
69 of 176 checks passed
@Mrtenz Mrtenz deleted the fb/snaps-icon-colors-v146 branch March 11, 2026 10:51
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants