fix(settings): remove "Proposed nicknames" from settings search results by cryptotavares · Pull Request #40772 · MetaMask/metamask-extension

cryptotavares · 2026-03-10T19:36:24Z

Description

"Proposed nicknames" (externalNameSourcesSetting) appeared as a search result in the Settings search, but clicking it did nothing because the corresponding UI toggle is conditionally rendered (gated behind petnamesEnabled) and the search-to-scroll ref mapping was misaligned.

This PR removes the search index entry from SETTINGS_CONSTANTS so the phantom result no longer appears. The actual toggle UI in the Security tab is left intact for users who have petnamesEnabled active.

Changelog

CHANGELOG entry: Fixed "Proposed nicknames" appearing as a non-functional result in Settings search

Related issues

Fixes: #40656

Manual testing steps

Open the MetaMask extension
Navigate to Settings
Type "names" in the search bar
Verify "No matching results found" is displayed (previously "Proposed nicknames" appeared)
Type "phishing" in the search bar to confirm search still works for other settings
Navigate to Security & privacy tab and verify it renders correctly

Screenshots/Recordings

Before

Searching "names" shows "Proposed nicknames" as a search result under Security & privacy — clicking it does nothing:

After

Searching "names" now correctly shows "No matching results found":

02-search-names-no-results-1773171206690

Other search terms (e.g. "phishing") continue to work:

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds a new state migration (v199) and updates fixtures/tests to match, which can affect persisted user state and E2E reliability if the migration or version bump is wrong. UI changes are limited to settings/search and removing a conditional toggle path.

Overview
Removes the "Proposed nicknames" entry from settings search (SETTINGS_CONSTANTS) and deletes the corresponding conditional section/toggle wiring from the legacy Security & Privacy tab so the settings search no longer links to a non-functional anchor.

Cleans up the deprecated petnamesEnabled preference across the app by removing it from PreferencesController types/defaults, fixtures, and tests, and introducing migration 199 to delete preferences.petnamesEnabled from persisted state (with fixture migration versions bumped to 199).

^{Written by Cursor Bugbot for commit aca8484. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-10T19:36:35Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-10T20:11:09Z

Builds ready [0e8cf6d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 286 275 309 14 281 309
total 286 275 309 14 281 309
Confirm Tx confirm_tx 6070 6020 6111 30 6083 6111
total 6070 6020 6111 30 6083 6111
Bridge User Actions bridge_load_page 201 190 213 8 204 213
bridge_load_asset_picker 201 176 226 19 220 226
bridge_search_token 714 706 728 8 713 728
total 1126 1080 1184 42 1167 1184

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1408 1176 1966 121 1479 1593
load 1164 955 1653 105 1235 1318
domContentLoaded 1156 951 1622 104 1225 1305
domInteractive 29 16 112 21 25 81
firstPaint 187 63 1189 160 213 317
backgroundConnect 203 184 379 21 205 229
firstReactRender 19 13 37 5 20 29
initialActions 1 0 4 1 1 3
loadScripts 970 770 1424 100 1037 1119
setupStore 13 7 45 6 16 23
numNetworkReqs 36 27 101 20 27 90
Power User Home uiStartup 5111 2030 11015 2042 6356 8449
load 1296 1124 2194 144 1331 1549
domContentLoaded 1279 1121 2127 136 1317 1506
domInteractive 36 20 157 27 32 109
firstPaint 203 84 1187 133 257 318
backgroundConnect 1769 291 7306 1717 2795 5029
firstReactRender 28 17 70 9 29 42
initialActions 1 0 8 1 1 4
loadScripts 1053 914 1869 127 1080 1273
setupStore 16 6 51 9 17 36
numNetworkReqs 135 61 258 38 149 214

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 219 225 2 222 225
srpButtonToSrpForm 99 97 102 2 100 102
confirmSrpToPwForm 23 22 25 1 23 25
pwFormToMetricsScreen 16 15 17 1 16 17
metricsToWalletReadyScreen 17 16 17 0 17 17
doneButtonToHomeScreen 678 594 767 74 762 767
openAccountMenuToAccountListLoaded 2927 2926 2928 1 2928 2928
total 3985 3899 4078 74 4061 4078
Onboarding New Wallet createWalletToSocialScreen 218 218 219 0 218 219
srpButtonToPwForm 111 108 115 3 112 115
createPwToRecoveryScreen 9 8 11 1 10 11
skipBackupToMetricsScreen 38 38 39 0 39 39
agreeButtonToOnboardingSuccess 17 16 18 1 18 18
doneButtonToAssetList 580 500 754 96 613 754
total 935 892 1003 41 922 1003
Asset Details assetClickToPriceChart 109 102 114 5 113 114
total 109 102 114 5 113 114
Solana Asset Details assetClickToPriceChart 84 74 93 7 92 93
total 84 74 93 7 92 93
Import Srp Home loginToHomeScreen 2253 2184 2317 46 2275 2317
openAccountMenuAfterLogin 56 36 80 16 62 80
homeAfterImportWithNewWallet 2400 2222 2671 164 2499 2671
total 4642 4589 4719 52 4660 4719
Send Transactions openSendPageFromHome 32 29 37 3 32 37
selectTokenToSendFormLoaded 27 17 34 7 33 34
reviewTransactionToConfirmationPage 1226 844 1469 233 1467 1469
total 1289 892 1551 245 1541 1551
Swap openSwapPageFromHome 32 31 32 1 32 32
fetchAndDisplaySwapQuotes 2692 2686 2700 5 2693 2700
total 2722 2715 2731 6 2727 2731

🌐 Dapp Page Load Benchmarks

Current Commit: 0e8cf6d | Date: 3/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±45ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 742ms (±65ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 92ms (±132ms) 🟢 | historical mean value: 84ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	45ms	1.03s	1.39s	1.08s	1.39s
domContentLoaded	742ms	65ms	717ms	1.33s	767ms	1.33s
firstPaint	92ms	132ms	60ms	1.40s	88ms	1.40s
firstContentfulPaint	92ms	132ms	60ms	1.40s	88ms	1.40s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: -241 Bytes (0%)
common: 20 Bytes (0%)

cryptotavares · 2026-03-11T11:36:46Z

📝 Additional Context from Slack Discussion

Slack Thread Reference: https://consensys.slack.com/archives/C070G0RCX0T/p1773228147183789?thread_ts=1773224831.881679&cid=C070G0RCX0T

Root Cause Analysis

This PR addresses a symptom of an incomplete cleanup from PR #31207, which was intended to remove the petnamesEnabled feature. The original PR was incomplete and left behind:

PreferencesController default state - The petnamesEnabled property was never removed from the default state at app/scripts/controllers/preferences-controller.ts#L189
E2E fixtures - The property was not removed from e2e test fixtures
Security tab rendering - Dead code remains at ui/pages/settings/security-tab/security-tab.component.js#L1397-L1405 that was attempting to render this entry (though it wasn't visible because the petnamesEnabled prop was removed)
Recent regression - In PR #39975, the prop was re-added to address React console errors, but was incorrectly mapped - it was assumed to be on the metamask Redux state when it's actually on metamask.preferences state

Current Fix Scope

This PR fixes the user-facing symptom (phantom search result) by removing the externalNameSourcesSetting entry from SETTINGS_CONSTANTS.

Potential Follow-up Work

For a complete cleanup, consider:

Remove petnamesEnabled from PreferencesController default state
Remove petnamesEnabled from e2e fixtures
Remove dead rendering code in security-tab.component.js
Review the prop mapping in PR fix: Add route protection when basic functionality toggle is off #39975

Note on AI-Assisted Development

This PR was created as an experiment with autonomous agent-driven development workflow:

Agent was given the issue
Agent fixed the issue
Agent validated the fix (built Extension + launched with MCP + visual validation)
Agent committed and opened PR

This demonstrates AI agents can effectively fix user-facing issues, while also highlighting that deeper context about historical decisions and incomplete migrations may be needed for comprehensive fixes.

Context captured from Slack discussion by @joao.tavares

The "externalNameSourcesSetting" entry in the settings search index pointed to a setting that was not consistently visible in the Security tab, causing a phantom search result. Clicking it did nothing. Remove the search entry from SETTINGS_CONSTANTS and the associated settingsRef from the security tab component. The actual toggle UI remains intact for users who have petnamesEnabled. Fixes #40656

…d code Remove the petnamesEnabled preference that was re-introduced after migration 150 due to it remaining in the PreferencesController default state. This adds migration 199 to clean up persisted state, removes the property from the controller type/defaults, deletes dead rendering code in the security-tab (renderExternalNameSourcesToggle and its petnamesEnabled gate), and cleans up all fixtures and test data.

ui/pages/settings/security-tab/security-tab.component.js

metamaskbotv2 · 2026-03-13T15:02:36Z

Builds ready [b67f5d3]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 329 257 471 78 349 471
total 329 257 471 78 349 471
Confirm Tx confirm_tx 6013 5997 6024 11 6023 6024
total 6013 5997 6024 11 6023 6024
Bridge User Actions bridge_load_page 246 208 287 28 265 287
bridge_load_asset_picker 172 151 199 20 182 199
bridge_search_token 707 692 728 16 724 728
total 1117 1089 1148 24 1131 1148

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1626 1337 2264 140 1702 1832
load 1340 1092 1852 132 1431 1529
domContentLoaded 1330 1082 1838 130 1423 1523
domInteractive 33 18 133 24 28 96
firstPaint 171 74 604 104 221 405
backgroundConnect 240 213 311 16 243 272
firstReactRender 21 12 50 6 23 32
initialActions 1 0 6 1 2 4
loadScripts 1111 861 1598 129 1208 1305
setupStore 15 7 40 6 18 23
numNetworkReqs 40 31 86 16 42 80
Power User Home uiStartup 5496 2183 11397 1907 6400 9121
load 1290 1089 3359 246 1294 1561
domContentLoaded 1268 1085 3335 242 1270 1516
domInteractive 38 19 272 33 37 85
firstPaint 218 81 1522 159 271 354
backgroundConnect 1819 286 8915 1602 2750 4528
firstReactRender 28 17 66 8 31 43
initialActions 1 0 8 1 1 4
loadScripts 1056 882 3090 235 1057 1290
setupStore 16 5 66 9 16 30
numNetworkReqs 152 85 291 43 158 261

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 216 222 2 220 222
srpButtonToSrpForm 91 89 93 1 91 93
confirmSrpToPwForm 22 21 23 0 22 23
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 16 17 0 17 17
doneButtonToHomeScreen 611 590 649 27 649 649
openAccountMenuToAccountListLoaded 2927 2902 2961 20 2937 2961
total 3895 3883 3912 12 3912 3912
Onboarding New Wallet createWalletToSocialScreen 218 217 220 1 219 220
srpButtonToPwForm 107 107 107 0 107 107
createPwToRecoveryScreen 8 8 9 0 8 9
skipBackupToMetricsScreen 39 38 40 1 39 40
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 535 481 680 84 490 680
total 926 876 1069 83 882 1069
Asset Details assetClickToPriceChart 54 49 63 6 53 63
total 54 49 63 6 53 63
Solana Asset Details assetClickToPriceChart 132 113 146 12 138 146
total 132 113 146 12 138 146
Import Srp Home loginToHomeScreen 2307 2266 2344 27 2312 2344
openAccountMenuAfterLogin 62 51 72 9 71 72
homeAfterImportWithNewWallet 1606 479 2381 907 2377 2381
total 3950 2875 4695 875 4662 4695
Send Transactions openSendPageFromHome 26 24 28 1 26 28
selectTokenToSendFormLoaded 32 29 36 3 34 36
reviewTransactionToConfirmationPage 1207 1112 1314 76 1236 1314
total 1247 1227 1282 25 1282 1282
Swap openSwapPageFromHome 74 24 138 40 95 138
fetchAndDisplaySwapQuotes 2699 2681 2720 13 2704 2720
total 2774 2744 2820 27 2785 2820

🌐 Dapp Page Load Benchmarks

Current Commit: b67f5d3 | Date: 3/13/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.08s (±47ms) 🟡 | historical mean value: 1.06s ⬆️ (historical data)
domContentLoaded-> current mean value: 760ms (±60ms) 🟢 | historical mean value: 745ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 97ms (±127ms) 🟢 | historical mean value: 85ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.08s	47ms	1.03s	1.40s	1.13s	1.40s
domContentLoaded	760ms	60ms	718ms	1.29s	809ms	1.29s
firstPaint	97ms	127ms	72ms	1.36s	96ms	1.36s
firstContentfulPaint	97ms	127ms	72ms	1.36s	96ms	1.36s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 841 Bytes (0.02%)
ui: -3.1 KiB (-0.04%)
common: -212 Bytes (0%)

…abled from e2e tests

metamaskbotv2 · 2026-03-15T09:18:34Z

Builds ready [63acb87]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 281 271 292 8 281 292
total 281 271 292 8 281 292
Confirm Tx confirm_tx 6018 6012 6023 4 6020 6023
total 6018 6012 6023 4 6020 6023
Bridge User Actions bridge_load_page 219 215 221 2 221 221
bridge_load_asset_picker 243 179 294 46 293 294
bridge_search_token 760 706 825 45 796 825
total 1226 1106 1335 87 1285 1335

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1465 1234 1936 113 1481 1709
load 1211 1019 1555 99 1229 1405
domContentLoaded 1205 1013 1545 98 1225 1391
domInteractive 30 17 117 22 25 94
firstPaint 164 66 1558 158 213 282
backgroundConnect 213 196 274 11 216 229
firstReactRender 20 12 58 6 21 28
initialActions 1 0 6 1 2 4
loadScripts 1007 812 1337 96 1031 1194
setupStore 12 6 34 5 15 20
numNetworkReqs 40 31 84 16 40 80
Power User Home uiStartup 5216 2275 10341 1742 6245 7715
load 1341 1120 2097 145 1383 1611
domContentLoaded 1318 1108 1905 129 1362 1579
domInteractive 40 19 210 36 35 124
firstPaint 217 82 1393 187 274 339
backgroundConnect 1466 286 7628 1482 2570 4225
firstReactRender 25 17 49 6 28 38
initialActions 1 0 6 1 1 3
loadScripts 1090 902 1604 119 1127 1356
setupStore 16 7 39 7 18 30
numNetworkReqs 263 123 379 61 311 346

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 219 221 1 221 221
srpButtonToSrpForm 99 95 101 2 100 101
confirmSrpToPwForm 23 23 23 0 23 23
pwFormToMetricsScreen 17 16 17 0 17 17
metricsToWalletReadyScreen 17 16 17 0 17 17
doneButtonToHomeScreen 616 594 669 31 602 669
openAccountMenuToAccountListLoaded 2986 2903 3167 102 3028 3167
total 4019 3880 4132 111 4104 4132
Onboarding New Wallet createWalletToSocialScreen 218 218 219 1 219 219
srpButtonToPwForm 111 108 114 2 113 114
createPwToRecoveryScreen 8 8 9 0 8 9
skipBackupToMetricsScreen 39 37 41 1 40 41
agreeButtonToOnboardingSuccess 16 16 17 0 16 17
doneButtonToAssetList 500 481 524 15 499 524
total 895 873 919 16 898 919
Asset Details assetClickToPriceChart 81 80 82 1 82 82
total 81 80 82 1 82 82
Solana Asset Details assetClickToPriceChart 97 31 173 50 120 173
total 97 31 173 50 120 173
Import Srp Home loginToHomeScreen 2336 2319 2363 19 2363 2363
openAccountMenuAfterLogin 67 63 73 4 69 73
homeAfterImportWithNewWallet 1285 522 2410 875 2300 2410
total 3693 2914 4924 913 4690 4924
Send Transactions openSendPageFromHome 25 20 28 3 28 28
selectTokenToSendFormLoaded 34 29 38 3 34 38
reviewTransactionToConfirmationPage 1014 756 1143 157 1135 1143
total 1161 1044 1216 68 1192 1216
Swap openSwapPageFromHome 67 33 87 22 85 87
fetchAndDisplaySwapQuotes 2700 2673 2743 26 2694 2743
total 2777 2755 2819 25 2776 2819

🌐 Dapp Page Load Benchmarks

Current Commit: 63acb87 | Date: 3/15/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 740ms (±38ms) 🟢 | historical mean value: 746ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 83ms (±15ms) 🟢 | historical mean value: 85ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	40ms	1.02s	1.36s	1.08s	1.36s
domContentLoaded	740ms	38ms	713ms	1.03s	765ms	1.03s
firstPaint	83ms	15ms	68ms	220ms	92ms	220ms
firstContentfulPaint	83ms	15ms	68ms	220ms	92ms	220ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 841 Bytes (0.02%)
ui: -1.91 KiB (-0.02%)
common: -212 Bytes (0%)

…search

metamaskbotv2 · 2026-03-16T23:26:32Z

Builds ready [788bc46]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 287 262 321 22 300 321
total 287 262 321 22 300 321
Confirm Tx confirm_tx 6021 6018 6022 2 6022 6022
total 6021 6018 6022 2 6022 6022
Bridge User Actions bridge_load_page 219 206 234 10 220 234
bridge_load_asset_picker 227 182 289 39 256 289
bridge_search_token 705 690 723 12 714 723
total 1165 1095 1276 68 1204 1276

🔌 Startup Benchmarks
⚠️ Missing data: chrome/browserify/startupStandardHome

Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Power User Home uiStartup 5695 2225 14821 2307 6409 9307
load 1308 1148 1712 122 1351 1593
domContentLoaded 1287 1139 1676 112 1326 1533
domInteractive 35 20 162 24 32 75
firstPaint 237 90 1538 212 273 390
backgroundConnect 1961 296 12507 2249 2612 6329
firstReactRender 24 18 44 5 25 33
initialActions 1 0 7 1 1 3
loadScripts 1065 919 1429 105 1095 1315
setupStore 17 7 134 15 19 31
numNetworkReqs 194 87 424 59 213 313

🧭 User Journey Benchmarks
⚠️ Missing data: chrome/browserify/userJourneyAccountManagement, chrome/browserify/userJourneyTransactions

Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 219 219 0 219 219
srpButtonToSrpForm 96 95 97 1 96 97
confirmSrpToPwForm 23 22 23 0 23 23
pwFormToMetricsScreen 16 16 16 0 16 16
metricsToWalletReadyScreen 16 15 17 1 17 17
doneButtonToHomeScreen 614 600 641 17 613 641
openAccountMenuToAccountListLoaded 2922 2907 2931 9 2930 2931
total 3908 3894 3939 18 3901 3939
Onboarding New Wallet createWalletToSocialScreen 219 217 221 2 220 221
srpButtonToPwForm 108 107 110 1 108 110
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 38 38 38 0 38 38
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 486 473 499 10 497 499
total 877 861 899 13 883 899
Asset Details assetClickToPriceChart 68 47 95 20 89 95
total 68 47 95 20 89 95
Solana Asset Details assetClickToPriceChart 106 64 172 46 150 172
total 106 64 172 46 150 172

🌐 Dapp Page Load Benchmarks

Current Commit: 788bc46 | Date: 3/16/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±43ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 736ms (±40ms) 🟢 | historical mean value: 742ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±12ms) 🟢 | historical mean value: 92ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	43ms	1.02s	1.37s	1.08s	1.37s
domContentLoaded	736ms	40ms	712ms	1.04s	761ms	1.04s
firstPaint	80ms	12ms	60ms	184ms	88ms	184ms
firstContentfulPaint	80ms	12ms	60ms	184ms	88ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 841 Bytes (0.02%)
ui: 20.46 KiB (0.24%)
common: 1.42 KiB (0.01%)

metamaskbotv2 · 2026-03-17T00:25:47Z

Builds ready [cc14bda]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 278 263 301 13 283 301
total 278 263 301 13 283 301
Confirm Tx confirm_tx 6010 5989 6033 18 6021 6033
total 6010 5989 6033 18 6021 6033
Bridge User Actions bridge_load_page 221 187 247 27 247 247
bridge_load_asset_picker 250 178 317 47 277 317
bridge_search_token 759 751 767 7 766 767
total 1255 1220 1275 22 1271 1275

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1554 1285 2109 127 1624 1757
load 1284 1038 1756 118 1346 1485
domContentLoaded 1276 1033 1743 116 1341 1478
domInteractive 32 18 127 24 27 93
firstPaint 181 71 1309 182 211 416
backgroundConnect 224 198 283 16 231 262
firstReactRender 24 12 213 21 22 46
initialActions 2 0 9 2 2 5
loadScripts 1069 826 1522 114 1130 1259
setupStore 15 7 137 13 17 24
numNetworkReqs 40 31 86 16 40 80
Power User Home uiStartup 5376 2026 14913 2452 6265 8512
load 1306 1119 2213 151 1334 1619
domContentLoaded 1285 1108 2194 144 1295 1543
domInteractive 37 20 157 30 33 127
firstPaint 234 92 1563 191 279 359
backgroundConnect 1843 297 11848 2301 2570 5246
firstReactRender 24 16 45 4 26 30
initialActions 1 0 4 1 1 3
loadScripts 1063 888 1888 132 1074 1300
setupStore 15 7 51 8 17 29
numNetworkReqs 210 90 347 58 250 317

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 219 222 1 222 222
srpButtonToSrpForm 93 93 94 0 94 94
confirmSrpToPwForm 22 22 22 0 22 22
pwFormToMetricsScreen 15 15 16 0 15 16
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 623 594 664 30 664 664
openAccountMenuToAccountListLoaded 2909 2890 2925 14 2918 2925
total 3894 3864 3929 23 3892 3929
Onboarding New Wallet createWalletToSocialScreen 219 219 219 0 219 219
srpButtonToPwForm 108 106 111 2 107 111
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 39 38 39 0 39 39
agreeButtonToOnboardingSuccess 16 16 17 0 16 17
doneButtonToAssetList 638 491 746 119 733 746
total 1125 1116 1138 8 1126 1138
Asset Details assetClickToPriceChart 68 46 96 20 83 96
total 68 46 96 20 83 96
Solana Asset Details assetClickToPriceChart 64 38 96 24 79 96
total 64 38 96 24 79 96
Import Srp Home loginToHomeScreen 2283 2265 2303 18 2298 2303
openAccountMenuAfterLogin 63 51 73 8 68 73
homeAfterImportWithNewWallet 2329 2285 2376 43 2369 2376
total 4682 4661 4693 13 4692 4693
Send Transactions openSendPageFromHome 48 20 99 32 73 99
selectTokenToSendFormLoaded 48 28 94 26 62 94
reviewTransactionToConfirmationPage 1027 942 1126 73 1097 1126
total 1123 1009 1260 84 1152 1260
Swap openSwapPageFromHome 93 50 161 40 107 161
fetchAndDisplaySwapQuotes 2687 2682 2694 4 2689 2694
total 2780 2739 2843 37 2793 2843

🌐 Dapp Page Load Benchmarks

Current Commit: cc14bda | Date: 3/17/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±39ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 747ms (±36ms) 🟢 | historical mean value: 742ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 83ms (±10ms) 🟢 | historical mean value: 92ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	39ms	1.04s	1.36s	1.08s	1.36s
domContentLoaded	747ms	36ms	730ms	1.02s	761ms	1.02s
firstPaint	83ms	10ms	68ms	172ms	92ms	172ms
firstContentfulPaint	83ms	10ms	68ms	172ms	92ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 841 Bytes (0.02%)
ui: 20.46 KiB (0.24%)
common: 1.42 KiB (0.01%)

…search

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

cursor · 2026-03-17T11:00:24Z

ui/components/app/confirm/info/row/address.test.tsx

        ...mockState.metamask,
        preferences: {
          ...mockState.metamask.preferences,
-          petnamesEnabled: true,


Misleading test name after removing feature flag

Low Severity

The test is named 'renders appropriately with PetNames enabled' but the petnamesEnabled property it used to set has been removed. The test body now just spreads mockState.metamask.preferences into an identical copy with no actual override, making the entire metamask state override a no-op. The test name no longer reflects what it actually verifies, and the redundant state spread adds confusion for future readers.

That test is still fine.. petnames are now always enabled. We are just removing the property to specify it or not. They are always on. It is part of the wallet

metamaskbotv2 · 2026-03-17T11:33:01Z

Builds ready [1a734e8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 274 273 276 1 276 276
total 274 273 276 1 276 276
Confirm Tx confirm_tx 5998 5996 6000 2 6000 6000
total 5998 5996 6000 2 6000 6000
Bridge User Actions bridge_load_page 229 210 256 17 234 256
bridge_load_asset_picker 213 148 260 39 242 260
bridge_search_token 729 702 756 23 747 756
total 1190 1084 1298 77 1229 1298

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1464 1233 1770 111 1501 1667
load 1207 1004 1426 96 1247 1376
domContentLoaded 1200 1002 1418 95 1242 1367
domInteractive 28 18 101 18 26 77
firstPaint 153 69 411 72 215 249
backgroundConnect 213 193 264 12 217 236
firstReactRender 21 13 212 20 21 29
initialActions 1 0 6 1 2 3
loadScripts 1003 805 1214 95 1045 1175
setupStore 13 7 66 7 15 23
numNetworkReqs 39 31 89 16 39 79
Power User Home uiStartup 5643 2216 17871 3364 6485 13342
load 1311 1130 1750 125 1362 1573
domContentLoaded 1289 1125 1715 119 1326 1538
domInteractive 40 20 230 34 34 119
firstPaint 223 86 1227 135 284 338
backgroundConnect 2338 311 14484 2897 2586 8810
firstReactRender 30 17 310 35 27 41
initialActions 1 0 5 1 1 4
loadScripts 1064 924 1463 109 1103 1279
setupStore 17 7 93 12 19 32
numNetworkReqs 134 71 323 49 137 260

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 220 221 1 221 221
srpButtonToSrpForm 93 92 94 1 94 94
confirmSrpToPwForm 22 21 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 593 590 598 3 598 598
openAccountMenuToAccountListLoaded 2929 2925 2931 3 2931 2931
total 3917 3890 3943 22 3939 3943
Onboarding New Wallet createWalletToSocialScreen 219 216 224 3 220 224
srpButtonToPwForm 109 107 112 2 110 112
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 39 38 40 1 39 40
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 523 504 534 12 531 534
total 913 893 921 12 919 921
Asset Details assetClickToPriceChart 64 46 85 17 76 85
total 64 46 85 17 76 85
Solana Asset Details assetClickToPriceChart 58 33 106 28 75 106
total 58 33 106 28 75 106
Import Srp Home loginToHomeScreen 2334 2229 2488 95 2379 2488
openAccountMenuAfterLogin 97 73 123 22 120 123
homeAfterImportWithNewWallet 2362 2316 2408 33 2367 2408
total 4782 4668 4920 110 4859 4920
Send Transactions openSendPageFromHome 48 23 90 25 61 90
selectTokenToSendFormLoaded 39 24 56 12 51 56
reviewTransactionToConfirmationPage 1033 693 1221 200 1210 1221
total 1120 749 1356 221 1314 1356
Swap openSwapPageFromHome 149 120 183 24 160 183
fetchAndDisplaySwapQuotes 2700 2690 2714 9 2705 2714
total 2830 2746 2881 49 2875 2881

🌐 Dapp Page Load Benchmarks

Current Commit: 1a734e8 | Date: 3/17/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 738ms (±64ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 84ms (±44ms) 🟢 | historical mean value: 89ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	42ms	1.02s	1.38s	1.08s	1.38s
domContentLoaded	738ms	64ms	710ms	1.33s	771ms	1.33s
firstPaint	84ms	44ms	68ms	516ms	88ms	516ms
firstContentfulPaint	84ms	44ms	68ms	516ms	88ms	516ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 841 Bytes (0.02%)
ui: -1.62 KiB (-0.02%)
common: 0 Bytes (0%)

…search

sonarqubecloud · 2026-03-18T10:54:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-18T11:16:36Z

Builds ready [aca8484]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 281 267 306 16 282 306
total 281 267 306 16 282 306
Confirm Tx confirm_tx 5998 5987 6016 11 5995 6016
total 5998 5987 6016 11 5995 6016
Bridge User Actions bridge_load_page 238 203 280 26 252 280
bridge_load_asset_picker 251 249 252 1 252 252
bridge_search_token 773 769 779 4 779 779
total 1274 1197 1392 69 1307 1392

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1474 1231 1802 118 1541 1680
load 1225 1009 1505 109 1294 1420
domContentLoaded 1219 1005 1497 107 1290 1408
domInteractive 30 16 111 21 26 83
firstPaint 162 69 412 74 219 283
backgroundConnect 217 198 276 14 223 238
firstReactRender 19 13 50 7 20 30
initialActions 1 0 5 1 2 4
loadScripts 1018 805 1287 104 1077 1199
setupStore 14 7 36 5 17 25
numNetworkReqs 39 31 89 16 37 80
Power User Home uiStartup 6075 2368 17654 3485 6456 15950
load 1289 1138 1730 129 1323 1581
domContentLoaded 1270 1129 1720 123 1289 1566
domInteractive 39 18 191 37 31 148
firstPaint 221 87 1226 171 276 410
backgroundConnect 2844 302 15099 3432 3414 11742
firstReactRender 23 18 42 5 26 32
initialActions 1 0 4 1 1 3
loadScripts 1048 918 1477 113 1065 1321
setupStore 15 7 34 5 17 25
numNetworkReqs 185 78 329 55 214 293

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 217 217 218 1 218 218
srpButtonToSrpForm 95 94 96 1 96 96
confirmSrpToPwForm 22 21 23 1 22 23
pwFormToMetricsScreen 16 15 17 1 16 17
metricsToWalletReadyScreen 16 16 18 1 17 18
doneButtonToHomeScreen 618 600 656 22 610 656
openAccountMenuToAccountListLoaded 2932 2931 2933 1 2933 2933
total 3919 3895 3957 23 3914 3957
Onboarding New Wallet createWalletToSocialScreen 219 218 219 0 219 219
srpButtonToPwForm 108 107 109 1 108 109
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 39 37 42 2 40 42
agreeButtonToOnboardingSuccess 16 16 17 0 16 17
doneButtonToAssetList 501 481 519 17 516 519
total 893 869 917 20 908 917
Asset Details assetClickToPriceChart 69 46 90 15 78 90
total 69 46 90 15 78 90
Solana Asset Details assetClickToPriceChart 119 109 126 7 126 126
total 119 109 126 7 126 126
Import Srp Home loginToHomeScreen 2225 2175 2339 66 2194 2339
openAccountMenuAfterLogin 79 38 125 35 118 125
homeAfterImportWithNewWallet 2326 2254 2401 60 2401 2401
total 4645 4574 4710 56 4710 4710
Send Transactions openSendPageFromHome 62 25 95 27 85 95
selectTokenToSendFormLoaded 53 22 82 21 67 82
reviewTransactionToConfirmationPage 1182 1135 1206 33 1206 1206
total 1291 1241 1332 38 1332 1332
Swap openSwapPageFromHome 101 37 144 44 144 144
fetchAndDisplaySwapQuotes 2689 2688 2690 1 2690 2690
total 2780 2727 2832 36 2805 2832

🌐 Dapp Page Load Benchmarks

Current Commit: aca8484 | Date: 3/18/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±42ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 741ms (±39ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±14ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	42ms	1.02s	1.36s	1.08s	1.36s
domContentLoaded	741ms	39ms	715ms	1.03s	768ms	1.03s
firstPaint	81ms	14ms	64ms	208ms	88ms	208ms
firstContentfulPaint	81ms	14ms	64ms	208ms	88ms	208ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 841 Bytes (0.02%)
ui: -1.62 KiB (-0.02%)
common: -91 Bytes (0%)

seaona

e2e files LGTM

tuna1207

LGTM

cryptotavares temporarily deployed to pr-comment March 10, 2026 19:36 — with GitHub Actions Inactive

metamaskbot added the team-product-safety Push issues to Product Safety team label Mar 10, 2026

github-actions bot added the size-S label Mar 10, 2026

cryptotavares temporarily deployed to pr-comment March 10, 2026 20:06 — with GitHub Actions Inactive

cryptotavares marked this pull request as ready for review March 11, 2026 10:23

cryptotavares temporarily deployed to pr-comment March 11, 2026 10:23 — with GitHub Actions Inactive

cryptotavares added 2 commits March 12, 2026 18:28

cryptotavares force-pushed the fix/remove-proposed-nicknames-from-settings-search branch from 0e8cf6d to b67f5d3 Compare March 13, 2026 14:25

cryptotavares requested review from a team as code owners March 13, 2026 14:25

cryptotavares temporarily deployed to pr-comment March 13, 2026 14:25 — with GitHub Actions Inactive

github-actions bot added size-M and removed size-S labels Mar 13, 2026

cursor bot reviewed Mar 13, 2026

View reviewed changes

ui/pages/settings/security-tab/security-tab.component.js Show resolved Hide resolved

cryptotavares temporarily deployed to pr-comment March 13, 2026 14:57 — with GitHub Actions Inactive

chore(settings): remove leftover withPreferencesControllerPetnamesDis…

63acb87

…abled from e2e tests

cryptotavares temporarily deployed to pr-comment March 15, 2026 08:41 — with GitHub Actions Inactive

cryptotavares temporarily deployed to pr-comment March 15, 2026 09:14 — with GitHub Actions Inactive

Merge branch 'main' into fix/remove-proposed-nicknames-from-settings-…

99097d7

…search

cryptotavares temporarily deployed to pr-comment March 16, 2026 15:58 — with GitHub Actions Inactive

cryptotavares temporarily deployed to pr-comment March 16, 2026 16:29 — with GitHub Actions Inactive

cryptotavares temporarily deployed to pr-comment March 16, 2026 23:22 — with GitHub Actions Inactive

chore(settings): bump e2e fixture migration version from 198 to 199

cc14bda

cryptotavares force-pushed the fix/remove-proposed-nicknames-from-settings-search branch from 788bc46 to cc14bda Compare March 16, 2026 23:49

cryptotavares temporarily deployed to pr-comment March 16, 2026 23:50 — with GitHub Actions Inactive

cryptotavares temporarily deployed to pr-comment March 17, 2026 00:20 — with GitHub Actions Inactive

Merge branch 'main' into fix/remove-proposed-nicknames-from-settings-…

1a734e8

…search

cryptotavares temporarily deployed to pr-comment March 17, 2026 10:56 — with GitHub Actions Inactive

cursor bot reviewed Mar 17, 2026

View reviewed changes

cryptotavares temporarily deployed to pr-comment March 17, 2026 11:28 — with GitHub Actions Inactive

cryptotavares added team-confirmations Push issues to confirmations team and removed team-product-safety Push issues to Product Safety team labels Mar 17, 2026

cryptotavares added 2 commits March 17, 2026 12:39

fix: remove unused message key

a78e0c3

Merge branch 'main' into fix/remove-proposed-nicknames-from-settings-…

aca8484

…search

cryptotavares temporarily deployed to pr-comment March 18, 2026 10:37 — with GitHub Actions Inactive

jpuri approved these changes Mar 18, 2026

View reviewed changes

cryptotavares temporarily deployed to pr-comment March 18, 2026 11:12 — with GitHub Actions Inactive

davidmurdoch approved these changes Mar 18, 2026

View reviewed changes

seaona approved these changes Mar 18, 2026

View reviewed changes

tuna1207 approved these changes Mar 18, 2026

View reviewed changes

cryptotavares added this pull request to the merge queue Mar 18, 2026

Merged via the queue into main with commit 34be7cc Mar 18, 2026
391 of 393 checks passed

cryptotavares deleted the fix/remove-proposed-nicknames-from-settings-search branch March 18, 2026 18:33

github-actions bot locked and limited conversation to collaborators Mar 18, 2026

metamaskbot added the release-13.24.0 Issue or pull request that will be included in release 13.24.0 label Mar 18, 2026

Conversation

cryptotavares commented Mar 10, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

cryptotavares commented Mar 11, 2026

📝 Additional Context from Slack Discussion

Root Cause Analysis

Current Fix Scope

Potential Follow-up Work

Note on AI-Assisted Development

Uh oh!

Uh oh!

metamaskbotv2 bot commented Mar 13, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 15, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 16, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 17, 2026

Choose a reason for hiding this comment

Misleading test name after removing feature flag

Uh oh!

cryptotavares Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 18, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 18, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

seaona left a comment

Choose a reason for hiding this comment

Uh oh!

tuna1207 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cryptotavares commented Mar 10, 2026 •

edited by cursor bot

Loading