feat: Remove petnames settings toggle#31207
Merged
pedronfigueiredo merged 1 commit intomainfrom Mar 25, 2025
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
6671e04 to
a52aa89
Compare
bbe8c21 to
f80897f
Compare
f80897f to
5561f63
Compare
Collaborator
Builds ready [5561f63]
Page Load Metrics (3115 ± 1862 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jpuri
approved these changes
Mar 25, 2025
darkwing
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the settings toggle for editable petnames. Removes the associated selector, action and UI hook, and adds a migration to remove the state property.
While the privacy settings selection during the onboarding flow previously used this experimental setting, this PR changes it to use the security and privacy setting toggle related to third party requests instead.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2992
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist