Skip to content

feat: Remove petnames settings toggle#31207

Merged
pedronfigueiredo merged 1 commit intomainfrom
pnf/2992
Mar 25, 2025
Merged

feat: Remove petnames settings toggle#31207
pedronfigueiredo merged 1 commit intomainfrom
pnf/2992

Conversation

@pedronfigueiredo
Copy link
Copy Markdown
Contributor

@pedronfigueiredo pedronfigueiredo commented Mar 21, 2025

Description

Removes the settings toggle for editable petnames. Removes the associated selector, action and UI hook, and adds a migration to remove the state property.

While the privacy settings selection during the onboarding flow previously used this experimental setting, this PR changes it to use the security and privacy setting toggle related to third party requests instead.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2992

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2025-03-21 at 16 26 39 Screenshot 2025-03-21 at 12 28 00

After

Screenshot 2025-03-21 at 16 24 57 Screenshot 2025-03-21 at 12 49 02

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Mar 21, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Mar 21, 2025
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner March 21, 2025 16:34
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner March 24, 2025 11:14
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/2992 branch 3 times, most recently from bbe8c21 to f80897f Compare March 24, 2025 19:36
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [5561f63]
Page Load Metrics (3115 ± 1862 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint154019774299238951870
domContentLoaded146619655279638981872
load153219769311538781862
domInteractive265037710651
backgroundConnect28951313233112
firstReactRender21231865627
getState851216612862
initialActions01000
loadScripts108819126222338901868
setupStore1029611710048
uiStartup171919960502540331936
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 687 Bytes (0.01%)
  • ui: -3.18 KiB (-0.04%)
  • common: -296 Bytes (-0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 0368d5a Mar 25, 2025
107 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/2992 branch March 25, 2025 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
@metamaskbot metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.16.0 Issue or pull request that will be included in release 12.16.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants