fix: fixes ledger decline button not clearing by ghgoodreau · Pull Request #40501 · MetaMask/metamask-extension

ghgoodreau · 2026-02-27T17:48:01Z

Description

Fixes a bug where the ledger transaction decline label was not clearing when refetching quotes, blocking new quotes from being executed.

Changelog

CHANGELOG entry: fixed a bug when cancelling a hardware wallet tx that would cause swaps button to not display

Related issues

Fixes: #40277

Manual testing steps

Go to execute a swap with a ledger HW
cancel the tx
refetch a quote
you should be able to swap

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small UI-state fix in the bridge CTA flow; low risk and covered by a new test, though it affects gating of quote refresh/swap eligibility.

Overview
Fixes a bridge refresh edge case where a previously declined hardware-wallet transaction could leave the UI stuck in the declined state.

BridgeCTAButton now clears the bridge.wasTxDeclined flag when the user clicks the secondary "fetch new quotes" link, then triggers onFetchNewQuotes. Adds a regression test asserting the state reset and callback invocation.

^{Written by Cursor Bugbot for commit 7d854d9. This will update automatically on new commits. Configure here.}

github-actions · 2026-02-27T17:48:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-02-27T17:48:54Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (2 files, +29 -2)

📁 ui/
- 📁 pages/
  - 📁 bridge/
    - 📁 prepare/
      - 📄 bridge-cta-button.test.tsx +20 -0
      - 📄 bridge-cta-button.tsx +9 -2

sonarqubecloud · 2026-02-27T18:00:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-02-27T18:19:08Z

Builds ready [7d854d9]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 278 263 300 13 282 300
total 278 263 300 13 282 300
Confirm Tx confirm_tx 6075 6026 6156 47 6098 6156
total 6075 6026 6156 47 6098 6156
Bridge User Actions bridge_load_page 232 185 278 37 264 278
bridge_load_asset_picker 242 176 298 46 284 298
bridge_search_token 732 720 747 9 736 747
total 1223 1206 1246 17 1230 1246

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1432 1189 1843 121 1490 1633
load 1211 992 1594 109 1257 1398
domContentLoaded 1204 989 1584 108 1252 1385
domInteractive 28 17 127 18 24 74
firstPaint 172 68 1185 129 219 334
backgroundConnect 210 193 249 12 214 234
firstReactRender 19 12 50 5 20 26
initialActions 1 0 6 1 2 4
loadScripts 1010 797 1387 107 1058 1185
setupStore 13 6 47 6 15 27
numNetworkReqs 31 22 91 20 22 86
Power User Home uiStartup 2032 1438 9783 999 1909 2816
load 1210 1071 1880 159 1244 1575
domContentLoaded 1193 1065 1773 146 1238 1543
domInteractive 36 20 191 25 37 64
firstPaint 194 76 1788 181 247 330
backgroundConnect 452 276 7713 822 338 501
firstReactRender 24 15 69 9 25 42
initialActions 1 0 12 1 1 3
loadScripts 968 833 1549 143 982 1326
setupStore 15 7 90 9 16 25
numNetworkReqs 63 37 147 23 71 104

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 219 226 3 223 226
srpButtonToSrpForm 97 95 99 2 99 99
confirmSrpToPwForm 22 22 23 0 22 23
pwFormToMetricsScreen 16 16 16 0 16 16
metricsToWalletReadyScreen 17 17 17 0 17 17
doneButtonToHomeScreen 954 594 1280 275 1272 1280
openAccountMenuToAccountListLoaded 7560 7019 7833 304 7829 7833
total 8889 8670 9091 149 9003 9091
Onboarding New Wallet createWalletToSocialScreen 219 218 219 0 219 219
srpButtonToPwForm 108 107 108 1 108 108
createPwToRecoveryScreen 8 8 9 0 8 9
skipBackupToMetricsScreen 36 34 39 2 37 39
agreeButtonToOnboardingSuccess 16 15 17 1 17 17
doneButtonToAssetList 651 491 916 174 799 916
total 1046 880 1298 165 1186 1298
Asset Details assetClickToPriceChart 72 69 73 2 73 73
total 72 69 73 2 73 73
Solana Asset Details assetClickToPriceChart 53 48 64 6 53 64
total 53 48 64 6 53 64
Import Srp Home loginToHomeScreen 1981 1894 2061 64 2018 2061
openAccountMenuAfterLogin 45 37 50 5 48 50
homeAfterImportWithNewWallet 2526 2175 2838 262 2740 2838
total 4624 4193 5230 387 4850 5230
Send Transactions openSendPageFromHome 20 17 25 3 21 25
selectTokenToSendFormLoaded 23 19 28 4 25 28
reviewTransactionToConfirmationPage 859 849 867 8 865 867
total 898 885 913 11 902 913
Swap openSwapPageFromHome 124 121 129 3 126 129
fetchAndDisplaySwapQuotes 5290 4574 6267 780 6219 6267
total 5420 4703 6387 772 6340 6387

🌐 Dapp Page Load Benchmarks

Current Commit: 7d854d9 | Date: 2/27/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±85ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 739ms (±106ms) 🟢 | historical mean value: 731ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 96ms (±174ms) 🟢 | historical mean value: 82ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	85ms	1.02s	1.85s	1.07s	1.85s
domContentLoaded	739ms	106ms	710ms	1.76s	759ms	1.76s
firstPaint	96ms	174ms	60ms	1.83s	92ms	1.83s
firstContentfulPaint	96ms	174ms	60ms	1.83s	92ms	1.83s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 142 Bytes (0%)
common: 20 Bytes (0%)

fix: fixes ledger decline button not clearing

7d854d9

ghgoodreau temporarily deployed to pr-comment February 27, 2026 17:48 — with GitHub Actions Inactive

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Feb 27, 2026

github-actions bot added the size-S label Feb 27, 2026

ghgoodreau temporarily deployed to pr-comment February 27, 2026 18:14 — with GitHub Actions Inactive

ghgoodreau marked this pull request as ready for review March 3, 2026 19:24

ghgoodreau requested a review from a team as a code owner March 3, 2026 19:24

ghgoodreau temporarily deployed to pr-comment March 3, 2026 19:24 — with GitHub Actions Inactive

micaelae approved these changes Mar 3, 2026

View reviewed changes

SteP-n-s approved these changes Mar 3, 2026

View reviewed changes

ghgoodreau added this pull request to the merge queue Mar 3, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2026

ghgoodreau added this pull request to the merge queue Mar 4, 2026

Merged via the queue into main with commit d42a431 Mar 4, 2026
196 of 199 checks passed

ghgoodreau deleted the SWAPS-4174-ledger-decline-buttonfix branch March 4, 2026 03:04

github-actions bot locked and limited conversation to collaborators Mar 4, 2026

metamaskbot added the release-13.22.0 Issue or pull request that will be included in release 13.22.0 label Mar 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fixes ledger decline button not clearing#40501

fix: fixes ledger decline button not clearing#40501
ghgoodreau merged 1 commit intomainfrom
SWAPS-4174-ledger-decline-buttonfix

ghgoodreau commented Feb 27, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

Uh oh!

sonarqubecloud bot commented Feb 27, 2026

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ghgoodreau commented Feb 27, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

sonarqubecloud bot commented Feb 27, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ghgoodreau commented Feb 27, 2026 •

edited by cursor bot

Loading