fix: clean up spammy Migration 164 Sentry logging#40405
Merged
Prithpal-Sooriya merged 3 commits intomainfrom Feb 27, 2026
Merged
fix: clean up spammy Migration 164 Sentry logging#40405Prithpal-Sooriya merged 3 commits intomainfrom
Prithpal-Sooriya merged 3 commits intomainfrom
Conversation
… in migration 164 This change addresses Sentry issue METAMASK-XNBE where 'PermissionController not found' errors were being logged unnecessarily. Missing controllers are expected edge cases (fresh installs, old state) and should not create Sentry noise. Following the pattern used in other migrations (166, 180, 182, 183), we now use console.warn for 'not found' cases while keeping Sentry logging for actual data corruption issues (type mismatches). Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Builds ready [5702af9]
⚡ Performance Benchmarks (1360 ± 103 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Author
|
@cursor READ AND FOLLOW THESE MEMORY FILES: Please fix the related unit tests 🙏🏾 |
|
I've fixed the unit tests and pushed the changes. Changes made to
This follows the pattern established in migration 166's tests and ensures:
|
Updated tests to: - Add global.sentry mock setup/teardown - Mock console.warn with jest.spyOn to avoid console baseline violations - Verify expected warning messages are logged This follows the pattern established in other migration tests (e.g., 166). Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
Contributor
Builds ready [8f96557]
⚡ Performance Benchmarks (1375 ± 108 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
|
bergarces
approved these changes
Feb 26, 2026
Contributor
Builds ready [dbc7605]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
juanmigdr
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace Sentry logging with
console.warnfor "controller not found" cases in migration 164.Missing controllers are expected edge cases (e.g., fresh installs, old states) and should not generate Sentry errors, aligning with the pattern established in other migrations (e.g., 166, 180) where
console.warnis used for such scenarios.Changelog
CHANGELOG entry: fix: clean up spammy Migration 164 Sentry logging
Related issues
Fixes: #34588 https://consensyssoftware.atlassian.net/browse/ASSETS-2024
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: changes only error-reporting behavior in migration
164for expected “controller missing” states, with updated unit tests to assert the new warnings.Overview
Migration
164no longer reports to Sentry whenPermissionControllerorNetworkControlleris absent; it now emits aconsole.warnand returns the state unchanged.The
164migration tests were updated to set up/tear downglobal.sentryand to assert the expectedconsole.warnmessages for these missing-controller cases (including the version-bump test).Written by Cursor Bugbot for commit dbc7605. This will update automatically on new commits. Configure here.