Skip to content

chore: remove excess fil locale#40333

Merged
HowardBraham merged 1 commit intomainfrom
n3ps/excess-locale-fil
Feb 23, 2026
Merged

chore: remove excess fil locale#40333
HowardBraham merged 1 commit intomainfrom
n3ps/excess-locale-fil

Conversation

@n3ps
Copy link
Copy Markdown
Contributor

@n3ps n3ps commented Feb 23, 2026

Description

Remove excess and incomplete fil locale messages file. This is already served by the tl locale.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: chore: remove fil locale

Related issues

Fixes:

Manual testing steps

  1. Settings > General
  2. Should only show 1 option for Filipino

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Locale list cleanup only; removes a duplicate translation file and its references with minimal impact outside language selection/translation loading.

Overview
Removes the redundant Filipino locale variant fil (messages file and references), leaving tl as the single Filipino language option.

Updates Storybook locale exports and the app locale index to stop importing/listing fil, and deletes app/_locales/fil/messages.json.

Written by Cursor Bugbot for commit d29ec4b. This will update automatically on new commits. Configure here.

@n3ps n3ps added the team-core-extension-ux Core Extension UX team label Feb 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@n3ps n3ps enabled auto-merge February 23, 2026 16:12
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 23, 2026

Builds ready [d29ec4b]
⚡ Performance Benchmarks (1347 ± 115 ms)
👆 Interaction Benchmarks
ActionMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account28817299310
total28817299310
Confirm Txconfirm_tx6062760656074
total6062760656074
Bridge User Actionsbridge_load_page29223307319
bridge_load_asset_picker24015249256
bridge_search_token77753831838
total12959913521413
🔌 Startup Benchmarks
BuildMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
Chrome Browserify Startup Standard HomeuiStartup13471147192811513871544
load1144963159410311731325
domContentLoaded1137961155410011681316
domInteractive261592172375
firstPaint154641278139202337
backgroundConnect19718324912197227
firstReactRender18123542124
initialActions105113
loadScripts95577913551009851141
setupStore1264961420
numNetworkReqs312296192282
Chrome Browserify Startup Power User HomeuiStartup18561383574165518012347
load11341009162212811421476
domContentLoaded1118994156112311291473
domInteractive3218134203263
firstPaint1637339175219299
backgroundConnect3452452831318294444
firstReactRender23164962637
initialActions103111
loadScripts91479113701229111260
setupStore1665781732
numNetworkReqs60381462370110
Chrome Webpack Startup Standard HomeuiStartup8707171169939131031
load74662094589805897
domContentLoaded74161593989801891
domInteractive2915103202587
firstPaint1106439959125200
backgroundConnect26194463039
firstReactRender18123762131
initialActions105112
loadScripts73861393188799885
setupStore1264251320
numNetworkReqs312298212589
Chrome Webpack Startup Power User HomeuiStartup1189841180615912521566
load7066261169100700964
domContentLoaded6976211165100691955
domInteractive34181422732106
firstPaint1286045678135295
backgroundConnect17112733351173299
firstReactRender21163332326
initialActions104111
loadScripts695620115698689941
setupStore1344361425
numNetworkReqs903926048108177
Firefox Browserify Startup Standard HomeuiStartup16771412271925316782205
load14201197238422514261859
domContentLoaded14181196238322614261859
domInteractive883393810297212
firstPaint------
backgroundConnect62282323264116
firstReactRender14112421418
initialActions102012
loadScripts13911173234721814011758
setupStore17786141645
numNetworkReqs312096182579
Firefox Browserify Startup Power User HomeuiStartup28932182460438930363585
load16901382255820417942057
domContentLoaded16891382255720417942057
domInteractive14738721117142425
firstPaint------
backgroundConnect3151231146249320913
firstReactRender211579102125
initialActions213122
loadScripts16401354249219317321993
setupStore16111764194215605
numNetworkReqs69282063788143
Firefox Webpack Startup Standard HomeuiStartup16531397211015317231963
load13951164175412014541622
domContentLoaded13941163175412014531622
domInteractive872825854128188
firstPaint------
backgroundConnect61262253961164
firstReactRender15122631524
initialActions102012
loadScripts13681151173311214271589
setupStore207143231551
numNetworkReqs301995172774
Firefox Webpack Startup Power User HomeuiStartup296321759616102629743872
load18081332744788918122720
domContentLoaded18081331744788918122720
domInteractive184331254200164580
firstPaint------
backgroundConnect3131181421279296950
firstReactRender22176272431
initialActions2032322
loadScripts17741315738588517772693
setupStore1669818212247656
numNetworkReqs67282234279150
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2181219219
srpButtonToSrpForm9019092
confirmSrpToPwForm2212324
pwFormToMetricsScreen1501515
metricsToWalletReadyScreen1511517
doneButtonToHomeScreen104029113211401
openAccountMenuToAccountListLoaded706165676347853
total846452088889105
Onboarding New WalletcreateWalletToSocialScreen2182219220
srpButtonToPwForm11210116129
createPwToRecoveryScreen91910
skipBackupToMetricsScreen3723939
agreeButtonToOnboardingSuccess1611616
doneButtonToAssetList61012626626
total10123010201059
Asset DetailsassetClickToPriceChart4064349
total4064349
Solana Asset DetailsassetClickToPriceChart4514547
total4514547
Import Srp HomeloginToHomeScreen200413120452242
openAccountMenuAfterLogin4134245
homeAfterImportWithNewWallet252310125592687
total457012646724765
Send TransactionsopenSendPageFromHome3093839
selectTokenToSendFormLoaded1911920
reviewTransactionToConfirmationPage8496853859
total89910902916
SwapopenSwapPageFromHome12313130145
fetchAndDisplaySwapQuotes469317446154993
total481117147455104
🌐 Dapp Page Load Benchmarks

Current Commit: d29ec4b | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±55ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±52ms) 🟢 | historical mean value: 734ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 55ms 1.01s 1.32s 1.07s 1.32s
domContentLoaded 723ms 52ms 700ms 992ms 762ms 992ms
firstPaint 77ms 10ms 64ms 152ms 88ms 152ms
firstContentfulPaint 77ms 10ms 64ms 152ms 88ms 152ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 52.02 KiB (1.2%)
  • ui: -459 Bytes (-0.01%)
  • common: 11.18 KiB (0.1%)

@n3ps n3ps added this pull request to the merge queue Feb 23, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2026
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Remove excess and incomplete `fil` locale messages file. This is already
served by the `tl` locale.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/40333?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: chore: remove fil locale

## **Related issues**

Fixes:

## **Manual testing steps**

1. Settings > General
2. Should only show 1 option for Filipino


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Locale list cleanup only; removes a duplicate translation file and its
references with minimal impact outside language selection/translation
loading.
> 
> **Overview**
> Removes the redundant Filipino locale variant `fil` (messages file and
references), leaving `tl` as the single Filipino language option.
> 
> Updates Storybook locale exports and the app locale index to stop
importing/listing `fil`, and deletes `app/_locales/fil/messages.json`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
d29ec4b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 23, 2026
@n3ps n3ps added this pull request to the merge queue Feb 23, 2026
@HowardBraham HowardBraham removed this pull request from the merge queue due to a manual request Feb 23, 2026
@HowardBraham HowardBraham added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit 7317eee Feb 23, 2026
193 of 194 checks passed
@HowardBraham HowardBraham deleted the n3ps/excess-locale-fil branch February 23, 2026 23:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2026
@metamaskbot metamaskbot added the release-13.21.0 Issue or pull request that will be included in release 13.21.0 label Feb 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.21.0 Issue or pull request that will be included in release 13.21.0 size-L team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants