Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Builds ready [2b1db2a]
UI Startup Metrics (1450 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [173216c]
UI Startup Metrics (1471 ± 117 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
jbblanc
approved these changes
Feb 19, 2026
Prithpal-Sooriya
approved these changes
Feb 19, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 19, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Today, MetaMask supports a working buy deeplink that correctly routes users across platforms. However, the equivalent sell deeplink is missing on Extension, even though it exists on Mobile. This PR Implements parity so that /sell deeplink works on Extension the same way /buy does [](https://codespaces.new/MetaMask/metamask-extension/pull/40231?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Added a new sell deeplink ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/GE-123 ## **Manual testing steps** 1. Open https://link.metamask.io/sell?chainId=59144&address=0x176211869cA2b568f2A7D4EE941E073a821EE1ff&amount=25 2. You should be redirected to the sell page, with USDC on Linea selected. Amount is currently not correctly consumed by MMPortfolio => fix needed there ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Adds a small, isolated route mapping that only constructs a redirect URL and updates i18n strings, with minimal impact on core wallet or security logic. > > **Overview** > Adds a new `/sell` deep link route, mirroring existing `/buy` behavior, that redirects to the MetaMask Portfolio sell page and forwards all query parameters. > > Registers the new route in the deep-link route index and adds the `deepLink_theSellPage` i18n string in `en` and `en_GB`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 173216c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Today, MetaMask supports a working buy deeplink that correctly routes users across platforms. However, the equivalent sell deeplink is missing on Extension, even though it exists on Mobile.
This PR Implements parity so that /sell deeplink works on Extension the same way /buy does
Changelog
CHANGELOG entry: Added a new sell deeplink
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/GE-123
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Adds a small, isolated route mapping that only constructs a redirect URL and updates i18n strings, with minimal impact on core wallet or security logic.
Overview
Adds a new
/selldeep link route, mirroring existing/buybehavior, that redirects to the MetaMask Portfolio sell page and forwards all query parameters.Registers the new route in the deep-link route index and adds the
deepLink_theSellPagei18n string inenanden_GB.Written by Cursor Bugbot for commit 173216c. This will update automatically on new commits. Configure here.