Skip to content

chore: ignore minimatch ReDoS advisory (GHSA-3ppc-4f35-3m26)#40221

Merged
cryptodev-2s merged 1 commit intomainfrom
chore/ignore-minimatch-advisory-1113296
Feb 19, 2026
Merged

chore: ignore minimatch ReDoS advisory (GHSA-3ppc-4f35-3m26)#40221
cryptodev-2s merged 1 commit intomainfrom
chore/ignore-minimatch-advisory-1113296

Conversation

@cryptodev-2s
Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s commented Feb 19, 2026

Description

Adds minimatch advisory GHSA-3ppc-4f35-3m26 (ID 1113296) to npmAuditIgnoreAdvisories in .yarnrc.yml.

Reason: minimatch <10.2.1 has a high-severity ReDoS vulnerability via repeated wildcards with non-matching literals.

Why ignore: The vulnerable versions (3.1.2 via eslint-plugin-n, 10.1.1 via glob) are only used in dev/build-time dependencies and are not shipped to users.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Run yarn npm audit and verify advisory 1113296 no longer appears.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Config-only change that affects audit reporting/CI noise, not runtime behavior. Risk is mainly that a real vulnerability could be overlooked if minimatch usage changes in the future.

Overview
Updates .yarnrc.yml to ignore npm audit advisory 1113296 for minimatch (GHSA-3ppc-4f35-3m26), with comments documenting that the ReDoS issue is only present in dev/build-time dependencies and not shipped to users.

Written by Cursor Bugbot for commit be18b6e. This will update automatically on new commits. Configure here.

Only affects dev/build-time dependencies (eslint-plugin-n, glob) and is
not shipped to users.
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner February 19, 2026 00:22
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-platform Core Platform team label Feb 19, 2026
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 19, 2026

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/extension-platform (1 files, +5 -0)
  • 📄 .yarnrc.yml +5 -0

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 19, 2026
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 19, 2026

Builds ready [be18b6e]
UI Startup Metrics (1426 ± 96 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1426122416559614671628
load1227103314828912631398
domContentLoaded1218101914528712491373
domInteractive2816101202582
firstPaint154701250132212266
backgroundConnect25823541122261298
firstReactRender18113741925
initialActions107112
loadScripts97878412058510121132
setupStore1372851621
numNetworkReqs312291202286
BrowserifyPower User HomeuiStartup2679143810752172925874668
load12611072180416013071645
domContentLoaded12421061179015312751614
domInteractive3519176233489
firstPaint218821590171275394
backgroundConnect902304828913265562783
firstReactRender2516236222531
initialActions102111
loadScripts977819147614710021327
setupStore1564171632
numNetworkReqs75321432792125
WebpackStandard HomeuiStartup91170711981079851090
load7746281070109873941
domContentLoaded7676241062107862933
domInteractive3018143222583
firstPaint1326743869167278
backgroundConnect301973103650
firstReactRender19124262033
initialActions104112
loadScripts7646221060106860925
setupStore1263451323
numNetworkReqs312289192584
WebpackPower User HomeuiStartup1293973201116813821588
load76765211811167751072
domContentLoaded75564611731147581060
domInteractive41191693139119
firstPaint159721097124155356
backgroundConnect17713140153185294
firstReactRender24174042631
initialActions105111
loadScripts75264311651117561048
setupStore1454571622
numNetworkReqs1203526151150199
FirefoxBrowserifyStandard HomeuiStartup17111492266020917222089
load14441228233717714751688
domContentLoaded14431228233717714741688
domInteractive983491092137148
firstPaint------
backgroundConnect6131267276187
firstReactRender14112221517
initialActions103122
loadScripts14161203230017214461605
setupStore187164211732
numNetworkReqs321995202790
BrowserifyPower User HomeuiStartup28942085804368130483790
load16251295668356816392133
domContentLoaded16251289668356816392132
domInteractive14838896147125431
firstPaint------
backgroundConnect3671161155263492877
firstReactRender19157781926
initialActions214122
loadScripts15811269657155715802092
setupStore1318779166170433
numNetworkReqs74312313887146
WebpackStandard HomeuiStartup16551387362331016572000
load13881176324721214121586
domContentLoaded13871172324721214121585
domInteractive115311947189132150
firstPaint------
backgroundConnect7724191418865160
firstReactRender16116971625
initialActions103012
loadScripts13601156323120613891502
setupStore207149241648
numNetworkReqs312093192784
WebpackPower User HomeuiStartup27782028444541130033508
load16021311358531816712161
domContentLoaded16021311358531816652160
domInteractive17035877190142682
firstPaint------
backgroundConnect3981251288272574950
firstReactRender22165962531
initialActions218123
loadScripts15631293353531115982131
setupStore1628772194199593
numNetworkReqs73292043984148
📊 Page Load Benchmark Results

Current Commit: be18b6e | Date: 2/19/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±50ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±71ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 84ms (±49ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 50ms 1.01s 1.44s 1.07s 1.44s
domContentLoaded 731ms 71ms 703ms 1.39s 758ms 1.39s
firstPaint 84ms 49ms 60ms 572ms 88ms 572ms
firstContentfulPaint 84ms 49ms 60ms 572ms 88ms 572ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

@cryptodev-2s cryptodev-2s added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main with commit 2d9725e Feb 19, 2026
355 of 362 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/ignore-minimatch-advisory-1113296 branch February 19, 2026 08:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2026
@metamaskbot metamaskbot added the release-13.20.0 Issue or pull request that will be included in release 13.20.0 label Feb 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.20.0 Issue or pull request that will be included in release 13.20.0 size-XS team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants