Skip to content

fix: wallet_requestExecutionPermissions requests should reject any requests that include chains that don't support EIP-7702#40152

Merged
jeffsmale90 merged 12 commits intomainfrom
fix/advanced-permissions-validate-chain-is-supported
Mar 4, 2026
Merged

fix: wallet_requestExecutionPermissions requests should reject any requests that include chains that don't support EIP-7702#40152
jeffsmale90 merged 12 commits intomainfrom
fix/advanced-permissions-validate-chain-is-supported

Conversation

@jeffsmale90
Copy link
Contributor

@jeffsmale90 jeffsmale90 commented Feb 17, 2026

Description

Presently when a wallet_requestExecutionPermissions RPC is served for a chain that doesn't support EIP-7702, we allow the user to sign the permission, and it is returned to the dapp.

This results in an expectation that the dapp will serve the requested feature - but the permission is not valid, as the account may not be upgraded on the chain.

This PR adds additional validation to the RPC before forwarding it to the Permissions Kernel snap.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Reject wallet_requestExecutionPermissions requests that include chains that do not support EIP-7702

Related issues

Fixes:

Manual testing steps

  1. Load Gator Permissions Snap test dapp https://github.com/MetaMask/snap-7715-permissions/tree/main/packages/site with VITE_SUPPORTED_CHAINS=1,59144
  2. Select "Ethereum" under chain and request the permission

Expect: Permission request is shown in the wallet

  1. Select "Linea mainnet" (not supported) under chain and request the permission

Expect: The request is rejected

Screenshots/Recordings

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes JSON-RPC behavior for wallet_requestExecutionPermissions by hard-rejecting requests containing unsupported chainIds based on remote feature flags, which could affect dapps relying on previous permissive behavior. Logic is straightforward but touches permission-gating and feature-flag-driven chain support.

Overview
Pre-validates wallet_requestExecutionPermissions requests to reject any params that include a chainId not listed in the confirmations_eip_7702.supportedChains remote feature flag, returning methodNotSupported before forwarding to the Permissions Kernel snap.

Adds getEip7702SupportedChains in eip7702-support-utils to read supported chains from remote feature flags, and extends unit + e2e coverage (including mocking the client-config flags API) to ensure unsupported chains are blocked and matching is case-insensitive.

Written by Cursor Bugbot for commit ffc7e8e. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-delegation MetaMask Delegation Team label Feb 17, 2026
@jeffsmale90 jeffsmale90 force-pushed the fix/advanced-permissions-validate-chain-is-supported branch from c64b3e8 to d918704 Compare February 18, 2026 22:51
@jeffsmale90 jeffsmale90 force-pushed the fix/advanced-permissions-validate-chain-is-supported branch from d918704 to 01245c0 Compare February 18, 2026 23:16
@jeffsmale90 jeffsmale90 force-pushed the fix/advanced-permissions-validate-chain-is-supported branch from 01245c0 to 707b676 Compare February 18, 2026 23:17
@jeffsmale90 jeffsmale90 changed the title When serving wallet_requestExecutionPermissions, ensure that the specified chains support EIP-7702 fix: wallet_requestExecutionPermissions requests should reject any requests that include chains that don't support EIP-7702 Feb 18, 2026
@jeffsmale90 jeffsmale90 marked this pull request as ready for review February 18, 2026 23:19
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 18, 2026

Builds ready [707b676]
UI Startup Metrics (1433 ± 96 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1433123816759614831624
load1217103814318512571385
domContentLoaded1210103314248312441378
domInteractive2816114202580
firstPaint182711254164218329
backgroundConnect25423238721256289
firstReactRender18133042025
initialActions105113
loadScripts97380011818310051143
setupStore1265361420
numNetworkReqs312290192583
BrowserifyPower User HomeuiStartup2162143311286119721364041
load12311097180715512561603
domContentLoaded12151083179715012451588
domInteractive37211742437104
firstPaint189741257139248368
backgroundConnect49130951835933701175
firstReactRender24154982543
initialActions103112
loadScripts95280714901449861321
setupStore1784082035
numNetworkReqs65371462572118
WebpackStandard HomeuiStartup820657113095876975
load70058587583766841
domContentLoaded69458187082757835
domInteractive2716145222373
firstPaint1155735766135257
backgroundConnect26176592847
firstReactRender17113862030
initialActions102111
loadScripts69157986881755832
setupStore1153051223
numNetworkReqs312297212592
WebpackPower User HomeuiStartup1233958178715813161543
load72863411581137191030
domContentLoaded71862911371127081020
domInteractive37191832835105
firstPaint1456653384168287
backgroundConnect16413239351161296
firstReactRender23176552430
initialActions105111
loadScripts71662711271107061009
setupStore1152131318
numNetworkReqs1133725950141225
FirefoxBrowserifyStandard HomeuiStartup17361436280823317662255
load14691209254421214821844
domContentLoaded14671209253821114821844
domInteractive119361174145135240
firstPaint------
backgroundConnect65351992470112
firstReactRender14121911516
initialActions103122
loadScripts14381186251720814541826
setupStore177146161643
numNetworkReqs312095202786
BrowserifyPower User HomeuiStartup29292067818384529893808
load16791350646864216592182
domContentLoaded16791349646864216592182
domInteractive13835771126124434
firstPaint------
backgroundConnect3761221996356434954
firstReactRender211583112127
initialActions203122
loadScripts16401319642563816272132
setupStore1349755184120597
numNetworkReqs66261843681133
WebpackStandard HomeuiStartup17171425329433017231995
load14491183295226714661643
domContentLoaded14481183295126814661643
domInteractive932826651130190
firstPaint------
backgroundConnect56251582861125
firstReactRender15122631523
initialActions103112
loadScripts14231171292326514451617
setupStore187112181753
numNetworkReqs312092182778
WebpackPower User HomeuiStartup28122003471448730253781
load16061320295132716432214
domContentLoaded16061320295132716432214
domInteractive174341420222144596
firstPaint------
backgroundConnect4051261316287609981
firstReactRender23157482430
initialActions213122
loadScripts15601220292832015662186
setupStore1489674178168571
numNetworkReqs67252394577170
📊 Page Load Benchmark Results

Current Commit: 707b676 | Date: 2/18/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 972ms (±37ms) 🟢 | historical mean value: 1.03s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 681ms (±33ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 972ms 37ms 944ms 1.25s 988ms 1.25s
domContentLoaded 681ms 33ms 658ms 943ms 693ms 943ms
firstPaint 77ms 11ms 60ms 172ms 84ms 172ms
firstContentfulPaint 77ms 11ms 60ms 172ms 84ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 489 Bytes (0.01%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 19, 2026

Builds ready [65b6e8a]
UI Startup Metrics (1441 ± 116 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup14411226187011614801638
load1234103216429712651403
domContentLoaded1227102915839312591392
domInteractive2817102182581
firstPaint1567147374207277
backgroundConnect26524143931271296
firstReactRender18113951930
initialActions104113
loadScripts98278113299210131145
setupStore1364861421
numNetworkReqs312289192383
BrowserifyPower User HomeuiStartup2630154011264169624286128
load13071128180914813601637
domContentLoaded12881116171313513401607
domInteractive3620142203769
firstPaint232841735249261353
backgroundConnect68331951438484782500
firstReactRender24174962738
initialActions103112
loadScripts1011858144212810411348
setupStore1674871829
numNetworkReqs72301332488118
WebpackStandard HomeuiStartup88871611821049621089
load751616103894814909
domContentLoaded745610103394810903
domInteractive281594182480
firstPaint1216525350155227
backgroundConnect28207293143
firstReactRender18123962032
initialActions103112
loadScripts742608103193808901
setupStore1263351323
numNetworkReqs3122101212588
WebpackPower User HomeuiStartup1307913206620214241672
load77667211771087821059
domContentLoaded76566711641087681051
domInteractive42191763141125
firstPaint1606749775187298
backgroundConnect17613155360176279
firstReactRender23163542530
initialActions103111
loadScripts76266511521057651042
setupStore1252341420
numNetworkReqs1253625947150197
FirefoxBrowserifyStandard HomeuiStartup16541389248920216672011
load13951176220217314241637
domContentLoaded13941170220217314221637
domInteractive813326544110147
firstPaint------
backgroundConnect5929158186388
firstReactRender14111811416
initialActions103122
loadScripts13671152217917013941585
setupStore208157261548
numNetworkReqs312093202588
BrowserifyPower User HomeuiStartup28242055745158529523538
load16111328574746616372018
domContentLoaded16101328574646616372018
domInteractive16139766134178442
firstPaint------
backgroundConnect4249312633305861071
firstReactRender18146861922
initialActions203122
loadScripts15681301570746116061857
setupStore1079710143112372
numNetworkReqs76301853897162
WebpackStandard HomeuiStartup16741476207713917101979
load1409121816959014701545
domContentLoaded1408121816959014701545
domInteractive913117740130153
firstPaint------
backgroundConnect60302193669121
firstReactRender16133441626
initialActions103122
loadScripts1383119116398314391514
setupStore178160221344
numNetworkReqs321997192783
WebpackPower User HomeuiStartup28091942714660829403450
load15961271580551015852136
domContentLoaded15951271580551015842136
domInteractive153331085175140636
firstPaint------
backgroundConnect3805717743235271024
firstReactRender22157172430
initialActions207122
loadScripts15631256577950715652094
setupStore17981424239222660
numNetworkReqs73291913597135
📊 Page Load Benchmark Results

Current Commit: 65b6e8a | Date: 2/19/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 981ms (±39ms) 🟢 | historical mean value: 1.03s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 688ms (±36ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 981ms 39ms 953ms 1.27s 1.00s 1.27s
domContentLoaded 688ms 36ms 666ms 958ms 707ms 958ms
firstPaint 77ms 13ms 64ms 192ms 84ms 192ms
firstContentfulPaint 77ms 13ms 64ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 527 Bytes (0.01%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

@jeffsmale90 jeffsmale90 force-pushed the fix/advanced-permissions-validate-chain-is-supported branch from 65b6e8a to 70d5489 Compare February 19, 2026 02:03
@jeffsmale90 jeffsmale90 force-pushed the fix/advanced-permissions-validate-chain-is-supported branch from 70d5489 to 38858c0 Compare February 19, 2026 02:13
@jeffsmale90
Copy link
Contributor Author

Health check is failing because of #40221

OGPoyraz
OGPoyraz previously approved these changes Feb 19, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 3, 2026

Builds ready [d181c28]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account2822732886286288
total2822732886286288
Confirm Txconfirm_tx5987597260051359926005
total5987597260051359926005
Bridge User Actionsbridge_load_page2572472657259265
bridge_load_asset_picker17212921430177214
bridge_search_token72770375020743750
total1176109112977812161297
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14231170193911714691607
load1194985160210512431381
domContentLoaded1186978157010312381362
domInteractive281795192480
firstPaint161681348144201355
backgroundConnect20918925616209247
firstReactRender19124052229
initialActions104124
loadScripts995780135610210481171
setupStore1364271526
numNetworkReqs312289192284
Power User HomeuiStartup226814217003115120474798
load12181048178615612401649
domContentLoaded12031034177715712301636
domInteractive3823163234088
firstPaint1748441682221338
backgroundConnect54926931756323462030
firstReactRender24166172536
initialActions108112
loadScripts985841151915010081379
setupStore1765991937
numNetworkReqs68351392674133
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2192192201220220
srpButtonToSrpForm94939519495
confirmSrpToPwForm22222202222
pwFormToMetricsScreen15151501515
metricsToWalletReadyScreen16161601616
doneButtonToHomeScreen67359177365665773
openAccountMenuToAccountListLoaded2939290329632229522963
total3967386240908540254090
Onboarding New WalletcreateWalletToSocialScreen2192172222220222
srpButtonToPwForm1081071091108109
createPwToRecoveryScreen889099
skipBackupToMetricsScreen37363813738
agreeButtonToOnboardingSuccess16161701717
doneButtonToAssetList58449168369597683
total9828791073699881073
Asset DetailsassetClickToPriceChart564083166083
total564083166083
Solana Asset DetailsassetClickToPriceChart76728137781
total76728137781
Import Srp HomeloginToHomeScreen21001963238715721472387
openAccountMenuAfterLogin43375364753
homeAfterImportWithNewWallet27872559302615828833026
total49304744509315350675093
Send TransactionsopenSendPageFromHome23143262832
selectTokenToSendFormLoaded26163573235
reviewTransactionToConfirmationPage8458438472846847
total8918849016890901
SwapopenSwapPageFromHome1191111277127127
fetchAndDisplaySwapQuotes290228942911629042911
total3023300730381230303038
🌐 Dapp Page Load Benchmarks

Current Commit: d181c28 | Date: 3/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 729ms (±39ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±12ms) 🟢 | historical mean value: 87ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 40ms 1.01s 1.34s 1.05s 1.34s
domContentLoaded 729ms 39ms 706ms 1.02s 743ms 1.02s
firstPaint 80ms 12ms 60ms 180ms 92ms 180ms
firstContentfulPaint 80ms 12ms 60ms 180ms 92ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 5.24 MiB (100%)
  • ui: 8.16 MiB (100%)
  • common: 10.9 MiB (100%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 3, 2026

Builds ready [d181c28]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account2822732886286288
total2822732886286288
Confirm Txconfirm_tx5987597260051359926005
total5987597260051359926005
Bridge User Actionsbridge_load_page2572472657259265
bridge_load_asset_picker17212921430177214
bridge_search_token72770375020743750
total1176109112977812161297
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14231170193911714691607
load1194985160210512431381
domContentLoaded1186978157010312381362
domInteractive281795192480
firstPaint161681348144201355
backgroundConnect20918925616209247
firstReactRender19124052229
initialActions104124
loadScripts995780135610210481171
setupStore1364271526
numNetworkReqs312289192284
Power User HomeuiStartup226814217003115120474798
load12181048178615612401649
domContentLoaded12031034177715712301636
domInteractive3823163234088
firstPaint1748441682221338
backgroundConnect54926931756323462030
firstReactRender24166172536
initialActions108112
loadScripts985841151915010081379
setupStore1765991937
numNetworkReqs68351392674133
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2192192201220220
srpButtonToSrpForm94939519495
confirmSrpToPwForm22222202222
pwFormToMetricsScreen15151501515
metricsToWalletReadyScreen16161601616
doneButtonToHomeScreen67359177365665773
openAccountMenuToAccountListLoaded2939290329632229522963
total3967386240908540254090
Onboarding New WalletcreateWalletToSocialScreen2192172222220222
srpButtonToPwForm1081071091108109
createPwToRecoveryScreen889099
skipBackupToMetricsScreen37363813738
agreeButtonToOnboardingSuccess16161701717
doneButtonToAssetList58449168369597683
total9828791073699881073
Asset DetailsassetClickToPriceChart564083166083
total564083166083
Solana Asset DetailsassetClickToPriceChart76728137781
total76728137781
Import Srp HomeloginToHomeScreen21001963238715721472387
openAccountMenuAfterLogin43375364753
homeAfterImportWithNewWallet27872559302615828833026
total49304744509315350675093
Send TransactionsopenSendPageFromHome23143262832
selectTokenToSendFormLoaded26163573235
reviewTransactionToConfirmationPage8458438472846847
total8918849016890901
SwapopenSwapPageFromHome1191111277127127
fetchAndDisplaySwapQuotes290228942911629042911
total3023300730381230303038
🌐 Dapp Page Load Benchmarks

Current Commit: d181c28 | Date: 3/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 729ms (±39ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±12ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 40ms 1.01s 1.34s 1.05s 1.34s
domContentLoaded 729ms 39ms 706ms 1.02s 743ms 1.02s
firstPaint 80ms 12ms 60ms 180ms 92ms 180ms
firstContentfulPaint 80ms 12ms 60ms 180ms 92ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 5.24 MiB (100%)
  • ui: 8.16 MiB (100%)
  • common: 10.9 MiB (100%)

@jeffsmale90 jeffsmale90 force-pushed the fix/advanced-permissions-validate-chain-is-supported branch from d181c28 to f5cea4c Compare March 3, 2026 22:02
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

- updates fixtureBuilder with withRemoteFeatureFlagController function
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 3, 2026

Builds ready [f5cea4c]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account2752632849283284
total2752632849283284
Confirm Txconfirm_tx606060586061160616061
total606060586061160616061
Bridge User Actionsbridge_load_page2342312372237237
bridge_load_asset_picker22015633464244334
bridge_search_token72970175823746758
total1184110913118612631311
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14281189193712114821652
load12021011166110912441382
domContentLoaded11951008163410712401373
domInteractive2817103182478
firstPaint1487048084192292
backgroundConnect21519237422220243
firstReactRender20114762131
initialActions107124
loadScripts998809142710510401171
setupStore1364161623
numNetworkReqs312295202282
Power User HomeuiStartup280013469777181432708229
load12521041181216013021565
domContentLoaded12321027176315412831556
domInteractive3620141223686
firstPaint250902452301281380
backgroundConnect844263388710006483235
firstReactRender26155582842
initialActions109114
loadScripts1011824150314410541330
setupStore1664661829
numNetworkReqs75451622288108
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2202192221221222
srpButtonToSrpForm100991011101101
confirmSrpToPwForm23222302323
pwFormToMetricsScreen16161601616
metricsToWalletReadyScreen18181801818
doneButtonToHomeScreen70659679780766797
openAccountMenuToAccountListLoaded2921290329391329262939
total3990391141117840484111
Onboarding New WalletcreateWalletToSocialScreen2202192221222222
srpButtonToPwForm1121091205110120
createPwToRecoveryScreen889089
skipBackupToMetricsScreen37354123841
agreeButtonToOnboardingSuccess16161701617
doneButtonToAssetList60158062820610628
total98188310515910311051
Asset DetailsassetClickToPriceChart53426175761
total53426175761
Solana Asset DetailsassetClickToPriceChart79748648286
total79748648286
Import Srp HomeloginToHomeScreen2151204723149321842314
openAccountMenuAfterLogin663091227891
homeAfterImportWithNewWallet26532452280814127612808
total4881480749335249274933
Send TransactionsopenSendPageFromHome20172332323
selectTokenToSendFormLoaded18181911919
reviewTransactionToConfirmationPage8468438493848849
total8858848861886886
SwapopenSwapPageFromHome1161031237122123
fetchAndDisplaySwapQuotes288528832887128852887
total300029863008830073008
🌐 Dapp Page Load Benchmarks

Current Commit: f5cea4c | Date: 3/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±40ms) 🟡 | historical mean value: 1.06s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 727ms (±37ms) 🟢 | historical mean value: 743ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 84ms (±11ms) 🟢 | historical mean value: 85ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 40ms 1.03s 1.35s 1.10s 1.35s
domContentLoaded 727ms 37ms 700ms 1.00s 761ms 1.00s
firstPaint 84ms 11ms 68ms 176ms 100ms 176ms
firstContentfulPaint 84ms 11ms 68ms 176ms 100ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 542 Bytes (0.01%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

@jeffsmale90 jeffsmale90 force-pushed the fix/advanced-permissions-validate-chain-is-supported branch from f5cea4c to f166caf Compare March 3, 2026 22:47
mj-kiwi
mj-kiwi previously approved these changes Mar 3, 2026
Copy link
Contributor

@mj-kiwi mj-kiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's Go!

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 3, 2026

Builds ready [f166caf]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account35927548082433480
total35927548082433480
Confirm Txconfirm_tx6053602960872260716087
total6053602960872260716087
Bridge User Actionsbridge_load_page26420931136287311
bridge_load_asset_picker25222328527272285
bridge_search_token71670373512725735
total1206113612765612371276
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14131186199511414451632
load1182100116489812171367
domContentLoaded117599316389812111363
domInteractive2917114192674
firstPaint164691026115214315
backgroundConnect20919525913211236
firstReactRender20134262232
initialActions107124
loadScripts98280014419710221165
setupStore1465181627
numNetworkReqs312286192581
Power User HomeuiStartup2261137310066165320504574
load12131069176717112311642
domContentLoaded11981064173516912161629
domInteractive40181963437128
firstPaint220701463160280387
backgroundConnect682263852413573392416
firstReactRender26156193044
initialActions105114
loadScripts983843150516010061407
setupStore1677091734
numNetworkReqs67361532878142
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2202192221221222
srpButtonToSrpForm9590101497101
confirmSrpToPwForm21212102121
pwFormToMetricsScreen15151501515
metricsToWalletReadyScreen16151711617
doneButtonToHomeScreen59758661310598613
openAccountMenuToAccountListLoaded2920289929361629362936
total3891386439292839293929
Onboarding New WalletcreateWalletToSocialScreen2172162191218219
srpButtonToPwForm11110213212117132
createPwToRecoveryScreen888088
skipBackupToMetricsScreen34333513335
agreeButtonToOnboardingSuccess16151601616
doneButtonToAssetList6436396515651651
total101899410351610311035
Asset DetailsassetClickToPriceChart45434614646
total45434614646
Solana Asset DetailsassetClickToPriceChart84838518585
total84838518585
Import Srp HomeloginToHomeScreen195019441960719601960
openAccountMenuAfterLogin553082217782
homeAfterImportWithNewWallet2948289329904129902990
total4947489150145150145014
Send TransactionsopenSendPageFromHome19172011920
selectTokenToSendFormLoaded25163673136
reviewTransactionToConfirmationPage8488478491849849
total8928839027897902
SwapopenSwapPageFromHome1191121265121126
fetchAndDisplaySwapQuotes2907288829331829202933
total3026299930542230463054
🌐 Dapp Page Load Benchmarks

Current Commit: f166caf | Date: 3/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±43ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 739ms (±39ms) 🟢 | historical mean value: 742ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±15ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 43ms 1.01s 1.34s 1.09s 1.34s
domContentLoaded 739ms 39ms 709ms 1.01s 768ms 1.01s
firstPaint 80ms 15ms 60ms 208ms 92ms 208ms
firstContentfulPaint 80ms 15ms 60ms 208ms 92ms 208ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 542 Bytes (0.01%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

…s overridden immediately when the controller is initialized anyways. Use mockttp to mock the remote feature flags http request instead.
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 4, 2026

Builds ready [00dfc2e]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account2692662712269271
total2692662712269271
Confirm Txconfirm_tx606260496072960696072
total606260496072960696072
Bridge User Actionsbridge_load_page26020732240284322
bridge_load_asset_picker23816828449281284
bridge_search_token73770675920754759
total1268123012922312791292
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14221168173911014771625
load119398414429612491361
domContentLoaded118698014379612431357
domInteractive2916105182579
firstPaint1386841071184274
backgroundConnect21219233119213244
firstReactRender19124652028
initialActions2010226
loadScripts99279012329510461169
setupStore1363861526
numNetworkReqs312296202583
Power User HomeuiStartup17001314216214717581978
load11471013175314011381507
domContentLoaded11321004174213711311470
domInteractive3319132203281
firstPaint173731754176212314
backgroundConnect29726338925306350
firstReactRender22155752330
initialActions104113
loadScripts91880315031329121237
setupStore1574051724
numNetworkReqs58371682654131
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2202202210220221
srpButtonToSrpForm104981126110112
confirmSrpToPwForm22222202222
pwFormToMetricsScreen16161601616
metricsToWalletReadyScreen17171701717
doneButtonToHomeScreen6005936045604604
openAccountMenuToAccountListLoaded2926290329451529382945
total3913388239442139223944
Onboarding New WalletcreateWalletToSocialScreen2192172212221221
srpButtonToPwForm1071061091108109
createPwToRecoveryScreen888088
skipBackupToMetricsScreen36334023740
agreeButtonToOnboardingSuccess16161711717
doneButtonToAssetList60249568274680682
total99089010737310671073
Asset DetailsassetClickToPriceChart40394004040
total40394004040
Solana Asset DetailsassetClickToPriceChart73717527475
total73717527475
Import Srp HomeloginToHomeScreen1953190120887819152088
openAccountMenuAfterLogin33313723337
homeAfterImportWithNewWallet27422587292714328992927
total46824520484413947924844
Send TransactionsopenSendPageFromHome21162842528
selectTokenToSendFormLoaded21202212122
reviewTransactionToConfirmationPage8528448679849867
total89888393622888936
SwapopenSwapPageFromHome12511314111130141
fetchAndDisplaySwapQuotes289728932901328982901
total302230143035930233035
🌐 Dapp Page Load Benchmarks

Current Commit: 00dfc2e | Date: 3/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±41ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 739ms (±38ms) 🟢 | historical mean value: 747ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 81ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 41ms 1.02s 1.34s 1.09s 1.34s
domContentLoaded 739ms 38ms 713ms 1.02s 775ms 1.02s
firstPaint 81ms 11ms 64ms 164ms 88ms 164ms
firstContentfulPaint 81ms 11ms 64ms 164ms 88ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 542 Bytes (0.01%)
  • ui: 552 Bytes (0.01%)
  • common: 387 Bytes (0%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 4, 2026

Builds ready [48bf8bd]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account438274551113541551
total438274551113541551
Confirm Txconfirm_tx606060556069660696069
total606060556069660696069
Bridge User Actionsbridge_load_page22819428232235282
bridge_load_asset_picker20217023226231232
bridge_search_token72170176625730766
total1150110112445311711244
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14431201175211015091640
load1212995149210412601413
domContentLoaded1204990148710112511393
domInteractive2917130182771
firstPaint180701258137224369
backgroundConnect21519137223220250
firstReactRender19134652028
initialActions109124
loadScripts100880212839910551196
setupStore1262841620
numNetworkReqs312289192283
Power User HomeuiStartup17241435230014117622013
load11671051175314311511560
domContentLoaded11521037166014011371535
domInteractive3620179233584
firstPaint1907652489251315
backgroundConnect29826642326306336
firstReactRender24165482538
initialActions107112
loadScripts93681514261369171300
setupStore1574661726
numNetworkReqs58371552754140
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2182172191219219
srpButtonToSrpForm95949619596
confirmSrpToPwForm22222202222
pwFormToMetricsScreen15151601616
metricsToWalletReadyScreen16161601616
doneButtonToHomeScreen62559265226649652
openAccountMenuToAccountListLoaded2928290229541729362954
total3954390040204940044020
Onboarding New WalletcreateWalletToSocialScreen2252182357234235
srpButtonToPwForm1111081142112114
createPwToRecoveryScreen989099
skipBackupToMetricsScreen37373703737
agreeButtonToOnboardingSuccess18161911819
doneButtonToAssetList61955966638653666
total1041101910561410461056
Asset DetailsassetClickToPriceChart504167105367
total504167105367
Solana Asset DetailsassetClickToPriceChart77748137881
total77748137881
Import Srp HomeloginToHomeScreen20921945228212021542282
openAccountMenuAfterLogin50396695666
homeAfterImportWithNewWallet28262506301719429843017
total49684641532227152105322
Send TransactionsopenSendPageFromHome23173152431
selectTokenToSendFormLoaded19182222022
reviewTransactionToConfirmationPage8458428482845848
total8868848871887887
SwapopenSwapPageFromHome1131051259123125
fetchAndDisplaySwapQuotes289628922900328982900
total3009299630251130183025
🌐 Dapp Page Load Benchmarks

Current Commit: 48bf8bd | Date: 3/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±38ms) 🟢 | historical mean value: 747ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 82ms (±10ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 40ms 1.02s 1.35s 1.09s 1.35s
domContentLoaded 737ms 38ms 714ms 1.02s 772ms 1.02s
firstPaint 82ms 10ms 68ms 168ms 92ms 168ms
firstContentfulPaint 82ms 10ms 68ms 168ms 92ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 542 Bytes (0.01%)
  • ui: 552 Bytes (0.01%)
  • common: 387 Bytes (0%)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2026

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 4, 2026

Builds ready [438a753]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account2732682773275277
total2732682773275277
Confirm Txconfirm_tx6066605160781160786078
total6066605160781160786078
Bridge User Actionsbridge_load_page2372352381238238
bridge_load_asset_picker1761751771177177
bridge_search_token7147037289721728
total1125110711481411331148
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14081218181811314371619
load1181100415259612171366
domContentLoaded117499515189412121346
domInteractive291698192580
firstPaint162691144122213273
backgroundConnect20918942525210231
firstReactRender18123542024
initialActions108115
loadScripts98281013139110161158
setupStore156199191622
numNetworkReqs312291202384
Power User HomeuiStartup16831307228118417272065
load11461007178417211151666
domContentLoaded11291000177316611001600
domInteractive3419124223294
firstPaint191741613166244349
backgroundConnect28925536923295333
firstReactRender23165582340
initialActions103112
loadScripts92280315381598921359
setupStore1474061526
numNetworkReqs58351592754129
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2182172180218218
srpButtonToSrpForm100901138103113
confirmSrpToPwForm22212202222
pwFormToMetricsScreen15151601516
metricsToWalletReadyScreen16161601616
doneButtonToHomeScreen5925895952592595
openAccountMenuToAccountListLoaded2945292129722029632972
total3898387939281939013928
Onboarding New WalletcreateWalletToSocialScreen2222172274225227
srpButtonToPwForm1121061174113117
createPwToRecoveryScreen889089
skipBackupToMetricsScreen35333823738
agreeButtonToOnboardingSuccess16151711717
doneButtonToAssetList56249262447599624
total9568931015419801015
Asset DetailsassetClickToPriceChart39344544145
total39344544145
Solana Asset DetailsassetClickToPriceChart68627247072
total68627247072
Import Srp HomeloginToHomeScreen20821927241619021712416
openAccountMenuAfterLogin534372115872
homeAfterImportWithNewWallet2722263928015827342801
total49334696512117251015121
Send TransactionsopenSendPageFromHome25183142731
selectTokenToSendFormLoaded19182011920
reviewTransactionToConfirmationPage8458458460846846
total8898828955891895
SwapopenSwapPageFromHome105991094107109
fetchAndDisplaySwapQuotes288628832889328892889
total300129923013830083013
🌐 Dapp Page Load Benchmarks

Current Commit: 438a753 | Date: 3/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±42ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±38ms) 🟢 | historical mean value: 748ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±15ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 42ms 1.02s 1.35s 1.07s 1.35s
domContentLoaded 734ms 38ms 716ms 1.01s 755ms 1.01s
firstPaint 80ms 15ms 60ms 212ms 88ms 212ms
firstContentfulPaint 80ms 15ms 60ms 212ms 88ms 212ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 542 Bytes (0.01%)
  • ui: 689 Bytes (0.01%)
  • common: 387 Bytes (0%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 4, 2026

Builds ready [ffc7e8e]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account29226731721308317
total29226731721308317
Confirm Txconfirm_tx608560776091560886091
total608560776091560886091
Bridge User Actionsbridge_load_page29121536759348367
bridge_load_asset_picker19310828166255281
bridge_search_token73071076321733763
total12471103142313513851423
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup1434120916879714751605
load120999914449112491372
domContentLoaded120299314338912431359
domInteractive3016137212684
firstPaint165721256135216311
backgroundConnect22219830916227251
firstReactRender20134552130
initialActions107124
loadScripts99779812368810331160
setupStore1376571521
numNetworkReqs312289202283
Power User HomeuiStartup240013549603169221875910
load11751036185615711971554
domContentLoaded11611030181915511721540
domInteractive3517189243476
firstPaint1918449692257366
backgroundConnect62026337108034033082
firstReactRender24155772637
initialActions107113
loadScripts94680415491479611296
setupStore1466281629
numNetworkReqs69331552780127
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2192182201220220
srpButtonToSrpForm96959719797
confirmSrpToPwForm22222302223
pwFormToMetricsScreen16151601616
metricsToWalletReadyScreen17171701717
doneButtonToHomeScreen62960865220647652
openAccountMenuToAccountListLoaded2925289929502229442950
total3991392141559140264155
Onboarding New WalletcreateWalletToSocialScreen2222222230223223
srpButtonToPwForm1091081101109110
createPwToRecoveryScreen989099
skipBackupToMetricsScreen35353603636
agreeButtonToOnboardingSuccess16161701617
doneButtonToAssetList56048660954607609
total95588910005310001000
Asset DetailsassetClickToPriceChart13810718428150184
total13810718428150184
Solana Asset DetailsassetClickToPriceChart1141021279120127
total1141021279120127
Import Srp HomeloginToHomeScreen2063200421897420352189
openAccountMenuAfterLogin60497186671
homeAfterImportWithNewWallet3195309432756932693275
total52965169542610453655426
Send TransactionsopenSendPageFromHome26242812828
selectTokenToSendFormLoaded261747123147
reviewTransactionToConfirmationPage8448418462846846
total89888291212906912
SwapopenSwapPageFromHome33224063740
fetchAndDisplaySwapQuotes268426822687226852687
total271727042725827232725
🌐 Dapp Page Load Benchmarks

Current Commit: ffc7e8e | Date: 3/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 729ms (±38ms) 🟢 | historical mean value: 745ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 40ms 1.02s 1.34s 1.07s 1.34s
domContentLoaded 729ms 38ms 709ms 1.01s 757ms 1.01s
firstPaint 79ms 11ms 64ms 172ms 88ms 172ms
firstContentfulPaint 79ms 11ms 64ms 172ms 88ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 542 Bytes (0.01%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.22.0 Issue or pull request that will be included in release 13.22.0 size-M team-delegation MetaMask Delegation Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants