feat: added icons for sidepanel and popup view in drawer component#40008
Merged
feat: added icons for sidepanel and popup view in drawer component#40008
Conversation
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +1 -3)
|
Contributor
Builds ready [077d76b]
UI Startup Metrics (1338 ± 80 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
ameliejyc
approved these changes
Feb 12, 2026
n3ps
approved these changes
Feb 12, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
…40008) This PR adds the correct icons for sidepanel and popup in global menu drawer component ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: icon update ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to app-header-unlocked componet 2. Comment the global-menu component in app-header-unlocked 3. Add this code <GlobalMenuDrawerWithList isOpen={accountOptionsMenuOpen} onClose={() => setAccountOptionsMenuOpen(false)} anchorElement={menuRef.current} /> 4. Run with yarn start 5. Check the global-menu drawer in extension and the icons for sidepanel and popup view are correct ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** NA ### **After** NA ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > UI-only icon change in a single menu item with no impact on navigation logic, state, or data handling. > > **Overview** > Updates the Global Menu drawer “toggle view” action to show the correct icon depending on current viewport: `IconName.PopUp` when in sidepanel and `IconName.SidePanel` when in popup (replacing the temporary `IconName.Expand`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 077d76b. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the correct icons for sidepanel and popup in global menu drawer component
Changelog
CHANGELOG entry: icon update
Related issues
Fixes:
Manual testing steps
<GlobalMenuDrawerWithList
isOpen={accountOptionsMenuOpen}
onClose={() => setAccountOptionsMenuOpen(false)}
anchorElement={menuRef.current}
/>
4. Run with yarn start
5. Check the global-menu drawer in extension and the icons for sidepanel and popup view are correct
Screenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
UI-only icon change in a single menu item with no impact on navigation logic, state, or data handling.
Overview
Updates the Global Menu drawer “toggle view” action to show the correct icon depending on current viewport:
IconName.PopUpwhen in sidepanel andIconName.SidePanelwhen in popup (replacing the temporaryIconName.Expand).Written by Cursor Bugbot for commit 077d76b. This will update automatically on new commits. Configure here.