Skip to content

feat: added icons for sidepanel and popup view in drawer component#40008

Merged
NidhiKJha merged 1 commit intomainfrom
drawer-icon-update
Feb 12, 2026
Merged

feat: added icons for sidepanel and popup view in drawer component#40008
NidhiKJha merged 1 commit intomainfrom
drawer-icon-update

Conversation

@NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Feb 12, 2026

This PR adds the correct icons for sidepanel and popup in global menu drawer component

Changelog

CHANGELOG entry: icon update

Related issues

Fixes:

Manual testing steps

  1. Go to app-header-unlocked componet
  2. Comment the global-menu component in app-header-unlocked
  3. Add this code

<GlobalMenuDrawerWithList
isOpen={accountOptionsMenuOpen}
onClose={() => setAccountOptionsMenuOpen(false)}
anchorElement={menuRef.current}
/>
4. Run with yarn start
5. Check the global-menu drawer in extension and the icons for sidepanel and popup view are correct

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only icon change in a single menu item with no impact on navigation logic, state, or data handling.

Overview
Updates the Global Menu drawer “toggle view” action to show the correct icon depending on current viewport: IconName.PopUp when in sidepanel and IconName.SidePanel when in popup (replacing the temporary IconName.Expand).

Written by Cursor Bugbot for commit 077d76b. This will update automatically on new commits. Configure here.

@NidhiKJha NidhiKJha requested a review from a team as a code owner February 12, 2026 09:14
@metamaskbot metamaskbot added team-core-extension-ux Core Extension UX team INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 12, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 12, 2026

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +1 -3)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 global-menu-drawer/
          • 📄 useGlobalMenuSections.tsx +1 -3

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 12, 2026

Builds ready [077d76b]
UI Startup Metrics (1338 ± 80 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1338117315558013851473
load115499413147711971294
domContentLoaded114799113047711851286
domInteractive261590182279
firstPaint158641140150198299
backgroundConnect23621431715241265
firstReactRender15113541721
initialActions107114
loadScripts9267661084789681059
setupStore1164261423
numNetworkReqs231589201581
BrowserifyPower User HomeuiStartup212213349525117621403483
load11911038177115912301581
domContentLoaded11751032175115512091573
domInteractive37172113233116
firstPaint1857160996247347
backgroundConnect4472793191443372757
firstReactRender21153652332
initialActions103112
loadScripts93879614551469811289
setupStore1557681627
numNetworkReqs1184725847144214
WebpackStandard HomeuiStartup86269712061169171082
load742627106698800917
domContentLoaded736620106197794910
domInteractive271694182478
firstPaint1116132951132204
backgroundConnect26165982943
firstReactRender1610101101924
initialActions105112
loadScripts733618105997790907
setupStore1283451320
numNetworkReqs231591201583
WebpackPower User HomeuiStartup1237876242623612841660
load7086001464131700947
domContentLoaded6985931450131691939
domInteractive37182153136106
firstPaint160631138133175381
backgroundConnect17914835947173285
firstReactRender22174142430
initialActions104111
loadScripts6955911443129689932
setupStore1254561317
numNetworkReqs1354529752156247
FirefoxBrowserifyStandard HomeuiStartup15791359221615816071926
load13701172192813114151661
domContentLoaded13691172192713114141661
domInteractive78313155198141
firstPaint------
backgroundConnect5328120145876
firstReactRender12101811213
initialActions102022
loadScripts13441149190312913871629
setupStore136113131333
numNetworkReqs241395221785
BrowserifyPower User HomeuiStartup27152073404536328623420
load15241223218624515842088
domContentLoaded15231223218124515842088
domInteractive14939782144137434
firstPaint------
backgroundConnect3381131111262429900
firstReactRender17143331723
initialActions103122
loadScripts14811194212423315312025
setupStore1397754188128589
numNetworkReqs803717635103139
WebpackStandard HomeuiStartup16211388313619916491899
load13991214288617714331603
domContentLoaded13981210288517714331602
domInteractive912924245121172
firstPaint------
backgroundConnect58281593061134
firstReactRender15108081421
initialActions103122
loadScripts13681194285917413931520
setupStore14676121147
numNetworkReqs241390201682
WebpackPower User HomeuiStartup26702049851768827293422
load15231296237223615992086
domContentLoaded15231296237123615992085
domInteractive13637825133132500
firstPaint------
backgroundConnect3051194874516253856
firstReactRender21166362429
initialActions214123
loadScripts14881270234522515742009
setupStore1808761202278609
numNetworkReqs733515833100130
📊 Page Load Benchmark Results

Current Commit: 077d76b | Date: 2/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±41ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 728ms (±38ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±9ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 41ms 1.02s 1.34s 1.07s 1.34s
domContentLoaded 728ms 38ms 705ms 1.01s 753ms 1.01s
firstPaint 77ms 9ms 60ms 144ms 84ms 144ms
firstContentfulPaint 77ms 9ms 60ms 144ms 84ms 144ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@NidhiKJha NidhiKJha added this pull request to the merge queue Feb 12, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 12, 2026
…40008)

This PR adds the correct icons for sidepanel and popup in global menu
drawer component

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: icon update

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to app-header-unlocked componet
2. Comment the global-menu component in app-header-unlocked
3. Add this code

<GlobalMenuDrawerWithList
isOpen={accountOptionsMenuOpen}
onClose={() => setAccountOptionsMenuOpen(false)}
anchorElement={menuRef.current}
/>
4. Run with yarn start
5. Check the global-menu drawer in extension and the icons for sidepanel
and popup view are correct

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

NA
### **After**

NA
## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> UI-only icon change in a single menu item with no impact on navigation
logic, state, or data handling.
> 
> **Overview**
> Updates the Global Menu drawer “toggle view” action to show the
correct icon depending on current viewport: `IconName.PopUp` when in
sidepanel and `IconName.SidePanel` when in popup (replacing the
temporary `IconName.Expand`).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
077d76b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Merged via the queue into main with commit 99c0090 Feb 12, 2026
197 of 199 checks passed
@NidhiKJha NidhiKJha deleted the drawer-icon-update branch February 12, 2026 18:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2026
@metamaskbot metamaskbot added the release-13.19.0 Issue or pull request that will be included in release 13.19.0 label Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-13.19.0 Issue or pull request that will be included in release 13.19.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants