Skip to content

fix: bump bitcoin#38315

Merged
Battambang merged 1 commit intomainfrom
chore/bump-bitcoin-1-7-0
Nov 26, 2025
Merged

fix: bump bitcoin#38315
Battambang merged 1 commit intomainfrom
chore/bump-bitcoin-1-7-0

Conversation

@Battambang
Copy link
Copy Markdown
Contributor

@Battambang Battambang commented Nov 26, 2025

Description

Updates bitcoin to 1.7.0, which adds signRewardsMessage method.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Add signRewardsMessage method (#566)

Related issues

Fixes: Add signRewardsMessage method.

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​bitcoin-wallet-snap@​1.6.0 ⏵ 1.7.01001008398 +1100

View full report

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1a03a66]
UI Startup Metrics (1287 ± 116 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12871045152411613661488
load102084612369110811183
domContentLoaded101484112159010761176
domInteractive251495202083
firstPaint53091124540010181132
backgroundConnect21118925512217240
firstReactRender402178124664
getState63171552776119
initialActions107114
loadScripts810642102288866976
setupStore1674071931
numNetworkReqs41281473430142
BrowserifyPower User HomeuiStartup22091842292624523502683
load1029911145412310391363
domContentLoaded1015899143812410251355
domInteractive35181632932123
firstPaint5699914584089661327
backgroundConnect271206752124236591
firstReactRender924415122110128
getState18913173862209240
initialActions104113
loadScripts80468712301228181153
setupStore241186142752
numNetworkReqs102632905397259
WebpackStandard HomeuiStartup88273712101099341142
load66156787686703835
domContentLoaded65656487085699829
domInteractive2615115222291
firstPaint21194839125212610
backgroundConnect952941018
firstReactRender3720175223873
getState47161332561102
initialActions106112
loadScripts65356286284697821
setupStore1366271323
numNetworkReqs41281483430143
WebpackPower User HomeuiStartup18481371266624220032257
load698615108594707948
domContentLoaded688608107595695942
domInteractive34191752833107
firstPaint281931086204251756
backgroundConnect123960119797575
firstReactRender984815223117131
getState16913122822181209
initialActions105112
loadScripts685606106493693933
setupStore22890142646
numNetworkReqs1036629454101268
FirefoxBrowserifyStandard HomeuiStartup14451188199818815251870
load1092923158811611351281
domContentLoaded1091923158811611351281
domInteractive58301462983108
firstPaint------
backgroundConnect61312233962160
firstReactRender29186093449
getState2711207282365
initialActions205122
loadScripts1063908148210510991253
setupStore2511123212379
numNetworkReqs40281302833123
BrowserifyPower User HomeuiStartup26152044416640727513532
load1129994163913511361514
domContentLoaded1128994163913511361514
domInteractive12834581112116469
firstPaint------
backgroundConnect1072841266123224
firstReactRender86412232793119
getState23865696157260622
initialActions218136
loadScripts1096971154213011001485
setupStore18719809189202650
numNetworkReqs102613116680287
WebpackStandard HomeuiStartup17491454239016618542001
load13521142168511014181589
domContentLoaded13511142168511014181588
domInteractive833120239104150
firstPaint------
backgroundConnect68262574269167
firstReactRender34226274047
getState32122553331102
initialActions204123
loadScripts13211127165410113861501
setupStore2710136242699
numNetworkReqs41281272737121
WebpackPower User HomeuiStartup30602267549574530944948
load14631115304741714152775
domContentLoaded14631115304741714152774
domInteractive11729101813998429
firstPaint------
backgroundConnect151331334205145472
firstReactRender97413294998233
getState277781604249283815
initialActions2051523
loadScripts13901096303033413412181
setupStore17981016206263634
numNetworkReqs100622545878243
📊 Page Load Benchmark Results

Current Commit: 1a03a66 | Date: 11/26/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±69ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 725ms (±68ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 74ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 69ms 1.00s 1.30s 1.24s 1.30s
domContentLoaded 725ms 68ms 691ms 988ms 926ms 988ms
firstPaint 74ms 11ms 56ms 160ms 84ms 160ms
firstContentfulPaint 74ms 11ms 56ms 160ms 84ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@Battambang Battambang enabled auto-merge November 26, 2025 14:36
@Battambang Battambang added this pull request to the merge queue Nov 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@Battambang Battambang added this pull request to the merge queue Nov 26, 2025
github-merge-queue bot pushed a commit that referenced this pull request Nov 26, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Updates bitcoin to 1.7.0, which adds signRewardsMessage method.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/38315?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Add `signRewardsMessage` method
([#566](MetaMask/snap-bitcoin-wallet#566))

## **Related issues**

Fixes: Add `signRewardsMessage` method.

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Merged via the queue into main with commit d48cd48 Nov 26, 2025
182 of 187 checks passed
@Battambang Battambang deleted the chore/bump-bitcoin-1-7-0 branch November 26, 2025 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2025
@metamaskbot metamaskbot added the release-13.12.0 Issue or pull request that will be included in release 13.12.0 label Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.12.0 Issue or pull request that will be included in release 13.12.0 size-XS team-network-enablement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants