Skip to content

[cherry pick] Fix left aligned fullscreen (#28218)#28229

Merged
Gudahtt merged 1 commit intoVersion-v12.6.0from
cherry-pick/fix-left-aligned-fullscreen
Oct 31, 2024
Merged

[cherry pick] Fix left aligned fullscreen (#28218)#28229
Gudahtt merged 1 commit intoVersion-v12.6.0from
cherry-pick/fix-left-aligned-fullscreen

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Oct 31, 2024

This is a cherry-pick of #28218 for v12.6.0. Original description:

Description

The Home screen was recently updated to make the overview left-aligned. However the fullscreen UI was not considered, and it ended up looking ugly/broken.

The fullscreen UI has been updated to be centered, as it was before. The Home screen remains left-aligned in the popup.

Open in GitHub Codespaces

Related issues

Fixes #27593

Manual testing steps

Compare how the Home screen overview looks on the fullscreen UI and the popup. It should be centered on the fullscreen UI, left-aligned on the popup.

Screenshots/Recordings

Before

Screenshot 2024-10-31 at 11 32 12

After

Screenshot 2024-10-31 at 11 28 35

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

The Home screen was recently updated to make the overview left-aligned.
However the fullscreen UI was not considered, and it ended up looking
ugly/broken.

The fullscreen UI has been updated to be centered, as it was before. The
Home screen remains left-aligned in the popup.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28218?quickstart=1)

## **Related issues**

Fixes #27593

## **Manual testing steps**

Compare how the Home screen overview looks on the fullscreen UI and the
popup. It should be centered on the fullscreen UI, left-aligned on the
popup.

## **Screenshots/Recordings**

### **Before**

![Screenshot 2024-10-31 at 11 32
12](https://github.com/user-attachments/assets/989ebd4e-90a5-42ae-a522-f7e4d77f0685)

### **After**

![Screenshot 2024-10-31 at 11 28
35](https://github.com/user-attachments/assets/6802bfab-b462-4168-8536-cabb49aceb53)

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Gudahtt Gudahtt changed the base branch from develop to Version-v12.6.0 October 31, 2024 19:41
@Gudahtt Gudahtt changed the title Cherry pick/fix left aligned fullscreen [cherry pick] Fix left aligned fullscreen (#28218) Oct 31, 2024
@Gudahtt Gudahtt marked this pull request as ready for review October 31, 2024 19:47
@Gudahtt Gudahtt requested a review from a team as a code owner October 31, 2024 19:47
@Gudahtt Gudahtt merged commit 2c9ad97 into Version-v12.6.0 Oct 31, 2024
@Gudahtt Gudahtt deleted the cherry-pick/fix-left-aligned-fullscreen branch October 31, 2024 20:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [a92a0f3]
Page Load Metrics (2015 ± 106 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint169526882015217104
domContentLoaded167026731983220106
load168726962015220106
domInteractive1395432110
backgroundConnect116433199
firstReactRender481641022713
getState55519178
initialActions01000
loadScripts120422001467212102
setupStore126826189
uiStartup187529202228231111
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -168.37 KiB (-3.37%)
  • ui: 4.34 KiB (0.06%)
  • common: 107.58 KiB (1.36%)

@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Oct 31, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.6.0 on PR, as PR was cherry-picked in branch 12.6.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.6.0 Issue or pull request that will be included in release 12.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Main screen top section with currency display component and button icons misaligned

3 participants