fix: Fix left-aligned fullscreen UI#28218
Merged
Conversation
DDDDDanica
reviewed
Oct 31, 2024
Gudahtt
commented
Oct 31, 2024
Member
Author
There was a problem hiding this comment.
Left this as a TODO to make this easier to backport to v12.6.0
The Home screen was recently updated to make the overview left-aligned. However the fullscreen UI was not considered, and it ended up looking ugly/broken. The fullscreen UI has been updated to be centered, as it was before. The Home screen remains left-aligned in the popup. Fixes #27593
cf9adf0 to
9963453
Compare
sahar-fehri
approved these changes
Oct 31, 2024
Contributor
|
Am ok with this! |
Collaborator
Builds ready [9963453]
Page Load Metrics (1825 ± 99 ms)
Bundle size diffs
|
Collaborator
|
Missing release label release-12.6.0 on PR. Adding release label release-12.6.0 on PR and removing other release labels(release-12.7.0), as PR was cherry-picked in branch 12.6.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Home screen was recently updated to make the overview left-aligned. However the fullscreen UI was not considered, and it ended up looking ugly/broken.
The fullscreen UI has been updated to be centered, as it was before. The Home screen remains left-aligned in the popup.
Related issues
Fixes #27593
Manual testing steps
Compare how the Home screen overview looks on the fullscreen UI and the popup. It should be centered on the fullscreen UI, left-aligned on the popup.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist