cherry-pick: Fix Snaps usage of PhishingController#27833
Merged
danjm merged 1 commit intoVersion-v12.5.0from Oct 15, 2024
Merged
cherry-pick: Fix Snaps usage of PhishingController#27833danjm merged 1 commit intoVersion-v12.5.0from
danjm merged 1 commit intoVersion-v12.5.0from
Conversation
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> Fixes two problems with Snaps usage of `PhishingController`. Following #25839 the PhishingController expects full URLs instead of hostnames as the input to `testOrigin`. In that PR, the argument of `isOnPhishingList` was incorrectly changed. This PR also patches in some changes from the `snaps` repo that are currently blocked by a release: MetaMask/snaps#2835, MetaMask/snaps#2750 [](https://codespaces.new/MetaMask/metamask-extension/pull/27817?quickstart=1) 1. Create a Snap that links to an URL blocked with `eth-phishing-detect` 2. See that triggering the Snap is disallowed if the user has phishing detection enabled
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/slip44@4.0.0, npm/@metamask/snaps-utils@8.1.1 |
Collaborator
Builds ready [9c7593e]
Page Load Metrics (1705 ± 51 ms)
|
Collaborator
|
No release label on PR. Adding release label release-12.5.0 on PR, as PR was cherry-picked in branch 12.5.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two problems with Snaps usage of
PhishingController. Following #25839 the PhishingController expects full URLs instead of hostnames as the input totestOrigin. In that PR, the argument ofisOnPhishingListwas incorrectly changed. This PR also patches in some changes from thesnapsrepo that are currently blocked by a release: MetaMask/snaps#2835,MetaMask/snaps#2750
This PR cherry-picks a commit from
developthat fixes this: 1f1e142Manual testing steps
eth-phishing-detect