Skip to content

fix: Fix Snaps usage of PhishingController#27817

Merged
FrederikBolding merged 1 commit intodevelopfrom
fb/fix-phishing-detect-with-snaps
Oct 14, 2024
Merged

fix: Fix Snaps usage of PhishingController#27817
FrederikBolding merged 1 commit intodevelopfrom
fb/fix-phishing-detect-with-snaps

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Oct 14, 2024 •
edited by github-actions bot
Loading

Description

Fixes two problems with Snaps usage of PhishingController. Following #25839 the PhishingController expects full URLs instead of hostnames as the input to testOrigin. In that PR, the argument of isOnPhishingList was incorrectly changed. This PR also patches in some changes from the snaps repo that are currently blocked by a release: MetaMask/snaps#2835, MetaMask/snaps#2750

Open in GitHub Codespaces

Manual testing steps

  1. Create a Snap that links to an URL blocked with eth-phishing-detect
  2. See that triggering the Snap is disallowed if the user has phishing detection enabled

@FrederikBolding FrederikBolding added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Oct 14, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner October 14, 2024 10:44
@socket-security
Copy link
Copy Markdown

socket-security bot commented Oct 14, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/slip44@4.0.0, npm/@metamask/snaps-utils@8.1.1

View full report↗︎

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 14, 2024
@FrederikBolding FrederikBolding force-pushed the fb/fix-phishing-detect-with-snaps branch from d5dd7b3 to 2b891cb Compare October 14, 2024 13:53
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 14, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 14, 2024

Builds ready [2b891cb]
Page Load Metrics (1928 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25222841742510245
domContentLoaded15112277190018890
load15242283192818287
domInteractive208046188
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -4 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 154 Bytes (0.00%)

Merged via the queue into develop with commit 1f1e142 Oct 14, 2024
@FrederikBolding FrederikBolding deleted the fb/fix-phishing-detect-with-snaps branch October 14, 2024 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 14, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FrederikBolding @metamaskbot @Mrtenz @GuillaumeRx @gauthierpetetin