Skip to content

Version v12.4.1 RC#27733

Merged
danjm merged 4 commits intomasterfrom
Version-v12.4.1
Oct 10, 2024
Merged

Version v12.4.1 RC#27733
danjm merged 4 commits intomasterfrom
Version-v12.4.1

Conversation

@metamaskbot
Copy link
Copy Markdown
Collaborator

📦 🚀

@github-actions github-actions Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Oct 9, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [13c758a]
Page Load Metrics (1918 ± 102 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16125781755561270
domContentLoaded15922312188517685
load159926041918213102
domInteractive137039178

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (73ad771) to head (ac46289).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27733      +/-   ##
==========================================
+ Coverage   70.07%   70.08%   +0.01%     
==========================================
  Files        1422     1423       +1     
  Lines       49702    49722      +20     
  Branches    13892    13898       +6     
==========================================
+ Hits        34827    34847      +20     
  Misses      14875    14875              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cherry-pick #27743  for v12.4.1

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [3d096c2]
Page Load Metrics (1761 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint150524841760227109
domContentLoaded146023691732215103
load150224961761229110
domInteractive17245484823

…4.1 RC (#27757)

## **Description**

Cherry picks swaps undefined object access crash hotfix intov12.4.1RC.
See [here](#27708)
for more info

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27757?quickstart=1)

## **Related issues**


https://consensyssoftware.atlassian.net/jira/software/projects/MMS/boards/447/backlog?assignee=5ae37c7e42b8a62c4e15d92a&selectedIssue=MMS-1569


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [3ebc8a7]
Page Load Metrics (1946 ± 113 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22827181791561269
domContentLoaded15632546191919594
load157227851946235113
domInteractive1392392010

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [ac46289]
Page Load Metrics (1945 ± 147 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30724321732499240
domContentLoaded162029771910297143
load162929841945305147
domInteractive259343199

@danjm danjm marked this pull request as ready for review October 10, 2024 19:51
@danjm danjm requested review from a team as code owners October 10, 2024 19:51
@danjm danjm merged commit ccb9706 into master Oct 10, 2024
@danjm danjm deleted the Version-v12.4.1 branch October 10, 2024 19:52
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants