Skip to content

fix: remove old phishfort list from clients (#27743)#27746

Merged
danjm merged 1 commit intoVersion-v12.4.1from
fix/cherry-pick-phishfort-list
Oct 10, 2024
Merged

fix: remove old phishfort list from clients (#27743)#27746
danjm merged 1 commit intoVersion-v12.4.1from
fix/cherry-pick-phishfort-list

Conversation

@AugmentedMode
Copy link
Copy Markdown
Contributor

Cherry-pick #27743 for v12.4.1

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR fixes an issue that prevented users from receiving the updated
hotlist from ETH Phishing Detect. While the client still fetched the
hotlist, the `PhishingDetector` was unable to update with the new URLs
included in the hotlist.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27743?quickstart=1)

Fixes: #27737

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@AugmentedMode AugmentedMode requested a review from a team as a code owner October 9, 2024 23:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 9, 2024
@cryptotavares cryptotavares added the team-product-safety Push issues to Product Safety team label Oct 9, 2024
@AugmentedMode AugmentedMode self-assigned this Oct 9, 2024
@AugmentedMode AugmentedMode added team-product-safety Push issues to Product Safety team and removed team-product-safety Push issues to Product Safety team labels Oct 9, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (13c758a) to head (f9eb9df).
Report is 1 commits behind head on Version-v12.4.1.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           Version-v12.4.1   #27746      +/-   ##
===================================================
+ Coverage            70.07%   70.08%   +0.01%     
===================================================
  Files                 1422     1423       +1     
  Lines                49702    49721      +19     
  Branches             13892    13897       +5     
===================================================
+ Hits                 34827    34846      +19     
  Misses               14875    14875              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cryptotavares cryptotavares added team-product-safety Push issues to Product Safety team and removed team-product-safety Push issues to Product Safety team labels Oct 10, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [f9eb9df]
Page Load Metrics (1819 ± 112 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint156224901820248119
domContentLoaded151123531780216104
load156424351819234112
domInteractive13125382411

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [f9eb9df]
Page Load Metrics (1819 ± 112 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint156224901820248119
domContentLoaded151123531780216104
load156424351819234112
domInteractive13125382411

@danjm danjm merged commit 3d096c2 into Version-v12.4.1 Oct 10, 2024
@danjm danjm deleted the fix/cherry-pick-phishfort-list branch October 10, 2024 10:56
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template team-product-safety Push issues to Product Safety team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants